unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#15076: 24.3.50; Syntax highlighting in the octave-mode
@ 2013-08-12 13:55 Ivan Oreshnikov
  2013-09-28  2:59 ` Leo Liu
  0 siblings, 1 reply; 9+ messages in thread
From: Ivan Oreshnikov @ 2013-08-12 13:55 UTC (permalink / raw)
  To: 15076

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]


Hello.

I use a color theme that assigns a different background color for
syntastic elements and I've noticed that empty space gets highlighted
with a builtin face (see screenshot in attachment). Is there a way to
fix that?


[-- Attachment #2: Screenshot --]
[-- Type: image/png, Size: 12962 bytes --]

[-- Attachment #3: Type: text/plain, Size: 14565 bytes --]


In GNU Emacs 24.3.50.1 (i686-pc-linux-gnu, X toolkit, Xaw scroll bars)
 of 2013-08-05 on mercury, modified by Debian
 (emacs-snapshot package, version 2:20130804-1~ppa1~raring1)
Windowing system distributor `The X.Org Foundation', version 11.0.11303000
System Description:	Ubuntu 13.04

Configured using:
 `configure --build i686-linux-gnu --host i686-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var
 --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/24.3.50/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.3.50/site-lisp:/usr/share/emacs/site-lisp
 --without-compress-info --with-crt-dir=/usr/lib/i386-linux-gnu/
 --with-x=yes --with-x-toolkit=lucid CFLAGS='-DDEBIAN
 -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' CPPFLAGS='-D_FORTIFY_SOURCE=2'
 LDFLAGS='-g -Wl,--as-needed -znocombreloc''

Important settings:
  value of $LANG: ru_RU.UTF-8
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  flyspell-mode: t
  rainbow-delimiters-mode: t
  jabber-activity-mode: t
  jabber-mode-line-mode: t
  show-paren-mode: t
  electric-pair-mode: t
  ido-everywhere: t
  global-auto-revert-mode: t
  global-subword-mode: t
  subword-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x r e p o <tab> r <tab> <return>

Recent messages:
Loading /home/me/.emacs.d/gnus.el (source)...done
Loading /home/me/.emacs.d/eshell.el (source)...done
Loading /home/me/.emacs.d/maxima.el (source)...done
Loading /home/me/.emacs.d/octave.el (source)...done
Local Ispell dictionary set to en
Starting new Ispell process [/usr/bin/aspell::en] ...
Package assoc is obsolete!
Starting Emacs daemon.
When done with this frame, type C-x 5 0
Making completion list...

Load-path shadows:
/home/me/.emacs.d/elpa/org-20130730.1244/org-rmail hides /usr/share/emacs/24.3.50/lisp/org/org-rmail
/home/me/.emacs.d/elpa/org-20130730.1244/org-faces hides /usr/share/emacs/24.3.50/lisp/org/org-faces
/home/me/.emacs.d/elpa/org-20130730.1244/ob-lob hides /usr/share/emacs/24.3.50/lisp/org/ob-lob
/home/me/.emacs.d/elpa/org-20130730.1244/ob-ref hides /usr/share/emacs/24.3.50/lisp/org/ob-ref
/home/me/.emacs.d/elpa/org-20130730.1244/ob-ocaml hides /usr/share/emacs/24.3.50/lisp/org/ob-ocaml
/home/me/.emacs.d/elpa/org-20130730.1244/org-id hides /usr/share/emacs/24.3.50/lisp/org/org-id
/home/me/.emacs.d/elpa/org-20130730.1244/ob-matlab hides /usr/share/emacs/24.3.50/lisp/org/ob-matlab
/home/me/.emacs.d/elpa/org-20130730.1244/ob-picolisp hides /usr/share/emacs/24.3.50/lisp/org/ob-picolisp
/home/me/.emacs.d/elpa/org-20130730.1244/ob-screen hides /usr/share/emacs/24.3.50/lisp/org/ob-screen
/home/me/.emacs.d/elpa/org-20130730.1244/org-timer hides /usr/share/emacs/24.3.50/lisp/org/org-timer
/home/me/.emacs.d/elpa/org-20130730.1244/ob hides /usr/share/emacs/24.3.50/lisp/org/ob
/home/me/.emacs.d/elpa/org-20130730.1244/ob-org hides /usr/share/emacs/24.3.50/lisp/org/ob-org
/home/me/.emacs.d/elpa/org-20130730.1244/ob-clojure hides /usr/share/emacs/24.3.50/lisp/org/ob-clojure
/home/me/.emacs.d/elpa/org-20130730.1244/ob-python hides /usr/share/emacs/24.3.50/lisp/org/ob-python
/home/me/.emacs.d/elpa/org-20130730.1244/org-ctags hides /usr/share/emacs/24.3.50/lisp/org/org-ctags
/home/me/.emacs.d/elpa/org-20130730.1244/org-plot hides /usr/share/emacs/24.3.50/lisp/org/org-plot
/home/me/.emacs.d/elpa/org-20130730.1244/org-loaddefs hides /usr/share/emacs/24.3.50/lisp/org/org-loaddefs
/home/me/.emacs.d/elpa/org-20130730.1244/org-info hides /usr/share/emacs/24.3.50/lisp/org/org-info
/home/me/.emacs.d/elpa/org-20130730.1244/org-colview hides /usr/share/emacs/24.3.50/lisp/org/org-colview
/home/me/.emacs.d/elpa/org-20130730.1244/org-agenda hides /usr/share/emacs/24.3.50/lisp/org/org-agenda
/home/me/.emacs.d/elpa/org-20130730.1244/org-pcomplete hides /usr/share/emacs/24.3.50/lisp/org/org-pcomplete
/home/me/.emacs.d/elpa/org-20130730.1244/ob-eval hides /usr/share/emacs/24.3.50/lisp/org/ob-eval
/home/me/.emacs.d/elpa/org-20130730.1244/ob-gnuplot hides /usr/share/emacs/24.3.50/lisp/org/ob-gnuplot
/home/me/.emacs.d/elpa/org-20130730.1244/ob-ditaa hides /usr/share/emacs/24.3.50/lisp/org/ob-ditaa
/home/me/.emacs.d/elpa/org-20130730.1244/org-clock hides /usr/share/emacs/24.3.50/lisp/org/org-clock
/home/me/.emacs.d/elpa/org-20130730.1244/ob-fortran hides /usr/share/emacs/24.3.50/lisp/org/ob-fortran
/home/me/.emacs.d/elpa/org-20130730.1244/org-capture hides /usr/share/emacs/24.3.50/lisp/org/org-capture
/home/me/.emacs.d/elpa/org-20130730.1244/ob-dot hides /usr/share/emacs/24.3.50/lisp/org/ob-dot
/home/me/.emacs.d/elpa/org-20130730.1244/org-compat hides /usr/share/emacs/24.3.50/lisp/org/org-compat
/home/me/.emacs.d/elpa/org-20130730.1244/ob-scheme hides /usr/share/emacs/24.3.50/lisp/org/ob-scheme
/home/me/.emacs.d/elpa/org-20130730.1244/org-table hides /usr/share/emacs/24.3.50/lisp/org/org-table
/home/me/.emacs.d/elpa/org-20130730.1244/org-crypt hides /usr/share/emacs/24.3.50/lisp/org/org-crypt
/home/me/.emacs.d/elpa/org-20130730.1244/org-archive hides /usr/share/emacs/24.3.50/lisp/org/org-archive
/home/me/.emacs.d/elpa/org-20130730.1244/org-footnote hides /usr/share/emacs/24.3.50/lisp/org/org-footnote
/home/me/.emacs.d/elpa/org-20130730.1244/ob-haskell hides /usr/share/emacs/24.3.50/lisp/org/ob-haskell
/home/me/.emacs.d/elpa/org-20130730.1244/org-mhe hides /usr/share/emacs/24.3.50/lisp/org/org-mhe
/home/me/.emacs.d/elpa/org-20130730.1244/ob-perl hides /usr/share/emacs/24.3.50/lisp/org/ob-perl
/home/me/.emacs.d/elpa/org-20130730.1244/ob-lisp hides /usr/share/emacs/24.3.50/lisp/org/ob-lisp
/home/me/.emacs.d/elpa/org-20130730.1244/ob-calc hides /usr/share/emacs/24.3.50/lisp/org/ob-calc
/home/me/.emacs.d/elpa/org-20130730.1244/ob-emacs-lisp hides /usr/share/emacs/24.3.50/lisp/org/ob-emacs-lisp
/home/me/.emacs.d/elpa/org-20130730.1244/org-entities hides /usr/share/emacs/24.3.50/lisp/org/org-entities
/home/me/.emacs.d/elpa/org-20130730.1244/org-w3m hides /usr/share/emacs/24.3.50/lisp/org/org-w3m
/home/me/.emacs.d/elpa/org-20130730.1244/ob-tangle hides /usr/share/emacs/24.3.50/lisp/org/ob-tangle
/home/me/.emacs.d/elpa/org-20130730.1244/org-mouse hides /usr/share/emacs/24.3.50/lisp/org/org-mouse
/home/me/.emacs.d/elpa/org-20130730.1244/ob-keys hides /usr/share/emacs/24.3.50/lisp/org/ob-keys
/home/me/.emacs.d/elpa/org-20130730.1244/ob-ruby hides /usr/share/emacs/24.3.50/lisp/org/ob-ruby
/home/me/.emacs.d/elpa/org-20130730.1244/org-irc hides /usr/share/emacs/24.3.50/lisp/org/org-irc
/home/me/.emacs.d/elpa/org-20130730.1244/org-protocol hides /usr/share/emacs/24.3.50/lisp/org/org-protocol
/home/me/.emacs.d/elpa/org-20130730.1244/org-habit hides /usr/share/emacs/24.3.50/lisp/org/org-habit
/home/me/.emacs.d/elpa/org-20130730.1244/org-install hides /usr/share/emacs/24.3.50/lisp/org/org-install
/home/me/.emacs.d/elpa/org-20130730.1244/org-feed hides /usr/share/emacs/24.3.50/lisp/org/org-feed
/home/me/.emacs.d/elpa/org-20130730.1244/ob-css hides /usr/share/emacs/24.3.50/lisp/org/ob-css
/home/me/.emacs.d/elpa/org-20130730.1244/org-attach hides /usr/share/emacs/24.3.50/lisp/org/org-attach
/home/me/.emacs.d/elpa/org-20130730.1244/ob-R hides /usr/share/emacs/24.3.50/lisp/org/ob-R
/home/me/.emacs.d/elpa/org-20130730.1244/ob-asymptote hides /usr/share/emacs/24.3.50/lisp/org/ob-asymptote
/home/me/.emacs.d/elpa/org-20130730.1244/ob-table hides /usr/share/emacs/24.3.50/lisp/org/ob-table
/home/me/.emacs.d/elpa/org-20130730.1244/ob-scala hides /usr/share/emacs/24.3.50/lisp/org/ob-scala
/home/me/.emacs.d/elpa/org-20130730.1244/org-mobile hides /usr/share/emacs/24.3.50/lisp/org/org-mobile
/home/me/.emacs.d/elpa/org-20130730.1244/ob-latex hides /usr/share/emacs/24.3.50/lisp/org/ob-latex
/home/me/.emacs.d/elpa/org-20130730.1244/org-element hides /usr/share/emacs/24.3.50/lisp/org/org-element
/home/me/.emacs.d/elpa/org-20130730.1244/ob-awk hides /usr/share/emacs/24.3.50/lisp/org/ob-awk
/home/me/.emacs.d/elpa/org-20130730.1244/ob-sql hides /usr/share/emacs/24.3.50/lisp/org/ob-sql
/home/me/.emacs.d/elpa/org-20130730.1244/org-list hides /usr/share/emacs/24.3.50/lisp/org/org-list
/home/me/.emacs.d/elpa/org-20130730.1244/ob-exp hides /usr/share/emacs/24.3.50/lisp/org/ob-exp
/home/me/.emacs.d/elpa/org-20130730.1244/org-src hides /usr/share/emacs/24.3.50/lisp/org/org-src
/home/me/.emacs.d/elpa/org-20130730.1244/ob-lilypond hides /usr/share/emacs/24.3.50/lisp/org/ob-lilypond
/home/me/.emacs.d/elpa/org-20130730.1244/ob-mscgen hides /usr/share/emacs/24.3.50/lisp/org/ob-mscgen
/home/me/.emacs.d/elpa/org-20130730.1244/org-macs hides /usr/share/emacs/24.3.50/lisp/org/org-macs
/home/me/.emacs.d/elpa/org-20130730.1244/org-bbdb hides /usr/share/emacs/24.3.50/lisp/org/org-bbdb
/home/me/.emacs.d/elpa/org-20130730.1244/org-docview hides /usr/share/emacs/24.3.50/lisp/org/org-docview
/home/me/.emacs.d/elpa/org-20130730.1244/ob-C hides /usr/share/emacs/24.3.50/lisp/org/ob-C
/home/me/.emacs.d/elpa/org-20130730.1244/ob-plantuml hides /usr/share/emacs/24.3.50/lisp/org/ob-plantuml
/home/me/.emacs.d/elpa/org-20130730.1244/ob-io hides /usr/share/emacs/24.3.50/lisp/org/ob-io
/home/me/.emacs.d/elpa/org-20130730.1244/org-bibtex hides /usr/share/emacs/24.3.50/lisp/org/org-bibtex
/home/me/.emacs.d/elpa/org-20130730.1244/ob-sh hides /usr/share/emacs/24.3.50/lisp/org/ob-sh
/home/me/.emacs.d/elpa/org-20130730.1244/org-indent hides /usr/share/emacs/24.3.50/lisp/org/org-indent
/home/me/.emacs.d/elpa/org-20130730.1244/ob-ledger hides /usr/share/emacs/24.3.50/lisp/org/ob-ledger
/home/me/.emacs.d/elpa/org-20130730.1244/ob-sass hides /usr/share/emacs/24.3.50/lisp/org/ob-sass
/home/me/.emacs.d/elpa/org-20130730.1244/ob-shen hides /usr/share/emacs/24.3.50/lisp/org/ob-shen
/home/me/.emacs.d/elpa/org-20130730.1244/org-gnus hides /usr/share/emacs/24.3.50/lisp/org/org-gnus
/home/me/.emacs.d/elpa/org-20130730.1244/ob-java hides /usr/share/emacs/24.3.50/lisp/org/ob-java
/home/me/.emacs.d/elpa/org-20130730.1244/ob-sqlite hides /usr/share/emacs/24.3.50/lisp/org/ob-sqlite
/home/me/.emacs.d/elpa/org-20130730.1244/ob-octave hides /usr/share/emacs/24.3.50/lisp/org/ob-octave
/home/me/.emacs.d/elpa/org-20130730.1244/ob-maxima hides /usr/share/emacs/24.3.50/lisp/org/ob-maxima
/home/me/.emacs.d/elpa/org-20130730.1244/org-eshell hides /usr/share/emacs/24.3.50/lisp/org/org-eshell
/home/me/.emacs.d/elpa/org-20130730.1244/org-datetree hides /usr/share/emacs/24.3.50/lisp/org/org-datetree
/home/me/.emacs.d/elpa/org-20130730.1244/org-inlinetask hides /usr/share/emacs/24.3.50/lisp/org/org-inlinetask
/home/me/.emacs.d/elpa/org-20130730.1244/ob-js hides /usr/share/emacs/24.3.50/lisp/org/ob-js
/home/me/.emacs.d/elpa/org-20130730.1244/org hides /usr/share/emacs/24.3.50/lisp/org/org
/home/me/.emacs.d/elpa/org-20130730.1244/ob-comint hides /usr/share/emacs/24.3.50/lisp/org/ob-comint
/home/me/.emacs.d/elpa/magit-20130726.1125/.dir-locals hides /usr/share/emacs/24.3.50/lisp/gnus/.dir-locals

Features:
(shadow sort mail-extr emacsbug sendmail help-mode pp server flyspell
ispell rainbow-delimiters octave smie imaxima imaxima-autoconf-variables
maxima maxima-font-lock esh-var esh-io esh-cmd esh-opt esh-ext esh-proc
esh-arg eldoc esh-groups eshell esh-module esh-mode esh-util jabber
jabber-awesome jabber-osd jabber-wmii jabber-xmessage jabber-festival
jabber-sawfish jabber-ratpoison jabber-screen jabber-socks5
jabber-ft-server jabber-si-server jabber-ft-client jabber-ft-common
jabber-si-client jabber-si-common jabber-feature-neg jabber-truncate
jabber-time jabber-autoaway jabber-vcard-avatars jabber-chatstates
jabber-events jabber-vcard jabber-avatar jabber-activity jabber-watch
jabber-modeline jabber-ahc-presence jabber-ahc jabber-version
jabber-ourversion jabber-muc-nick-completion hippie-exp jabber-browse
jabber-search jabber-register jabber-roster jabber-presence assoc
jabber-muc jabber-newdisco jabber-widget jabber-disco jabber-chat
jabber-history jabber-chatbuffer jabber-alert jabber-iq jabber-keymap
jabber-core jabber-sasl sasl sasl-anonymous sasl-login sasl-plain fsm
jabber-logon jabber-conn srv dns starttls tls jabber-xml xml jabber-menu
jabber-util reftex reftex-vars tex ox-md ox-latex ox-icalendar ox-html
ox-ascii ox-publish ox org-element paren electric git-status ewoc
git-emacs git-emacs-autoloads git-global-keys time-stamp vc-git vc
vc-dispatcher ediff-merg ediff-wind ediff-diff ediff-mult ediff-help
ediff-init ediff-util ediff uniquify dired-x dired ido autorevert
filenotify superword subword org-contacts org-capture org-agenda
gnus-art mm-uu mml2015 epg-config mm-view mml-smime smime password-cache
dig mailcap gnus-sum nnoo gnus-group gnus-undo nnmail mail-source
gnus-start gnus-spec gnus-int gnus-range message cl-macs gv rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045
ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus gnus-ems
nnheader mail-utils mm-util mail-prsvr wid-edit gnus-util org byte-opt
bytecomp byte-compile cconv advice help-fns org-macro org-footnote
org-pcomplete pcomplete org-list org-faces org-entities time-date
noutline outline easy-mmode org-version ob-emacs-lisp ob ob-tangle
org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint comint
ansi-color ring ob-core ob-eval org-compat org-macs org-loaddefs
format-spec find-func cal-menu calendar cal-loaddefs cl nadvice
focus-mode tex-site edmacro kmacro cl-loaddefs cl-lib jabber-autoloads
info easymenu rainbow-mode-autoloads package cyril-util tooltip
ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd
fontset image regexp-opt fringe tabulated-list newcomment lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer loaddefs button faces cus-face macroexp files text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
gfilenotify dynamic-setting system-font-setting font-render-setting
x-toolkit x multi-tty emacs)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#15076: 24.3.50; Syntax highlighting in the octave-mode
  2013-08-12 13:55 bug#15076: 24.3.50; Syntax highlighting in the octave-mode Ivan Oreshnikov
@ 2013-09-28  2:59 ` Leo Liu
  2013-09-28  8:31   ` Ivan Oreshnikov
  0 siblings, 1 reply; 9+ messages in thread
From: Leo Liu @ 2013-09-28  2:59 UTC (permalink / raw)
  To: Ivan Oreshnikov; +Cc: 15076

On 2013-08-12 21:55 +0800, Ivan Oreshnikov wrote:
> I use a color theme that assigns a different background color for
> syntastic elements and I've noticed that empty space gets highlighted
> with a builtin face (see screenshot in attachment). Is there a way to
> fix that?

Doesn't look like to a bug in emacs. Consider reporting it to the color
theme maker.

Leo





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#15076: 24.3.50; Syntax highlighting in the octave-mode
  2013-09-28  2:59 ` Leo Liu
@ 2013-09-28  8:31   ` Ivan Oreshnikov
  2013-09-28  9:45     ` Leo Liu
  0 siblings, 1 reply; 9+ messages in thread
From: Ivan Oreshnikov @ 2013-09-28  8:31 UTC (permalink / raw)
  To: Leo Liu; +Cc: 15076

> > I use a color theme that assigns a different background color for
> > syntastic elements and I've noticed that empty space gets highlighted
> > with a builtin face (see screenshot in attachment). Is there a way to
> > fix that?

> Doesn't look like to a bug in emacs. Consider reporting it to the color
> theme maker.

My description was not clear enough, sorry for that.

The problem is in the octave-mode's parser -- it hightlights the entire
scope of a function with the `font-lock-builtin-face`. It was introduced
in the new version of octave-mode, which merged old `octave-mod` and
`octave-inf` together. The color theme that I use just makes this error
evident.

Ivan.






^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#15076: 24.3.50; Syntax highlighting in the octave-mode
  2013-09-28  8:31   ` Ivan Oreshnikov
@ 2013-09-28  9:45     ` Leo Liu
  2013-09-28 18:52       ` Ivan Oreshnikov
  2013-10-11  8:46       ` Ivan Oreshnikov
  0 siblings, 2 replies; 9+ messages in thread
From: Leo Liu @ 2013-09-28  9:45 UTC (permalink / raw)
  To: Ivan Oreshnikov; +Cc: 15076

On 2013-09-28 16:31 +0800, Ivan Oreshnikov wrote:
> My description was not clear enough, sorry for that.
>
> The problem is in the octave-mode's parser -- it hightlights the entire
> scope of a function with the `font-lock-builtin-face`. It was introduced
> in the new version of octave-mode, which merged old `octave-mod` and
> `octave-inf` together. The color theme that I use just makes this error
> evident.

Could you provide a recipe to reproduce the bug?

Unfortunately from looking how font-lock-builtin-face is used in
octave.el I cannot find where the bug is.

thanks,
Leo





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#15076: 24.3.50; Syntax highlighting in the octave-mode
  2013-09-28  9:45     ` Leo Liu
@ 2013-09-28 18:52       ` Ivan Oreshnikov
  2013-10-11  8:46       ` Ivan Oreshnikov
  1 sibling, 0 replies; 9+ messages in thread
From: Ivan Oreshnikov @ 2013-09-28 18:52 UTC (permalink / raw)
  To: Leo Liu; +Cc: 15076

Right now I'm using a different machine. Using new octave.el from the
git repo I can't reporduce the bug. I'll write the followup later when I
get my hands on the original setup.

Ivan.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#15076: 24.3.50; Syntax highlighting in the octave-mode
  2013-09-28  9:45     ` Leo Liu
  2013-09-28 18:52       ` Ivan Oreshnikov
@ 2013-10-11  8:46       ` Ivan Oreshnikov
  2013-11-22  2:37         ` Leo Liu
  1 sibling, 1 reply; 9+ messages in thread
From: Ivan Oreshnikov @ 2013-10-11  8:46 UTC (permalink / raw)
  To: Leo Liu; +Cc: 15076

Sorry for the late reply. I'm able to reproduce the issue with

`emacs-snapshot' from unstable branch of http://emacs.naquadah.org/,

which uses this git repository to host its sources

http://anonscm.debian.org/gitweb/?p=users/acid/emacs-snapshot.git;a=summary

According to the `octave.el' history

http://anonscm.debian.org/gitweb/?p=users/acid/emacs-snapshot.git;a=history;f=lisp/progmodes/octave.el;h=899bf151a2c025c9abd8b749460d5b4e28174abe;hb=refs/heads/debian/unstable

your latest commits should be in the tree already. My current emacs
version is

"GNU Emacs 24.3.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.8.4)
 of 2013-10-03 on prometheus, modified by Debian".

so it seems that your latest commits should be applied to my local
`octave.el' too.


In my previous email I wrote that the bug was fixed in the latest file
from git, however I've noticed that simple evaluation of the file will
not replace my `octave-mode' function; therefore I was working with the
old `octave-mode' version from the stable release at the time.


To reproduce the issue you should

1. Change the background color of the builtin face to make things more
   evident. For example, run `customize-face' for
   `font-lock-builtin-face' and change the background color to
   something bright and annoying like `firebrick'. 
2. Open any octave file with the function definition inside. Blank
   space in the scope of the function should be bright red.

Hope it helps.


Ivan.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#15076: 24.3.50; Syntax highlighting in the octave-mode
  2013-10-11  8:46       ` Ivan Oreshnikov
@ 2013-11-22  2:37         ` Leo Liu
  2013-11-22 14:26           ` Stefan Monnier
  0 siblings, 1 reply; 9+ messages in thread
From: Leo Liu @ 2013-11-22  2:37 UTC (permalink / raw)
  To: Ivan Oreshnikov; +Cc: 15076-done

Fixed in 24.4

On 2013-10-11 16:46 +0800, Ivan Oreshnikov wrote:
> To reproduce the issue you should
>
> 1. Change the background color of the builtin face to make things more
>    evident. For example, run `customize-face' for
>    `font-lock-builtin-face' and change the background color to
>    something bright and annoying like `firebrick'. 
> 2. Open any octave file with the function definition inside. Blank
>    space in the scope of the function should be bright red.
>
> Hope it helps.
>
>
> Ivan.

Thanks for the detailed report and I can reproduce the bug. Could you
verify it is fixed? Thanks.

Stefan,

This bug was due to including \n in octave-operator-regexp. My fix in
r115180 removes it. Do you see any issue with it? Thanks.

Leo





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#15076: 24.3.50; Syntax highlighting in the octave-mode
  2013-11-22  2:37         ` Leo Liu
@ 2013-11-22 14:26           ` Stefan Monnier
  2013-11-22 14:38             ` Leo Liu
  0 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2013-11-22 14:26 UTC (permalink / raw)
  To: Leo Liu; +Cc: Ivan Oreshnikov, 15076-done

> This bug was due to including \n in octave-operator-regexp. My fix in
> r115180 removes it. Do you see any issue with it? Thanks.

Can't remember.  Just make sure any problem you fix is reflected by
a sample code in test/indent/octave.m and that the fix doesn't break the
examples already present.


        Stefan





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#15076: 24.3.50; Syntax highlighting in the octave-mode
  2013-11-22 14:26           ` Stefan Monnier
@ 2013-11-22 14:38             ` Leo Liu
  0 siblings, 0 replies; 9+ messages in thread
From: Leo Liu @ 2013-11-22 14:38 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Ivan Oreshnikov, 15076

On 2013-11-22 22:26 +0800, Stefan Monnier wrote:
> Can't remember.  Just make sure any problem you fix is reflected by
> a sample code in test/indent/octave.m and that the fix doesn't break the
> examples already present.
>
>
>         Stefan

No, nothing breaks in test/indent/octave.m. The fix was not to
font-locking \n as builtin operators i.e. it is font-lock related.

Leo





^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2013-11-22 14:38 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-12 13:55 bug#15076: 24.3.50; Syntax highlighting in the octave-mode Ivan Oreshnikov
2013-09-28  2:59 ` Leo Liu
2013-09-28  8:31   ` Ivan Oreshnikov
2013-09-28  9:45     ` Leo Liu
2013-09-28 18:52       ` Ivan Oreshnikov
2013-10-11  8:46       ` Ivan Oreshnikov
2013-11-22  2:37         ` Leo Liu
2013-11-22 14:26           ` Stefan Monnier
2013-11-22 14:38             ` Leo Liu

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).