From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenjiro NAKAYAMA Newsgroups: gmane.emacs.bugs Subject: bug#16142: 24.3.50; [PATCH] eww: Delete keymap to eww-submit with Enter in the text field. Date: Wed, 25 Dec 2013 19:37:25 +0900 Message-ID: <87wqit1aje.fsf@dhcp-193-97.nrt.redhat.com> References: <878uvn1vd8.fsf@dhcp-193-97.nrt.redhat.com> <87mwjqzp0e.fsf@building.gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1387967895 27585 80.91.229.3 (25 Dec 2013 10:38:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Dec 2013 10:38:15 +0000 (UTC) Cc: Kenjiro NAKAYAMA , 16142@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 25 11:38:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vvlr2-0005cj-M2 for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Dec 2013 11:38:20 +0100 Original-Received: from localhost ([::1]:41973 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vvlr1-0007gX-VW for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Dec 2013 05:38:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vvlqt-0007g5-VR for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 05:38:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vvlqk-00084c-Lq for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 05:38:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vvlqk-00084Y-HJ for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 05:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vvlqk-0007yH-0a for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 05:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kenjiro NAKAYAMA Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Dec 2013 10:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16142 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug patch wontfix Original-Received: via spool by 16142-submit@debbugs.gnu.org id=B16142.138796786630610 (code B ref 16142); Wed, 25 Dec 2013 10:38:01 +0000 Original-Received: (at 16142) by debbugs.gnu.org; 25 Dec 2013 10:37:46 +0000 Original-Received: from localhost ([127.0.0.1]:40637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvlqQ-0007xa-IQ for submit@debbugs.gnu.org; Wed, 25 Dec 2013 05:37:46 -0500 Original-Received: from mail-pd0-f182.google.com ([209.85.192.182]:60576) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvlqK-0007xN-WA for 16142@debbugs.gnu.org; Wed, 25 Dec 2013 05:37:41 -0500 Original-Received: by mail-pd0-f182.google.com with SMTP id v10so7125565pde.13 for <16142@debbugs.gnu.org>; Wed, 25 Dec 2013 02:37:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; bh=zgASIXBwIu31IWIMHHsuY8XS5yF1DPGZe+6aqEJmKz0=; b=D/HC8TlTi0/utoAA+khM1I+GP0IWjvPs/bmPgBGExfsgI6znWZ/mxuRYDDYFbuCSb2 LY4fRaoas0+fyPP0T86RDau9yALP/GIUQqilU556IbzfJM87DvjILYo8P4amM+OQCkIp fbtPDA5rMuETlQHZrycdLu0sl+KLLRL3vPFGhAYzgoTEEpH5MvDXuoqDHdK7mweVrR53 u9wMyQddYEQd9cKtKszYwEU0yKMgMY7tHWhIQhKFtqhyarRIpF9jQ+iDpB+gp/SCUcQ0 Xkto5qKHDtI4uyWcoXs5UzhVgVp70kOemWtLgTqlLVgzbhihoxqS8or7atppbi5elGSC tUXg== X-Received: by 10.68.143.100 with SMTP id sd4mr22332410pbb.0.1387967855912; Wed, 25 Dec 2013 02:37:35 -0800 (PST) Original-Received: from dhcp-193-97.nrt.redhat.com (nat-pool-nrt-u1.redhat.com. [66.187.238.11]) by mx.google.com with ESMTPSA id ja5sm47518404pbc.14.2013.12.25.02.37.32 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Dec 2013 02:37:33 -0800 (PST) User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.2 In-reply-to: <87mwjqzp0e.fsf@building.gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82579 Archived-At: > It's how all other web browsers work, and is necessary for using the web > at all. It's common now to eschew submit buttons. So rejected. You are right, it was my mistake. But it is the problem that users can't distiguish input text from textarea, like following HTML.

I think eww should change the color to distinguish. I send new patch, please reconsider and review it. Signed-off-by: Kenjiro NAKAYAMA * net/eww.el(eww-form-textarea): New defface for textarea. (eww-tag-textarea): Apply textarea color. --- lisp/net/eww.el | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 02c93a0..576778c 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -115,6 +115,14 @@ See also `eww-form-checkbox-selected-symbol'." :version "24.4" :group 'eww) +(defface eww-form-textarea + '((t (:background "#C0C0C0" + :foreground "black" + :box (:line-width 1)))) + "Face for eww text inputs." + :version "24.4" + :group 'eww) + (defvar eww-current-url nil) (defvar eww-current-dom nil) (defvar eww-current-source nil) @@ -776,7 +784,7 @@ See URL `https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input'.") (when (> pad 0) (insert (make-string pad ? )))) (add-face-text-property (line-beginning-position) - (point) 'eww-form-text) + (point) 'eww-form-textarea) (put-text-property (line-beginning-position) (point) 'local-map eww-textarea-map) (forward-line 1)) -- 1.8.3.1 Regards, Kenjiro larsi@gnus.org writes: > Kenjiro NAKAYAMA writes: > >> The key map to eww-submit with Enter key in the text field should be >> deleted. It is easy to mistake. > > It's how all other web browsers work, and is necessary for using the web > at all. It's common now to eschew submit buttons. So rejected.