From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ethan Glasser-Camp Newsgroups: gmane.emacs.bugs Subject: bug#17947: 24.3; ruby-mode sets require-final-newline unconditionally Date: Sat, 05 Jul 2014 14:07:16 -0400 Message-ID: <87wqbrllwr.fsf@betacantrips.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1404583763 17294 80.91.229.3 (5 Jul 2014 18:09:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Jul 2014 18:09:23 +0000 (UTC) To: 17947@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 05 20:09:16 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X3UOi-0007Xh-1i for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Jul 2014 20:09:16 +0200 Original-Received: from localhost ([::1]:43603 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3UOh-0003Lr-C7 for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Jul 2014 14:09:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3UOZ-0003KI-HG for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 14:09:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3UOU-0007yX-M9 for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 14:09:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3UOU-0007yP-IN for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 14:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X3UOU-00050Q-6l for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 14:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ethan Glasser-Camp Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Jul 2014 18:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17947 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.140458369619180 (code B ref -1); Sat, 05 Jul 2014 18:09:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Jul 2014 18:08:16 +0000 Original-Received: from localhost ([127.0.0.1]:44314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3UNk-0004zI-1b for submit@debbugs.gnu.org; Sat, 05 Jul 2014 14:08:16 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:32954) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3UNh-0004z0-P5 for submit@debbugs.gnu.org; Sat, 05 Jul 2014 14:08:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3UNX-0007uf-L0 for submit@debbugs.gnu.org; Sat, 05 Jul 2014 14:08:08 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:49805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3UNX-0007ub-IN for submit@debbugs.gnu.org; Sat, 05 Jul 2014 14:08:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3UNS-0003Fc-AU for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 14:08:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3UNN-0007tY-Gc for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 14:07:58 -0400 Original-Received: from mail-qa0-x22c.google.com ([2607:f8b0:400d:c00::22c]:56567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3UNN-0007tN-Bp for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 14:07:53 -0400 Original-Received: by mail-qa0-f44.google.com with SMTP id hw13so2241551qab.31 for ; Sat, 05 Jul 2014 11:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=/uPs9wKK59E/KRvtwYBCf5XOZnJHAXFtXcfPOg76a8g=; b=Wp0fQROhSxRQSksjnsE+KGEYpY3w+jNseDEaSEsXaUwObHTGzENSUaBnW+0AeEo4qB xXdNNOslEJ4oAgbtitatFDrzBOZjsmMFUglKSk6hVG2J30Yg+vjSZTtFoc6/Hksr01VU CvVUl6ePMbbMzUomdZkF8qmt2ZCRswqYXZJDweCCSw1LUfulNb6pTBQUscYB7PjrdbGR bAvTxzP7b6s6EpXWQ5ktNJH0r7JE9Qxnw0SND6smRQc9SDc0ByTnj2QOWmKOgzeiKPQD Et2gnOwIFoSqa4OTbIs4E4EdrP5wa5lfRwpPJNyLmaw14pVCI9qahfusLjdHR83E6GxQ dsTw== X-Received: by 10.224.51.18 with SMTP id b18mr31677588qag.81.1404583669839; Sat, 05 Jul 2014 11:07:49 -0700 (PDT) Original-Received: from silver ([66.114.71.21]) by mx.google.com with ESMTPSA id t3sm63086848qai.28.2014.07.05.11.07.49 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 05 Jul 2014 11:07:49 -0700 (PDT) X-Google-Original-From: Ethan Glasser-Camp X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91214 Archived-At: I am the maintainer of a package called emacs-wspace, available at github at https://github.com/glasserc/ethan-wspace/. The goal of the package is to help keep whitespace in files clean without introducing spurious whitespace changes. In order to do this, the package requires users to turn off require-final-newline and sometimes mode-require-final-newline. If ethan-wspace discovers that require-final-newline is set to t, it admonishes the user. One user reported that ruby-mode triggers this warning. Sure enough, in ruby-mode.el at line 287, I see: (set (make-local-variable 'require-final-newline) t) There is some precedent for doing this sort of thing with the variable mode-require-final-newline. Is it possible for ruby-mode to respect this variable? More discussion can be found at this bug report for cucumber.el, another mode which seems to borrow the pattern from ruby-mode: https://github.com/michaelklishin/cucumber.el/pull/51 Thank you for your time. Ethan In GNU Emacs 24.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.10.7) of 2014-03-07 on lamiak, modified by Debian Windowing system distributor `The X.Org Foundation', version 11.0.11501000 System Description: Ubuntu 14.04 LTS Configured using: `configure '--build' 'x86_64-linux-gnu' '--build' 'x86_64-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.3/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.3/site-lisp:/usr/share/emacs/site-lisp' '--with-crt-dir=/usr/lib/x86_64-linux-gnu' '--with-x=yes' '--with-x-toolkit=gtk3' '--with-toolkit-scroll-bars' 'build_alias=x86_64-linux-gnu' 'CFLAGS=-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall' 'LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro' 'CPPFLAGS=-D_FORTIFY_SOURCE=2'' Important settings: value of $LC_MONETARY: en_US.UTF-8 value of $LC_NUMERIC: en_US.UTF-8 value of $LC_TIME: en_US.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: M-x C-x o r e p o r t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Making completion list... Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-mode easymenu time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)