From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Matthew Leach Newsgroups: gmane.emacs.bugs Subject: bug#1702: [PATCH]: feature request: correctly display single file zip archive Date: Thu, 13 Nov 2014 18:39:43 +0000 Message-ID: <87wq6zj66o.fsf_-_@loki.home> References: <87lju1hv7b.fsf@cyd.mit.edu> <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1415904035 25482 80.91.229.3 (13 Nov 2014 18:40:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Nov 2014 18:40:35 +0000 (UTC) Cc: 1702@debbugs.gnu.org, Chong Yidong To: xah lee Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 13 19:40:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XozJd-0005Zg-Ex for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Nov 2014 19:40:21 +0100 Original-Received: from localhost ([::1]:33439 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XozJd-0002ys-3G for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Nov 2014 13:40:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XozJS-0002wx-44 for bug-gnu-emacs@gnu.org; Thu, 13 Nov 2014 13:40:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XozJL-0004jG-1V for bug-gnu-emacs@gnu.org; Thu, 13 Nov 2014 13:40:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XozJK-0004gV-Uj for bug-gnu-emacs@gnu.org; Thu, 13 Nov 2014 13:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XozJK-0005zk-BU for bug-gnu-emacs@gnu.org; Thu, 13 Nov 2014 13:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matthew Leach Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Nov 2014 18:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 1702 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 1702-submit@debbugs.gnu.org id=B1702.141590399123021 (code B ref 1702); Thu, 13 Nov 2014 18:40:02 +0000 Original-Received: (at 1702) by debbugs.gnu.org; 13 Nov 2014 18:39:51 +0000 Original-Received: from localhost ([127.0.0.1]:59671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XozJ8-0005zE-R4 for submit@debbugs.gnu.org; Thu, 13 Nov 2014 13:39:51 -0500 Original-Received: from mx0.mattleach.net ([176.58.118.143]:47513) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XozJ5-0005z5-E3 for 1702@debbugs.gnu.org; Thu, 13 Nov 2014 13:39:49 -0500 Original-Received: by mx0.mattleach.net (Postfix, from userid 99) id AE39861AC1; Thu, 13 Nov 2014 18:39:46 +0000 (GMT) Original-Received: from loki.home.mattleach.net (host86-180-142-129.range86-180.btcentralplus.com [86.180.142.129]) by mx0.mattleach.net (Postfix) with ESMTPSA id 0B38661ABA; Thu, 13 Nov 2014 18:39:44 +0000 (GMT) In-Reply-To: <13EFAAB6-C6B3-4F67-A39A-5266E91A0CD5@xahlee.org> (xah lee's message of "Fri, 16 Jan 2009 12:09:30 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:95940 --=-=-= Content-Type: text/plain Hi all, xah lee writes: > When opening a zip archive of a single file, emacs displays the zip > archive's index (which is just a single file), as opposed to the > decompressed file content. > > I think when the zip file is a single file, it is more useful to > display file content and allow transparent editing. Please see the attached patch to implement this. Any comments welcome! Thanks, -- Matt ChangeLog entry: 2014-11-13 Matthew Leach * arc-mode.el (singular-file-archive-action): New. (archive-mode): Visit file if archive contains a single file. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Don-t-show-summary-for-single-file-archives.patch >From 1c84ec04f024f9de44b0bb57d60d009b9738c899 Mon Sep 17 00:00:00 2001 From: Matthew Leach Date: Thu, 13 Nov 2014 18:30:24 +0000 Subject: [PATCH] Don't show summary for single-file archives. * arc-mode.el (singular-file-archive-action): New. (archive-mode): Visit file if archive contains a single file. --- lisp/arc-mode.el | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lisp/arc-mode.el b/lisp/arc-mode.el index ef155ee..279b9a1 100644 --- a/lisp/arc-mode.el +++ b/lisp/arc-mode.el @@ -147,6 +147,13 @@ A local copy of the archive will be used when updating." "Hook run when an archive member has been extracted." :type 'hook :group 'archive) + +(defcustom singular-file-archive-action 'visit-file + "When opening an archive that contains a single file choose +whether to open the file or display the archive summary." + :type '(choice (const :tag "Show archive summary" show-summary) + (const :tag "Visit the single file" visit-file)) + :group 'archive) ;; ------------------------------ ;; Arc archive configuration @@ -742,7 +749,12 @@ archive. (if (default-value 'enable-multibyte-characters) (set-buffer-multibyte 'to)) (archive-summarize nil) - (setq buffer-read-only t)))) + (setq buffer-read-only t) + (when (and (= (length archive-files) 1) + (eq singular-file-archive-action 'visit-file)) + (let ((archive-buffer (current-buffer))) + (archive-extract) + (kill-buffer archive-buffer)))))) ;; Archive mode is suitable only for specially formatted data. (put 'archive-mode 'mode-class 'special) -- 2.1.3 --=-=-=--