unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: dieter@duenenhof-wilhelm.de (H. Dieter Wilhelm)
To: Eli Zaretskii <eliz@gnu.org>
Cc: 19129@debbugs.gnu.org
Subject: bug#19129: 25.0.50; recenter-positions is missing a reference to	move-to-window-line-top-bottom
Date: Fri, 21 Nov 2014 09:52:13 +0100	[thread overview]
Message-ID: <87wq6p9br6.fsf@vsl28t2g.ww011> (raw)
In-Reply-To: <831tox5692.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 21 Nov 2014 10:04:41 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: dieter@duenenhof-wilhelm.de (H. Dieter Wilhelm)
>> Date: Thu, 20 Nov 2014 23:14:38 +0100
>> 
>> in the documentation for recenter-positions was forgotten that it is
>> also used in move-to-window-line-top-bottom.  I added below patch as an
>> illustration.
>
> Nitpicking: In the future, please try to avoid unnecessarily changing
> parts that are unrelated to the proposed patch.  This is especially
> true for human-readable text (as opposed to code), because it makes it
> very hard to determine where are you actually changing something.

I understand, I'll try to avoid it.

> In the case in point, I'm guessing you've filled the paragraphs of the
> doc string, which wasn't really necessary, since the lines were of
> reasonable length.

Yes, that's right, but I did it mistakenly because I thought it was
forgotten and that filling a paragraph would be necessary to be in
accordance to Elisp coding conventions.

Now I learned that even though emacs-lisp-docstring-fill-column is 65 an
80 column filling might be acceptable!

Thanks for the pointer.

    Dieter
-- 
Best wishes
H. Dieter Wilhelm
Darmstadt, Germany





  reply	other threads:[~2014-11-21  8:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 22:14 bug#19129: 25.0.50; recenter-positions is missing a reference to move-to-window-line-top-bottom H. Dieter Wilhelm
2014-11-20 22:42 ` Drew Adams
2014-11-20 23:28   ` H. Dieter Wilhelm
2014-11-21  8:08     ` Eli Zaretskii
2014-11-21 10:10       ` H. Dieter Wilhelm
2014-11-21 15:33         ` Eli Zaretskii
2014-11-21  8:04 ` Eli Zaretskii
2014-11-21  8:52   ` H. Dieter Wilhelm [this message]
2014-11-21 15:14     ` Drew Adams
2014-11-21 15:30       ` Eli Zaretskii
2014-11-21 17:05       ` H. Dieter Wilhelm
2014-11-21 21:37       ` H. Dieter Wilhelm
     [not found] <<87r3wxbju9.fsf@vsl28t2g.ww011>
     [not found] ` <<831tox5692.fsf@gnu.org>
     [not found]   ` <<87wq6p9br6.fsf@vsl28t2g.ww011>
     [not found]     ` <<06151e7f-aaa2-4c36-886b-9754e980a31f@default>
     [not found]       ` <<83wq6o370s.fsf@gnu.org>
2014-11-21 15:38         ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wq6p9br6.fsf@vsl28t2g.ww011 \
    --to=dieter@duenenhof-wilhelm.de \
    --cc=19129@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).