From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?=C3=93scar?= Fuentes Newsgroups: gmane.emacs.bugs Subject: bug#17945: 24.4.50; vc-git-annotate-command is too slow Date: Wed, 25 Feb 2015 18:46:12 +0100 Message-ID: <87wq35yjdn.fsf@wanadoo.es> References: <8638egylnn.fsf@yandex.ru> <87oaojuxzy.fsf@wanadoo.es> <3i385vur8a.fsf@fencepost.gnu.org> <54ECE538.1070601@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1424886448 1932 80.91.229.3 (25 Feb 2015 17:47:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Feb 2015 17:47:28 +0000 (UTC) Cc: 17945@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 25 18:47:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YQg3H-0002DG-43 for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Feb 2015 18:47:15 +0100 Original-Received: from localhost ([::1]:55623 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQg3G-0004UC-3V for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Feb 2015 12:47:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQg38-0004Q7-68 for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 12:47:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQg34-0003KW-2Y for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 12:47:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQg34-0003KQ-09 for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 12:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YQg33-0007ov-PS for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 12:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=C3=93scar?= Fuentes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Feb 2015 17:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17945 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17945-submit@debbugs.gnu.org id=B17945.142488638430016 (code B ref 17945); Wed, 25 Feb 2015 17:47:01 +0000 Original-Received: (at 17945) by debbugs.gnu.org; 25 Feb 2015 17:46:24 +0000 Original-Received: from localhost ([127.0.0.1]:58037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQg2R-0007o2-By for submit@debbugs.gnu.org; Wed, 25 Feb 2015 12:46:23 -0500 Original-Received: from relaycp04.dominioabsoluto.net ([217.116.26.100]:54586) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQg2O-0007no-Ab for 17945@debbugs.gnu.org; Wed, 25 Feb 2015 12:46:21 -0500 Original-Received: from smtp.movistar.es (smtp08.acens.net [86.109.99.132]) by relaycp04.dominioabsoluto.net (Postfix) with ESMTP id C1BC064495; Wed, 25 Feb 2015 18:46:13 +0100 (CET) X-CTCH-RefID: str=0001.0A0B020D.54EE0A65.00F2, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-Spam: Unknown Original-Received: from qcore (88.10.128.129) by smtp.movistar.es (8.6.122.03) (authenticated as 981711563$telefonica.net) id 549C742B01FAA3B7; Wed, 25 Feb 2015 17:46:13 +0000 In-Reply-To: <54ECE538.1070601@yandex.ru> (Dmitry Gutov's message of "Tue, 24 Feb 2015 22:55:20 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99815 Archived-At: Dmitry Gutov writes: > On 02/24/2015 07:57 PM, Glenn Morris wrote: > >> except vc-annotate-switches does not exist and would also >> need to be added. > > I think this is only justified if we expect different backends' > annotate command to receive the same options. As the docstrings of vc-BACKEND-annotate-switches mention vc-annotate-switches *and* vc-switches checks vc-annotate-switches, I changed my mind again and implemented vc-annotate-switches with a caveat on the docstring. Please review and suggest a better wording, if necessary: (defcustom vc-annotate-switches nil "A string or list of strings specifying switches for annotate under VC. When running annotate under a given BACKEND, VC uses the first non-nil value of `vc-BACKEND-annotate-switches', `vc-annotate-switches', and `annotate-switches', in that order. Since nil means to check the next variable in the sequence, either of the first two may use the value t to mean no switches at all. `vc-annotate-switches' should contain switches that are specific to version control, but not specific to any particular backend. As very few switches (if any) are used across different VC tools, please consider using the specific `vc-BACKEND-annotate-switches' for the backend you use." :type '(choice (const :tag "Unspecified" nil) (const :tag "None" t) (string :tag "Argument String") (repeat :tag "Argument List" :value ("") string)) :group 'vc :version "25.1") > So far, only '-w' looks a likely candidate, albeit its descriptions > are a bit different between Git and Hg. And it's not in e.g. Bzr. > > What if the user sets `vc-annotate-switches' to '-w', and then calls > `vc-annotate' in a Bazaar repository, where it'll obviously lead to > failure? > >> And for consistency, presumably all backends should >> get the same treatment. Thanks. > > Probably. But I'd rather the present patch gets installed without too > much delay. I extended the vc-switches support to the rest of backends that implement `vc-BACKEND-annotate-command', except rcs, that does some complicated things (and I have no easy way of testing it.) Once we agree on the resolution of the vc-annotate-switches issue, I'll commit the changes.