From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#19851: 25.0.50; package-install-{file,from-buffer} broken Date: Mon, 15 Jun 2015 23:56:34 +0300 Organization: LINKOV.NET Message-ID: <87wpz5zyot.fsf@mail.linkov.net> References: <87lhk2ej84.fsf@udel.edu> <20150213010449.GA5865@holos> <20150309061049.GA10717@holos> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1434404848 23291 80.91.229.3 (15 Jun 2015 21:47:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 15 Jun 2015 21:47:28 +0000 (UTC) Cc: 19851@debbugs.gnu.org To: Mark Oteiza Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 15 23:47:17 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z4cDt-0006nx-9H for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Jun 2015 23:47:17 +0200 Original-Received: from localhost ([::1]:36591 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4cDs-0000ZB-B8 for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Jun 2015 17:47:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4cDn-0000YU-7W for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2015 17:47:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4cDf-00044e-1H for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2015 17:47:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40563) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4cDe-00044a-Tv for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2015 17:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z4cDe-0008Jd-GQ for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2015 17:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Jun 2015 21:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19851 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19851-submit@debbugs.gnu.org id=B19851.143440476831890 (code B ref 19851); Mon, 15 Jun 2015 21:47:02 +0000 Original-Received: (at 19851) by debbugs.gnu.org; 15 Jun 2015 21:46:08 +0000 Original-Received: from localhost ([127.0.0.1]:55021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z4cCk-0008IB-H2 for submit@debbugs.gnu.org; Mon, 15 Jun 2015 17:46:07 -0400 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:48711 helo=homiemail-a18.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z4cCg-0008Hk-VG for 19851@debbugs.gnu.org; Mon, 15 Jun 2015 17:46:04 -0400 Original-Received: from homiemail-a18.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTP id 9CF4B25006C; Mon, 15 Jun 2015 14:46:00 -0700 (PDT) Original-Received: from localhost.linkov.net (m213-102-82-211.cust.tele2.ee [213.102.82.211]) (Authenticated sender: jurta@jurta.org) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTPA id 9DE4E25006B; Mon, 15 Jun 2015 14:45:59 -0700 (PDT) In-Reply-To: <20150309061049.GA10717@holos> (Mark Oteiza's message of "Mon, 9 Mar 2015 02:10:49 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103972 Archived-At: > Found it. It is from using package-install-file on a directory while > saveplace is enabled. Saveplace gets stuck. From emacs -Q: > > 1. mkdir /some/new/dir > 2. Evaluate: > > (setq-default save-place t) > (require 'saveplace) > (package-initialize) > > 3. M-x package-install-file RET /some/new/dir RET > > "dired-current-directory: No subdir-alist in *temp*" > > In order to quit emacs, one has to hack around kill-emacs-hook. Does this patch fix it for you? diff --git a/lisp/saveplace.el b/lisp/saveplace.el index fe54743..5bbcd79 100644 --- a/lisp/saveplace.el +++ b/lisp/saveplace.el @@ -158,6 +158,8 @@ (defun toggle-save-place (&optional parg) ;FIXME: save-place-local-mode! \(setq-default save-place t)" (interactive "P") (if (not (or buffer-file-name (and (derived-mode-p 'dired-mode) + (boundp 'dired-subdir-alist) + dired-subdir-alist (dired-current-directory)))) (message "Buffer `%s' not visiting a file or directory" (buffer-name)) (setq save-place (if parg @@ -178,6 +180,8 @@ (defun save-place-to-alist () ;; will be saved again when Emacs is killed. (or save-place-loaded (load-save-place-alist-from-file)) (let* ((directory (and (derived-mode-p 'dired-mode) + (boundp 'dired-subdir-alist) + dired-subdir-alist (dired-current-directory))) (item (or buffer-file-name (and directory @@ -310,6 +314,8 @@ (defun save-places-to-alist () ;; save-place checks buffer-file-name too, but we can avoid ;; overhead of function call by checking here too. (and (or buffer-file-name (and (derived-mode-p 'dired-mode) + (boundp 'dired-subdir-alist) + dired-subdir-alist (dired-current-directory))) (save-place-to-alist)) (setq buf-list (cdr buf-list)))))) @@ -331,6 +337,8 @@ (defun save-place-dired-hook () "Position the point in a Dired buffer." (or save-place-loaded (load-save-place-alist-from-file)) (let* ((directory (and (derived-mode-p 'dired-mode) + (boundp 'dired-subdir-alist) + dired-subdir-alist (dired-current-directory))) (cell (assoc (and directory (expand-file-name (if (consp directory)