From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted Date: Tue, 08 Sep 2015 09:47:07 +0200 Message-ID: <87wpw1uzd0.fsf@gmx.de> References: <87k2s15sfd.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1441698504 19016 80.91.229.3 (8 Sep 2015 07:48:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Sep 2015 07:48:24 +0000 (UTC) Cc: 21432@debbugs.gnu.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 08 09:48:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZZDdS-0007zd-3g for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Sep 2015 09:48:10 +0200 Original-Received: from localhost ([::1]:60567 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZDdR-0007qn-ST for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Sep 2015 03:48:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZDdO-0007qf-SO for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2015 03:48:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZDdK-00045W-Qk for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2015 03:48:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59897) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZDdK-00045B-Nz for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2015 03:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZZDdK-00066B-G5 for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2015 03:48:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87k2s15sfd.fsf@gnu.org> Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Sep 2015 07:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21432 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21432-submit@debbugs.gnu.org id=B21432.144169843523371 (code B ref 21432); Tue, 08 Sep 2015 07:48:02 +0000 Original-Received: (at 21432) by debbugs.gnu.org; 8 Sep 2015 07:47:15 +0000 Original-Received: from localhost ([127.0.0.1]:52107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZZDcY-00064t-QB for submit@debbugs.gnu.org; Tue, 08 Sep 2015 03:47:15 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:62726) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZZDcW-00064e-Rd for 21432@debbugs.gnu.org; Tue, 08 Sep 2015 03:47:13 -0400 Original-Received: from detlef.gmx.de ([87.146.58.15]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MV1wf-1ZAIKW0T09-00YS0R; Tue, 08 Sep 2015 09:47:09 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:DLGYpA/t4ExNUcWyJMwAZcwUlddvLl64IFxNIYdyPeiI+83WimS 5OnwwfQOirPXOP6InQBQBM+LpKIkL5O77TrNph/kZs12a+sEW7pxKR94W1tVRfzJ07t28mW 1T0bbR+kEp7tFbsSnOnnksb3JEIuwviajfj9yyKoeqPZtYDXXQ54criXTRZxDVYvcPLdOAA iZ1h2VozJIqVvNrvzkkxQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:BmKK0y1MLlU=:RtXRQV7gn39c3UxcB+lHbG 0e41pIhEJ9mrqxf6+NfaH0j4a+Y6dp1Iegumuts4yS7oidW4xCMc2/qoRX/uvVt5JEWl3dpLn 7TwTMlCTiCNNUSW7RZsStQZCNpgR+ZtbpMk5dQrVZpyVesABL5heGJhxNox032hAnYOZzYjub IJ9OyPn4YE8dGdI3J11e3SQWKo90uJFh7pTonaTQuQdm6CKFelCOtE+Z3Qpdi0J0h1O8NseHJ AT3cHzMethWcVpG+S0qR23jjoter8S/705P/sY8MRruzD0ZBZx2oGmB5DSTtBGDGuoeQUvBW5 4CKshexmXAx9X2Zg29TbYMkSVpI3qRAQF8PttNTDUdL+eaEAzlDnzgsO3q/WcT+DJ2mz2EE1S qFfe+qTZYvQWYhRvMCcvr7nxtg6I48A+sMda3YZcsc/SFzJUpusivaE9W0dZeI5Qc5releX9K y2n9ZNSJRwskAFzvehb7+Y10tMvD3H9H1B1TDv1M+1isiRm069CS7kbPM6nSufuIckNHqzJKH T0bVO3TmGIEpIDvZ0XyUAfSbJqNNXcXds9sRWEt6gIa0wNsvUlMp5qCibwZ8xU32FPzdwi/E4 6JO1o+sY6PumBg9YdurfXWAAOXVwRJ4+t0whISq53fhzuRRYBIlrUouOQncpQSlglejEE2K+/ gLtDb9RdViCwTSytCRTx0h2gdiss7fkGI69iM7SVGGu1PBKgoEIRRrYo3VqVfI6U5skf3mbmE VUT65IBKRdxeMD0eY5dbMDxXlfQh0PqUUUscww== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106234 Archived-At: Tassilo Horn writes: Hi Tassilo, > I don't have a strong opinion about what the right behavior would be but > at least it seems inconsistent that you get the error only with deleted > directories. I guess the best solution was if `file-notify-rm-watch' > never signaled an error (then the docs can stay as they are), and there > would be some `file-notify-valid-p' predicate which would test if a > given descriptor still denotes a valid file or directory. I guess the > latter has probably some function equivalent in the respective backend > APIs, and even if not, it can be implemented by inspecting > `file-notify-descriptors'. `file-notify-rm-watch' is just a cleanup function, it's not worth to add some error handling. I will wrap the call of the native handlers by catching `file-notify-error'. Alternatively, `inotify-rm-watch' could be adapted not to raise an error in this case. `file-notify-valid-p' is a nice idea; I will see how I could add it. At least for the w32 case I would need some help from Eli, in order to see whether the native library supports such a check. Best regards, Michael.