bug#23662: 25.0.94; isearch-toggle-character-fold keybinding missing

bug#23662: 25.0.94; isearch-toggle-character-fold keybinding missing

[dan.dever]

According to the "Lax Search" Info page, isearch-toggle-character-fold
should be bound to `M-s '', but that does not appear to be the case.
The actual bindings I see, with `M-s C-h', are these:

    Global Bindings Starting With M-s:
    key             binding
    ---             -------

    M-s ESC		Prefix Command
    M-s .		isearch-forward-symbol-at-point
    M-s _		isearch-forward-symbol
    M-s h		Prefix Command
    M-s o		occur
    M-s w		isearch-forward-word

    M-s h .		highlight-symbol-at-point
    M-s h f		hi-lock-find-patterns
    M-s h l		highlight-lines-matching-regexp
    M-s h p		highlight-phrase
    M-s h r		highlight-regexp
    M-s h u		unhighlight-regexp
    M-s h w		hi-lock-write-interactive-patterns

    M-s M-w		eww-search-words

BTW, many thanks for the character-folding search feature.  I've wanted
that for a long time.




In GNU Emacs 25.0.94.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1)
 of 2016-05-20 built on ln-ddever
Windowing system distributor 'Scientific Linux', version 11.0.11300000
System Description:	Red Hat Enterprise Linux Client release 6 (Carbon Update 4)

Configured using:
 'configure --prefix=/ddever/emacs/emacs-25.0.94'

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND DBUS GCONF GSETTINGS NOTIFY ACL
LIBSELINUX GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11

Important settings:
  value of $LC_ALL: en_US
  locale-coding-system: iso-latin-1-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Type C-x 1 to delete the help window.

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message dired format-spec rfc822 mml
mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils
help-mode easymenu cl-loaddefs pcase cl-lib misearch multi-isearch
time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset
image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote dbusbind inotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 87757 5768)
 (symbols 48 19663 0)
 (miscs 40 47 139)
 (strings 32 14438 4999)
 (string-bytes 1 426796)
 (vectors 16 12417)
 (vector-slots 8 433874 3962)
 (floats 8 167 38)
 (intervals 56 298 240)
 (buffers 976 12)
 (heap 1024 34961 660))

bug#23662: 25.0.94; isearch-toggle-character-fold keybinding missing

[Dmitry Alexandrov]

dan.dever@cavium.com writes:

> According to the "Lax Search" Info page, isearch-toggle-character-fold
> should be bound to `M-s '', but that does not appear to be the case.

As for GNU Emacs 25.1.50.1, the function is called
‘isearch-toggle-char-fold’ (both in (info "(emacs) Lax Serach") and in
fact) and it is bound to ‘M-s '’ within isearch.  ‘Within’ means that
you have to invoke iserach first with ‘C-s’ or ‘C-M-s’ or somehow else.

> The actual bindings I see, with `M-s C-h', are these:
>
>     Global Bindings Starting With M-s:

However ‘M-s <f1>’ within incremetal search indeed returns help on
*global* bindings starting with M-s, not the bindings of iserach-mode,
so ‘M-s '’, ‘M-s e’ and others are missing in a help buffer.  I would
file this as a bug unless it is not filed already.

For what it’s worth, ‘which-key-mode’ acts correctly in this case.

bug#23662: 23662

[Dan Dever]

> As for GNU Emacs 25.1.50.1, the function is called
> ‘isearch-toggle-char-fold’ (both in (info "(emacs) Lax Serach") and in
> fact) and it is bound to ‘M-s '’ within isearch.  ‘Within’ means that
> you have to invoke iserach first with ‘C-s’ or ‘C-M-s’ or somehow else.

Thanks, good to hear.

> For what it’s worth, ‘which-key-mode’ acts correctly in this case.

Is which-key-mode also 25.1 change?  I'm not familiar with it and get "No apropos matches for 'which-key-mode'" when I try to discover it.

In any case, I had first attempted 'M-s '' within search before invoking 'M-s C-h'.  I agree that it makes sense that the later should return help on the bindings of isearch-mode when invoked from it.

bug#23662: 23662

[Dmitry Alexandrov]

Dan Dever <dan.dever@caviumnetworks.com> writes:

>> For what it’s worth, ‘which-key-mode’ acts correctly in this case.
>
> Is which-key-mode also 25.1 change?  I'm not familiar with it and get
> "No apropos matches for 'which-key-mode'" when I try to discover it.

‘which-key-mode’ is not a part of GNU Emacs, you have to istall it from
melpa or melpa-stable (‘M-x package-install RET which-key’) first if
you’d like to use it.  I would recommend you to try.

      (which-key-mode 1)

It might be also useful sometimes to get a help for non-prefixed
keybindings, so you might like to map a spare help key sequence
(‘C-h C-k’ / ‘<f1> C-k’ for example):

   (define-key 'help-command (kbd "C-k") #'which-key-show-top-level)

bug#23662: 23662

[Dan Dever]

The original issue appears to be fixed in 25.0.95.1

bug#23662: 23662

[Óscar Fuentes]

Dan Dever <dan.dever@caviumnetworks.com> writes:

> The original issue appears to be fixed in 25.0.95.1

Thanks for the update. Closing.