From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.bugs Subject: bug#23945: 25.1.50; Request for review: Gnus Cloud work in scratch/gnus-cloud Date: Wed, 13 Jul 2016 10:20:12 -0400 Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos Message-ID: <87wpkpwrfn.fsf@lifelogs.com> References: <87k2gs8bak.fsf@lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468419697 7390 80.91.229.3 (13 Jul 2016 14:21:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Jul 2016 14:21:37 +0000 (UTC) To: 23945@debbugs.gnu.org, Lars Magne Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 13 16:21:27 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bNL2R-0004Jn-Od for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Jul 2016 16:21:24 +0200 Original-Received: from localhost ([::1]:47969 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNL2Q-0000pV-SC for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Jul 2016 10:21:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNL2B-0000k6-Nh for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2016 10:21:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNL26-0000cg-ID for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2016 10:21:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37579) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNL26-0000cb-E5 for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2016 10:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bNL26-0002rH-8h for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2016 10:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ted Zlatanov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jul 2016 14:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23945 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23945-submit@debbugs.gnu.org id=B23945.146841963410927 (code B ref 23945); Wed, 13 Jul 2016 14:21:02 +0000 Original-Received: (at 23945) by debbugs.gnu.org; 13 Jul 2016 14:20:34 +0000 Original-Received: from localhost ([127.0.0.1]:49915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNL1Z-0002q7-Q4 for submit@debbugs.gnu.org; Wed, 13 Jul 2016 10:20:34 -0400 Original-Received: from mail-pf0-f172.google.com ([209.85.192.172]:36369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNL1U-0002pq-ED for 23945@debbugs.gnu.org; Wed, 13 Jul 2016 10:20:28 -0400 Original-Received: by mail-pf0-f172.google.com with SMTP id t190so19194384pfb.3 for <23945@debbugs.gnu.org>; Wed, 13 Jul 2016 07:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=zT0xtenanwI5lujmvDuGlKAytZNooDc25w7ldKUbbLo=; b=fRfucoc2Hji/Qs0Yd+uIMK9Fnp4aXSZ56CZgla8kOA9IgiY14nHcOEHDEKRRdDEpCJ Fs9rP61iiM76GBlMNJHduhM+T7akfK9YXvp5iwI3FE04zmubNNtanAqgrzy1Q9gzGoKS F6HJBatI3ItXfdIJEpXJYi0HDUzCLcxNHtBQA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version; bh=zT0xtenanwI5lujmvDuGlKAytZNooDc25w7ldKUbbLo=; b=IOQz1oDjkc8tvoJVcGP3emdeaSw3ZF1uEPu+BVhevN0qBjobaVcwy/cwOskl349390 +cLP+29XD3z0CktAeuZLjVj1SUIVpuzOyQffbGUPc8r2/rq6yEFbP7ZeOQJEuSZZtMjH oUv+ugkcE9JllcdWGeRWSDNSfC+iegBzKtjgBQjQKYhetHQ4cXEOcGCM3Ly2YAovX14P qfuegJnp7CD4FxkHMJphDYuCsBt8MLPUyhDEyT2b7A/R2oSCXFu03CMS1zdNGfi3g0fF J5fc6TwOEF2It8urPKnD8PjmfV47s+mCcjMnH2WwvKKx8XGdwk4Hb1WM803AVlzNxLZj GDCg== X-Gm-Message-State: ALyK8tL+WzavBr1boFcZuTiQ1Yf6kxX94KLtWE9rl1/c7ibTYici+Ajq///GBJFOPNbkUw== X-Received: by 10.98.37.71 with SMTP id l68mr3962858pfl.38.1468419618425; Wed, 13 Jul 2016 07:20:18 -0700 (PDT) Original-Received: from flea (c-98-229-60-157.hsd1.ma.comcast.net. [98.229.60.157]) by smtp.gmail.com with ESMTPSA id sk4sm5643027pac.16.2016.07.13.07.20.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Jul 2016 07:20:17 -0700 (PDT) X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <87k2gs8bak.fsf@lifelogs.com> (Teodor Zlatanov's message of "Mon, 11 Jul 2016 11:05:55 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120991 Archived-At: On Mon, 11 Jul 2016 11:05:55 -0400 Teodor Zlatanov wrote: TZ> I've published the proposed changes to the Gnus Cloud code in the branch TZ> `scratch/gnus-cloud' and would like to request a code review. It's a TZ> single commit which I've tested over the last 2 weeks with the help of TZ> other Gnus users. TZ> I'll add documentation if the code is acceptable. Lars? You look like a good reviewer. There is one piece I remembered was missing: making the cloud host persistent. After restarting Gnus, you have to set the gnus-cloud-method with `gnus-server-toggle-cloud-method-server' again. How would you suggest to save that, with a defcustom in gnus-cloud or in the individual server's parameters? Right now it's just (defvar gnus-cloud-method nil "The IMAP select method used to store the cloud data.") If I save it in the individual server's parameters there's a possibility that two servers will have the cloud host flag accidentally. Ted