From: handa <handa@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: ynyaaa@gmail.com, 23814@debbugs.gnu.org
Subject: bug#23814: 24.5; bug of hz coding-system
Date: Wed, 13 Jul 2016 23:12:47 +0900 [thread overview]
Message-ID: <87wpkphbj4.fsf@gnu.org> (raw)
In-Reply-To: <83d1mngirw.fsf@gnu.org> (message from Eli Zaretskii on Sat, 09 Jul 2016 14:20:19 +0300)
In article <83d1mngirw.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:
> Ping! Could you please comment on this issue?
Sorry, I've overlooked that mail.
> > > >> `encode-hz-region' uses `iso-2022-7bit' coding-system internally,
> > > >> replacing it with the coding-system below will work.
> > > >>
> > > >> (define-coding-system 'iso-2022-cn-gb
> > > >> "ISO 2022 based 7bit encoding only for Chinese GB2312."
> > > >> :coding-type 'iso-2022
> > > >> :mnemonic ?C
> > > >> :charset-list '(ascii chinese-gb2312)
> > > >> :designation [(ascii chinese-gb2312) nil nil nil]
> > > >> :flags '(ascii-at-eol ascii-at-cntl designation 7-bit safe)
> > > >> )
Right. But, as there are already so many iso-2022 based coding systems,
I'd like to avoid adding a new one just for encode-hz-region. I think
the attached patch is sufficent. Could you please try it? It also
fixes the problem of incorrect decoding of "~{7~~}".
---
K. Handa
handa@gnu.org
diff --git a/lisp/language/china-util.el b/lisp/language/china-util.el
index e531640..9735bd6 100644
--- a/lisp/language/china-util.el
+++ b/lisp/language/china-util.el
@@ -95,7 +95,9 @@ decode-hz-region
(goto-char (point-min))
(while (search-forward "~" nil t)
(setq ch (following-char))
- (if (or (= ch ?\n) (= ch ?~)) (delete-char -1)))
+ (if (= ch ?{)
+ (search-forward "~}" nil 'move)
+ (if (or (= ch ?\n) (= ch ?~)) (delete-char -1))))
;; "^zW...\n" -> Chinese GB2312
;; "~{...~}" -> Chinese GB2312
@@ -141,7 +143,7 @@ encode-hz-region
(save-excursion
(save-restriction
(narrow-to-region beg end)
-
+ (put-text-property beg end 'charset 'chinese-gb2312)
;; "~" -> "~~"
(goto-char (point-min))
(while (search-forward "~" nil t) (insert ?~))
next prev parent reply other threads:[~2016-07-13 14:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 12:22 bug#23814: 24.5; bug of hz coding-system ynyaaa
2016-06-21 12:58 ` Eli Zaretskii
2016-06-22 13:47 ` ynyaaa
2016-06-22 15:28 ` Eli Zaretskii
2016-06-22 17:04 ` ynyaaa
2016-06-22 17:26 ` Eli Zaretskii
2016-07-09 11:20 ` Eli Zaretskii
2016-07-13 14:12 ` handa [this message]
2016-07-23 17:47 ` Eli Zaretskii
2016-07-24 8:21 ` ynyaaa
2016-07-26 15:09 ` handa
2016-07-29 1:05 ` ynyaaa
2016-08-14 11:22 ` handa
2016-08-17 6:33 ` ynyaaa
2016-08-17 14:43 ` handa
2016-08-17 15:28 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpkphbj4.fsf@gnu.org \
--to=handa@gnu.org \
--cc=23814@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=ynyaaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).