From: npostavs@users.sourceforge.net
To: Dmitry Lazurkin <dilaz03@gmail.com>
Cc: 24820@debbugs.gnu.org
Subject: bug#24820: Any suggestions about patch?
Date: Mon, 26 Dec 2016 17:26:28 -0500 [thread overview]
Message-ID: <87wpem8gyz.fsf@users.sourceforge.net> (raw)
In-Reply-To: <9f6f8035-4fad-093c-1ff4-aa48d6c580c3@gmail.com> (Dmitry Lazurkin's message of "Fri, 23 Dec 2016 20:32:52 +0300")
Dmitry Lazurkin <dilaz03@gmail.com> writes:
> I have not quick navigation to async method without this patch. What i
> should do for merging this patch?
The patch looks good to me, except a minor formatting mistake in the
commit message.
* test/automated/python-tests.el (python-imenu-create-index-1,
python-imenu-create-flat-index-1): Add async def's.
should be
* test/automated/python-tests.el (python-imenu-create-index-1):
(python-imenu-create-flat-index-1): Add async def's.
Have you done copyright assignment for Emacs?
I think your current patch is a bit over the limit of what we can accept
without an assignment (unless we don't count lines added to tests?).
Though if you didn't refactor into the new function
python-imenu--get-defun-type-name it could probably squeeze in.
The form to start the assignment process is at
http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.program
next prev parent reply other threads:[~2016-12-26 22:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 14:34 bug#24820: Imenu in `python-mode' does not display function name for async def Dmitry Lazurkin
2016-12-23 17:32 ` bug#24820: Any suggestions about patch? Dmitry Lazurkin
2016-12-26 22:26 ` npostavs [this message]
2017-01-04 16:48 ` bug#24820: I think copyright is assigned Dmitry Lazurkin
2017-01-04 16:55 ` Eli Zaretskii
2017-01-04 20:24 ` bug#24820: Rebase against master Dmitry Lazurkin
2017-01-04 20:27 ` Dmitry Lazurkin
2017-01-05 4:07 ` bug#24820: Imenu in `python-mode' does not display function name for async def npostavs
2017-01-05 10:14 ` Dmitry Lazurkin
2017-01-06 1:19 ` npostavs
2017-01-06 12:07 ` Dmitry Lazurkin
2017-01-06 14:00 ` npostavs
2017-01-06 19:41 ` Dmitry Lazurkin
2017-01-13 1:49 ` npostavs
2017-01-13 9:34 ` dilaz03 .
2017-01-05 20:20 ` Dmitry Lazurkin
2017-01-05 21:03 ` Dmitry Lazurkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpem8gyz.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=24820@debbugs.gnu.org \
--cc=dilaz03@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).