unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Antoine Levitt <antoine.levitt@gmail.com>
Cc: 25751@debbugs.gnu.org
Subject: bug#25751: Query replace lazy highlighting
Date: Thu, 16 Feb 2017 23:01:28 +0200	[thread overview]
Message-ID: <87wpcpx32v.fsf@localhost> (raw)
In-Reply-To: <87mvdmxoig.fsf@lambda> (Antoine Levitt's message of "Thu, 16 Feb 2017 14:18:31 +0100")

> When query-replacing and confirming, matches get unhighlighted, and then
> highlighted again, which is very distracting. E.g. open a file, M-% a ->
> a, y, other matches of a get unhighlighted then highlighted again.
>
> (setq lazy-highlight-initial-delay 0) (shouldn't it be default by the
> way, at least on graphical displays?) reduces the problem but does not
> eliminate it (it produces small flickers). There's
> lazy-highlight-cleanup, but that disables cleanup completely, which I
> don't want.
>
> Can't this be eliminated?

The reason why it works this way is because lazy-highlight is not yet
optimized to handle changes: it needs to dehighlight the replaced text,
and to add highlighting in the new replacing text after every replacement.
I see no simpler solution than to write a new function with a name like
‘isearch-lazy-highlight-update-in-region’ that given the region boundaries
of the last replacement will rehighlight matches in that region.





  reply	other threads:[~2017-02-16 21:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16 13:18 bug#25751: Query replace lazy highlighting Antoine Levitt
2017-02-16 21:01 ` Juri Linkov [this message]
2017-02-16 22:45   ` Juri Linkov
2017-02-17  6:37   ` Eli Zaretskii
2017-02-17 22:52     ` Juri Linkov
2017-02-18  8:13       ` Eli Zaretskii
2017-02-18 23:17         ` Juri Linkov
2017-02-18 23:51           ` Drew Adams
2017-02-20  0:30             ` Juri Linkov
2017-02-21 23:22           ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpcpx32v.fsf@localhost \
    --to=juri@linkov.net \
    --cc=25751@debbugs.gnu.org \
    --cc=antoine.levitt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).