From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#27272: 25.2; [patch] Fix positional args among keyword args in eldoc. Date: Wed, 14 Jun 2017 20:05:56 -0400 Message-ID: <87wp8eru6z.fsf@users.sourceforge.net> References: <87poegnnyn.fsf@gmail.com> <87tw3ng6ov.fsf@gnu.org> <878tkzc5fm.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1497485113 17310 195.159.176.226 (15 Jun 2017 00:05:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Jun 2017 00:05:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 27272@debbugs.gnu.org, Johan =?UTF-8?Q?Bockg=C3=A5rd?= To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 15 02:05:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLIHc-00042n-Kd for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Jun 2017 02:05:08 +0200 Original-Received: from localhost ([::1]:51307 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLIHf-0005Bw-F3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Jun 2017 20:05:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLIHa-0005Bi-14 for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2017 20:05:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dLIHW-00057y-1x for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2017 20:05:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45466) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dLIHV-00057t-V7 for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2017 20:05:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dLIHV-0002ow-K7 for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2017 20:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Jun 2017 00:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27272 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27272-submit@debbugs.gnu.org id=B27272.149748506610792 (code B ref 27272); Thu, 15 Jun 2017 00:05:01 +0000 Original-Received: (at 27272) by debbugs.gnu.org; 15 Jun 2017 00:04:26 +0000 Original-Received: from localhost ([127.0.0.1]:48143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLIGw-0002nz-Gi for submit@debbugs.gnu.org; Wed, 14 Jun 2017 20:04:26 -0400 Original-Received: from mail-io0-f194.google.com ([209.85.223.194]:32855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLIGv-0002nm-7c for 27272@debbugs.gnu.org; Wed, 14 Jun 2017 20:04:25 -0400 Original-Received: by mail-io0-f194.google.com with SMTP id j200so322472ioe.0 for <27272@debbugs.gnu.org>; Wed, 14 Jun 2017 17:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=GtMC3d/PkfrwI4/kdCtJT6XKIgXXqFk26zADLccFh7M=; b=ZGvjQylS7i8ePZ3CKrNAGLhM+WCrI00PStyjl5MROdWMEl6+X4WXe3jDEJcBDs7xhA O/AFp3YLTNHIlh4XEr73+b6QTgjT2czfrz67L3BnV76zv6KIyoeDhDQlB6N1/XYQQXW2 riYDPm44encbN/RHke/XTDGS9EK33+glMQXE305z5QSjKg2eNSvt/dpdu8IayXkYyTI4 ma8k1nFWZ/4PMJgBizwyrh3DYza0MiFy3bpWFQrEQmCmE4JEuFewT2Kro0vmEf0rJc5D oosfCoSEMWzfSbEYUijmPgCXMSAuK1hoFK2NG9MaN3du64IRIgl0AZA5IDgRNjvt5gMf S6LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=GtMC3d/PkfrwI4/kdCtJT6XKIgXXqFk26zADLccFh7M=; b=nfO4+U5SXXpI/trqi9X9dPYFjV7NnuTSBkq+wPuKGSaSABcx5RAbJS9aQfyNTRPV/B 6md5kOiDMIYLJqD0qMT78/a0E+H6Wypq2iZPM8aBYIjuMYqHHP2B8hRLaXdtiW9ztSJP b1UJRt6s49slow8cfjh4FzxHLTyEFYkkAafWdJkhfXC0V70OxAjJ/+vZrZihqnLLlewG m4mr5MqMTguQxPjxrFfqe3jtSIj1idzSzbpZthS+VxPlEA9M3g2XW3W6Mw/2f6j+CCld svlVeq69BAg+1R+Dv6CWkN8Hokr3+4YMZba0Kl9yNFUMelS1aYamABmVdV66Drr/oDzs mYKg== X-Gm-Message-State: AKS2vOxZ5Xw4wA+oFo4dA6mqC+oF9tUU0F13r0iYsL8Rvvwccn4QzJUz TBxZePq7DqaOaDVr X-Received: by 10.107.11.77 with SMTP id v74mr2802966ioi.39.1497485059664; Wed, 14 Jun 2017 17:04:19 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 97sm741181iot.25.2017.06.14.17.04.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Jun 2017 17:04:18 -0700 (PDT) In-Reply-To: <878tkzc5fm.fsf@gmail.com> (Thierry Volpiatto's message of "Sun, 11 Jun 2017 10:08:29 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133596 Archived-At: Thierry Volpiatto writes: > Johan Bockg=C3=A5rd writes: > >> Thierry Volpiatto writes: >> >>> Fix eldoc with positional arg among keyword args. >>> >>> * lisp/progmodes/elisp-mode.el (elisp--highlight-function-argument): >>> Switch to indexed arg searching when no keyword found behind arg. >> >> This code is wrong both with and without your fix. All mandatory and >> optional arguments should be used *before* keywords are matched. >> >> Given this definition of `foo', >> >> (cl-defun foo (x &key a b c) >> (list x a b c)) >> >> `:b' in the following call specifies the positional argument `x', not >> the keyword argument `b': >> >> (foo :b :a 1) =3D> (:b 1 nil nil) > > Fixed as well. Do you mean you have an updated patch that fixes this as well (which you seem to have forgotten to post)?