From: npostavs@users.sourceforge.net
To: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Cc: 27272@debbugs.gnu.org, "Johan Bockgård" <bojohan@gnu.org>
Subject: bug#27272: 25.2; [patch] Fix positional args among keyword args in eldoc.
Date: Wed, 14 Jun 2017 20:05:56 -0400 [thread overview]
Message-ID: <87wp8eru6z.fsf@users.sourceforge.net> (raw)
In-Reply-To: <878tkzc5fm.fsf@gmail.com> (Thierry Volpiatto's message of "Sun, 11 Jun 2017 10:08:29 +0200")
Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:
> Johan Bockgård <bojohan@gnu.org> writes:
>
>> Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:
>>
>>> Fix eldoc with positional arg among keyword args.
>>>
>>> * lisp/progmodes/elisp-mode.el (elisp--highlight-function-argument):
>>> Switch to indexed arg searching when no keyword found behind arg.
>>
>> This code is wrong both with and without your fix. All mandatory and
>> optional arguments should be used *before* keywords are matched.
>>
>> Given this definition of `foo',
>>
>> (cl-defun foo (x &key a b c)
>> (list x a b c))
>>
>> `:b' in the following call specifies the positional argument `x', not
>> the keyword argument `b':
>>
>> (foo :b :a 1) => (:b 1 nil nil)
>
> Fixed as well.
Do you mean you have an updated patch that fixes this as well (which you
seem to have forgotten to post)?
next prev parent reply other threads:[~2017-06-15 0:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 9:31 bug#27272: 25.2; [patch] Fix positional args among keyword args in eldoc Thierry Volpiatto
2017-06-07 15:33 ` Eli Zaretskii
2017-06-07 16:02 ` Thierry Volpiatto
2017-06-07 17:00 ` Eli Zaretskii
[not found] ` <87shjbegwy.fsf@gmail.com>
[not found] ` <83fufb8avt.fsf@gnu.org>
2017-06-08 8:17 ` Thierry Volpiatto
2017-06-08 15:04 ` Eli Zaretskii
2017-06-07 16:15 ` Dmitry Gutov
2017-06-10 16:15 ` Johan Bockgård
2017-06-11 8:08 ` Thierry Volpiatto
2017-06-15 0:05 ` npostavs [this message]
2017-06-15 3:26 ` Thierry Volpiatto
2017-06-30 4:01 ` npostavs
2017-06-30 6:36 ` Thierry Volpiatto
2017-07-01 21:00 ` Noam Postavsky
2017-07-20 2:22 ` npostavs
2017-08-05 1:35 ` npostavs
2017-08-16 1:30 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp8eru6z.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=27272@debbugs.gnu.org \
--cc=bojohan@gnu.org \
--cc=thierry.volpiatto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).