From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#27341: updated patch to fix docstring Date: Sun, 02 Jul 2017 15:13:29 -0400 Message-ID: <87wp7qk5ye.fsf@users.sourceforge.net> References: <8760g1xxhw.fsf@utexas.edu> <8737b4grzq.fsf@utexas.edu> <8737aop2d9.fsf@users.sourceforge.net> <87lgoedf1t.fsf@utexas.edu> <87efu6nwa2.fsf@users.sourceforge.net> <878tkdy37e.fsf@utexas.edu> <87zicmk7u5.fsf@users.sourceforge.net> <87tw2u7k4i.fsf@utexas.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1499022806 16627 195.159.176.226 (2 Jul 2017 19:13:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 2 Jul 2017 19:13:26 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 27341@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 02 21:13:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRkIs-0003Kt-Re for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Jul 2017 21:13:07 +0200 Original-Received: from localhost ([::1]:58974 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRkIw-00032M-Qc for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Jul 2017 15:13:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRkIr-00032G-Fj for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 15:13:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRkIo-0003Pe-53 for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 15:13:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46333) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dRkIo-0003PP-1J for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 15:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dRkIn-0002Ox-PU for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 15:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jul 2017 19:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27341-submit@debbugs.gnu.org id=B27341.14990227229162 (code B ref 27341); Sun, 02 Jul 2017 19:13:01 +0000 Original-Received: (at 27341) by debbugs.gnu.org; 2 Jul 2017 19:12:02 +0000 Original-Received: from localhost ([127.0.0.1]:49009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRkHq-0002Nh-GI for submit@debbugs.gnu.org; Sun, 02 Jul 2017 15:12:02 -0400 Original-Received: from mail-io0-f174.google.com ([209.85.223.174]:35575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRkHo-0002NE-RJ for 27341@debbugs.gnu.org; Sun, 02 Jul 2017 15:12:01 -0400 Original-Received: by mail-io0-f174.google.com with SMTP id h134so45396993iof.2 for <27341@debbugs.gnu.org>; Sun, 02 Jul 2017 12:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=3Sln+LkaV3QPL8QIw5Lvo6UOwBXuucKVbkJfRYcOR/0=; b=Jm7xoaFVceLCFL9Jp7Xb3qkLob9SRLxHOSmtXRHD1DmWeswGE7C6zNRdAkRdKYzmbA 4reafJ0vPnmRyyx1ZIEJ87YVKg+KUk1OZHFPuHmLHWs7CrLl8qErY8LWiZ3xiM7scN7r hCkGNkeR1X9DTmhtgkAf4NfadVKA70K7BcMW+dMT9Ep7j5T0266LtoxmLPZUsUNBVC1Y GjG7DmjZ0xrcEyt1xKYy0/rKuowi8KGtnP/uxMjwXcg02c8/7LNGqyqb5hFEegtQ40Gg gL+XODSyVQhcA7G4ZwKiO4P8WJxDXP3knG8SKlLs4OvPeOt7+dmWOimhwi/TeTrMVT32 hm0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=3Sln+LkaV3QPL8QIw5Lvo6UOwBXuucKVbkJfRYcOR/0=; b=FwqYCrECgs1phgGN6jta4iq/QwZZH7B8e7AhatGbIc4z2qEOAW8bRhjLueDbX6ZggX SeMbEe9VN5epTyyKvbqy8Yh346YU/+PNbNz+WYgz4+GduW3TOpJ7pUsPhgbwRJClXtTT 0nHFHC+etKk8nBTyyvm5x6zPe7IM3df/vBD9CnICYWFem7qWN9m5eTif2hlGXctinlaM wenD75OuUL1Q20xFdX9gmHg4SA8tWHTDxKbCo2EVHLaGJC8LmnxI9vy1b484Zj5tVYgQ q0vCtzUkpuR7i/rjUmpJHkRUWlM2r084m3wvNxBLD49iemgRvndjkP8MEdyIL/nNo2xv i7MQ== X-Gm-Message-State: AKS2vOw2uSEBbioKy2iamDNI+rxaEdRGOQNYVBTV+cXnsaOcMNaV8xwd l4vCYdvq7OuFlvcl X-Received: by 10.107.137.152 with SMTP id t24mr32875247ioi.218.1499022715022; Sun, 02 Jul 2017 12:11:55 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id s135sm9110376ita.2.2017.07.02.12.11.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 02 Jul 2017 12:11:54 -0700 (PDT) In-Reply-To: <87tw2u7k4i.fsf@utexas.edu> (Alex Branham's message of "Sun, 02 Jul 2017 20:45:49 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134101 Archived-At: Alex Branham writes: >> You missed the double spacing before the "Else,". > > D'oh! Fixed this time, sorry! Oh, the funny indentation came back, do you have some Emacs setting that's doing that? >>> Actually, we need to check (use-region-p) anyway in case the mark >>> hasn't been activated yet in the buffer: >> >> Hmm, I just tried this and it doesn't quite do the job. I believe the >> problem is that the (interactive "r") form throws an error when the mark >> hasn't been activated yet. To handle this case correctly you need to >> replace the "r" with some lisp code that produces the argument list. > > Ok, now I don't use "r" and just get the region directly. I think that'll= do the trick? Oh yeah, that works. We should try not to add compiler warnings though: ELC net/eww.elc In toplevel form: ../../emacs-master/lisp/net/eww.el:315:1:Warning: Unused lexical argument =E2=80=98end=E2=80=99 ../../emacs-master/lisp/net/eww.el:315:1:Warning: Unused lexical argument =E2=80=98beg=E2=80=99 I think we can just drop the arguments as well, lisp programs can always do (eww (buffer-substring BEG END)) instead. Do you think the prompt string should be a bit more detailed? "Query" seems a bit vague (e.g., consider if you hit M-s M-w by accident). Maybe we should just do (call-interactively 'eww) and then we'll get the prompt from there.