From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#27559: 26.0.50; [PATCH] Add tests for cl-macs.el Date: Tue, 04 Jul 2017 14:04:14 +0900 Message-ID: <87wp7oaj3l.fsf@calancha-pc> References: <87zicmxdyl.fsf@lylat> <87o9t1c0vm.fsf@calancha-pc> <874luti81g.fsf@lylat> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1499144720 11808 195.159.176.226 (4 Jul 2017 05:05:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Jul 2017 05:05:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 27559@debbugs.gnu.org, tino.calancha@gmail.com To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 04 07:05:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSG1S-0002WQ-1U for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Jul 2017 07:05:14 +0200 Original-Received: from localhost ([::1]:38637 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSG1S-0000LV-L0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Jul 2017 01:05:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSG1K-0000K2-KL for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 01:05:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSG1G-0001FT-OT for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 01:05:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48399) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSG1G-0001FN-Jn for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 01:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dSG1G-0005sD-58 for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 01:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jul 2017 05:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27559-submit@debbugs.gnu.org id=B27559.149914467622538 (code B ref 27559); Tue, 04 Jul 2017 05:05:02 +0000 Original-Received: (at 27559) by debbugs.gnu.org; 4 Jul 2017 05:04:36 +0000 Original-Received: from localhost ([127.0.0.1]:51076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSG0p-0005rQ-B5 for submit@debbugs.gnu.org; Tue, 04 Jul 2017 01:04:35 -0400 Original-Received: from mail-pf0-f170.google.com ([209.85.192.170]:36373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSG0l-0005r9-BG for 27559@debbugs.gnu.org; Tue, 04 Jul 2017 01:04:31 -0400 Original-Received: by mail-pf0-f170.google.com with SMTP id q86so109460316pfl.3 for <27559@debbugs.gnu.org>; Mon, 03 Jul 2017 22:04:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=EYukviGdttqeqaWV8Wn9tvY6DAttwRsCN4MSCvLOmvU=; b=ol5VpeeAxB0ZXa/PHBV/Jc2gwNSdFAMYHSS87zasjgW34OMkJB9yUVEJLLNnecVJai ocTGOIfvl5NWR4YBSsxvT602cIK/B+Qm6XnSvpsxYkIN2pto5G/ItcN/k6g9tukVW4DH Cp88MipIIi2my3DdSl2d6nfqznxIHqLCO6UHfDBlvrvBAcoWNQa77hSiQdQsQWxdkEUv VrHEmzFHczuQZGBfZpIiUI8LcsvHDm4uzndN7SLx+Tgl0DlumuBpN48mUC3P03nGgRFV 4Gi288seM1ikV2SsLQBrjIcnWAvrk0mB+rtES34KSQ4jihS3Adh0wk9sYdLSSH86ACFe PHZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=EYukviGdttqeqaWV8Wn9tvY6DAttwRsCN4MSCvLOmvU=; b=OYumdeoaL9kS++R9lAKlRreSMvFsr9hgrFcvH4PMx8zxGt5kWHnn3JEdfemoSnhr4X gOtZAklqNJiZvjf44FHgpJ/dHWMYIjru3g/tLbSTiZfTjudrd3TIlj73v0XM+pBsls9n 6b6aFSXAnIHZbxad0tvUrVhkqaxljLZ4dap8Euo2EbkpP89Gma7ust8QJw+o7hbiNTKi twqehZFgUe9sXhgAupE1DXbTzOl2rRDwjv7HEfL+ORjwK+QUUgDvKs4rhX8E2njtUiis P7hwatjqEHwzlm0rFfs6gpRkFj2V1LSFaqYdZi0YRvERvKJe4zvqVf+Gsm1/DdjBEB2s 6CXQ== X-Gm-Message-State: AIVw110mTcfmWO2d8QDMRordNg/c8j3NhIX5CThmI/IIYZJKbkjAD9Dj RxU0vFqVhrBAsw== X-Received: by 10.84.225.145 with SMTP id u17mr14309247plj.255.1499144665413; Mon, 03 Jul 2017 22:04:25 -0700 (PDT) Original-Received: from calancha-pc (222.139.137.133.dy.bbexcite.jp. [133.137.139.222]) by smtp.gmail.com with ESMTPSA id j27sm35289122pgn.63.2017.07.03.22.04.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Jul 2017 22:04:24 -0700 (PDT) In-Reply-To: <874luti81g.fsf@lylat> (Alex's message of "Mon, 03 Jul 2017 14:23:39 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134159 Archived-At: Alex writes: > That's more or less what I did at first, but I figured since cl-loop is > a large macro, that it's best to quote the macro so that an accidental > error doesn't halt testing. I prefer just use (eval '...) in those cases where the expansion fails. That way the file is more readable, and a reader focus her eye in those failing expansions. Maybe we could add a comment in the file saying that those `should-error' are failing expansions to be fixed. > For instance, some for-as-arith tests that aren't marked as should-error > currently error in master. As an example, (cl-loop for i above 0 by 2 > downfrom 10 collect i) should work, but it errors. I have a working > patch for these, but I wanted to make the tests first. That's great! Looking forward to see the patch fixing these problems. > It would be nice if the ert tests in general could just continue on with > testing even if there are macro-expansion errors. Sure, as long as the errors are expected.