From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#27243: closed (Re: bug#27243: dired-auto-revert-buffer jumps point to beginning of buffer) Date: Sat, 15 Jul 2017 13:14:06 +0200 Message-ID: <87wp7arlz5.fsf@rosalinde> References: <83d1ac6yih.fsf@gnu.org> <87shjf48se.fsf@epsilon> <87r2yizu66.fsf@beta> <87bmpm20zt.fsf@rosalinde> <5969C609.4040803@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1500117316 16294 195.159.176.226 (15 Jul 2017 11:15:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 15 Jul 2017 11:15:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 27243@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 15 13:15:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWL2W-00043D-A1 for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Jul 2017 13:15:12 +0200 Original-Received: from localhost ([::1]:41582 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWL2b-0001Cd-Kc for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Jul 2017 07:15:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWL2R-0001AA-8e for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2017 07:15:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWL2M-0000Nu-Ax for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2017 07:15:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36895) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dWL2M-0000No-7E for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2017 07:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dWL2L-0005r6-V3 for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2017 07:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2017 11:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27243 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27243-submit@debbugs.gnu.org id=B27243.150011725822444 (code B ref 27243); Sat, 15 Jul 2017 11:15:01 +0000 Original-Received: (at 27243) by debbugs.gnu.org; 15 Jul 2017 11:14:18 +0000 Original-Received: from localhost ([127.0.0.1]:39572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWL1e-0005pu-E7 for submit@debbugs.gnu.org; Sat, 15 Jul 2017 07:14:18 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:53207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWL1c-0005pf-D7 for 27243@debbugs.gnu.org; Sat, 15 Jul 2017 07:14:17 -0400 Original-Received: from rosalinde ([83.135.8.203]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MRocn-1d3LvF2Xaz-00SzMB; Sat, 15 Jul 2017 13:14:08 +0200 In-Reply-To: <5969C609.4040803@gmx.at> (martin rudalics's message of "Sat, 15 Jul 2017 09:36:41 +0200") X-Provags-ID: V03:K0:cfbFtdXs7ORtzmv5zRzQylNpZkhCjtNGIDLWS9UFK5tgTjxeOTD z6DqbEFVnWYGwCRpnS6MpFqCu6ariJsAKhdNQ4STfJixq42JBcg2UaLM20yb2gg5ogmE86w 9my0OFEjrWiNpsOnLvAkRSVBmY+UsNb4SXT7eewK8oSnmOV9BsNkIQTOb8e0w0idD3Un2MX C3Cy7Ivu7LlgLq/7Z8e/w== X-UI-Out-Filterresults: notjunk:1;V01:K0:IfwoxbK/KXM=:lYNg3AVdpHMtlICuIsTp/E 2RJIORUHHvXafgDnS6jBW+FUF/GESjUVWDAPkGm8jW8tLZ/k3xkFq7GOvU5rdCEgGavCBUI9+ 5TIg52Ltk5xgj1Ltea4Es6E6bEySaRPheRM+h9y9GNw96IUOm4sdp7+dJgD7D5S4+Lu4hVZ5n o37IItAxDIPAk4yraRK0p2SPlFWDKUGz52ZEUtI7YwaujXfXnuz2+cTGKyndyTeSRHWMBEDyA pFe50s5X+gcsAX0cJ2eqhLnSUlvW3mY7f/5tI2Abzu5SQ+kaLoT9gS9bX1vX1q/EajDlV9rN+ 26S/j0nGGfPVLTG4/duCFIpdnW4eYQ0iAUuhP4/1kEMTNRbYrUj2Vaig1ya/m3p4UxgvHjLmX HVuk7DgFTn95jbZLnS97yyE0FTzYULWT0Hmv0hR6OG6pn8TCGFJz6MT3ThAzBx5Wrl8wkI0tZ eY/IPxx03fLAN2EV5Ugr+UnBOjeI0wrJup6w3iOqWfIZ7UuIUhtRv77f/2K2n9W7kB8Cjvmah ww9GgUJMNVqSB25BlXpFzbAsuXEFW7pWpShHRcV1OYXo+/GOwZeMkI2SIHYSuuE3X56p28mm5 uu2psGb0dH/33aC/ziGEZni/OjuP/zDR+CDc9j7ubNmgcfDFubt8bTOn/oBceralmd1EpwSRF Dc1XYTo8QaeD+MufpczzGU5201dyjByBziDa2+WXzx3RZwQBtpk0sG+5tl3Bi7fybHkN7+lsH t0BDEQ4uBM9dO0QquZagqCR/TifRF/ctO30Qi/CjNLtwfr+qGvB7bOU9LHG8Uoamx5aWGnaz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134583 Archived-At: On Fri, 14 Jul 2017 22:52:18 -0700 John Wiegley wrote: >>>>>> Stephen Berman writes: > >> Thanks for confirming. I think this is the right fix and would commit it, >> but since this exchange has taken place in a closed bug, it may have fallen >> under the radar, so I'd like an explicit go-ahead. Eli, John? > > At first glance it looks OK to me, though I defer to Eli's experience in such > matters. On Sat, 15 Jul 2017 10:18:06 +0300 Eli Zaretskii wrote: > No objections here. > > Thanks. Thanks for okaying, but... On Sat, 15 Jul 2017 09:36:41 +0200 martin rudalics wrote: >> + (set-window-buffer (selected-window) >> + (set-buffer (dired-noselect dirname switches)))) > > This really should be > > (pop-to-buffer-same-window (dired-noselect dirname switches)) > > Even if people disliked it in the past and some still dislike it: Try > > C-h f > M-x dired Wow, that's disastrous! And frightening: I use the "(set-window-buffer (selected-window) (set-buffer ...))" idiom a lot in todo-mode.el; I just checked two commands using `C-h f' followed by the command invocation: one worked fine but the other caused the same disaster. So now I have to check all uses :(. Is there a general guideline for when to use set-window-buffer and when to use pop-to-buffer-same-window? Anyway, I'll commit the dired.el change you recommend; many thanks. Steve Berman