From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#28864: 25.3.50; next-error-no-select does select Date: Sat, 28 Oct 2017 23:54:03 +0300 Organization: LINKOV.NET Message-ID: <87wp3fxac4.fsf@localhost> References: <87bml72qck.fsf@gmail.com> <4045abe7-1acb-314b-b9ac-72b62db30570@yandex.ru> <87sheh270d.fsf@gmail.com> <6f3b7c2c-31af-8eb2-8f13-a9ba17d3d8e6@yandex.ru> <87mv4m5lok.fsf@gmail.com> <87d15h5f97.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1509225799 8090 195.159.176.226 (28 Oct 2017 21:23:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Oct 2017 21:23:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (x86_64-pc-linux-gnu) Cc: 28864@debbugs.gnu.org, Noam Postavsky , Dmitry Gutov To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 28 23:23:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8YZQ-000123-Px for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Oct 2017 23:23:09 +0200 Original-Received: from localhost ([::1]:34045 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8YZY-0006RT-6v for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Oct 2017 17:23:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8YZP-0006Pg-82 for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 17:23:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8YZK-0000Io-Fz for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 17:23:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59084) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e8YZK-0000Ii-BJ for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 17:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e8YZK-0007Zc-3c for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 17:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Oct 2017 21:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28864 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28864-submit@debbugs.gnu.org id=B28864.150922575429049 (code B ref 28864); Sat, 28 Oct 2017 21:23:02 +0000 Original-Received: (at 28864) by debbugs.gnu.org; 28 Oct 2017 21:22:34 +0000 Original-Received: from localhost ([127.0.0.1]:39529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8YYs-0007YS-4S for submit@debbugs.gnu.org; Sat, 28 Oct 2017 17:22:34 -0400 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:51083 helo=homiemail-a22.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8YYq-0007YL-Sp for 28864@debbugs.gnu.org; Sat, 28 Oct 2017 17:22:33 -0400 Original-Received: from homiemail-a22.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a22.g.dreamhost.com (Postfix) with ESMTP id DD473114066; Sat, 28 Oct 2017 14:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jurta.org; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=jurta.org; bh=IYlth35 zyjR+fh05jLi21Zvau0s=; b=R6ln9XyY9HkVxGiP/7mJxngWQkr2wFyUJtyKuH0 hKjBFZ9m8StjbsvkkMcG4k5Rh/2zd7J2ELzwujIJIgF4nr8HhKuGOmXZUW+le79O IUImLv1oFZoO2FEWSFyw9ATts59vhkMyBPemMyj5I0OEM6L2yjv363muHtWfqc3r BnXw= Original-Received: from localhost.linkov.net (m83-179-150-109.cust.tele2.ee [83.179.150.109]) (Authenticated sender: jurta@jurta.org) by homiemail-a22.g.dreamhost.com (Postfix) with ESMTPA id 8B6BC114065; Sat, 28 Oct 2017 14:22:30 -0700 (PDT) In-Reply-To: <87d15h5f97.fsf@gmail.com> (Tino Calancha's message of "Sat, 21 Oct 2017 12:52:36 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139130 Archived-At: >>> We can restrict to not do that when we are calling 'next-error-no-sel= ect. >>> I think some people don't like to use this-command in such >>> situations; alternatively, we could use `change-log-mode-hook' but th= e patch >>> below is shorter and explicit. >> >> It's really a hack though, right? Maybe no major modes should set >> next-error-last-buffer by itself, no matter the current command. > That sounds better. Please don't remove next-error-last-buffer from change-log-mode. Actually it is legitimate use according to the documentation of next-error-last-buffer: "The most recent =E2=80=98next-error=E2=80=99 buffer. A buffer becomes most recent when its compilation, grep, or similar mode is started, or when it is used with \\[next-error]." The problem occurred because two next-error buffer windows (*grep* and next-error capable ChangeLog) were both visible on the selected frame, but I believe we could fix this in the inner logic of next-error.