From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#30190: 27.0.50; term run in line mode shows user passwords Date: Sat, 10 Mar 2018 22:17:13 +0900 Message-ID: <87woykoysm.fsf@gmail.com> References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <83a7vgut17.fsf@gnu.org> <83y3j0t9qs.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1520687770 28202 195.159.176.226 (10 Mar 2018 13:16:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Mar 2018 13:16:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 30190@debbugs.gnu.org, rms@gnu.org, npostavs@users.sourceforge.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 10 14:16:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eueM0-0007DN-M2 for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Mar 2018 14:16:04 +0100 Original-Received: from localhost ([::1]:50763 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eueO3-0005FX-DG for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Mar 2018 08:18:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eueNx-0005FA-N8 for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 08:18:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eueNu-0001OO-He for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 08:18:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45311) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eueNu-0001O5-DW for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 08:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eueNt-00076g-V3 for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 08:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Mar 2018 13:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed security Original-Received: via spool by 30190-submit@debbugs.gnu.org id=B30190.152068785527278 (code B ref 30190); Sat, 10 Mar 2018 13:18:01 +0000 Original-Received: (at 30190) by debbugs.gnu.org; 10 Mar 2018 13:17:35 +0000 Original-Received: from localhost ([127.0.0.1]:53208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eueNR-00075r-VQ for submit@debbugs.gnu.org; Sat, 10 Mar 2018 08:17:35 -0500 Original-Received: from mail-pl0-f46.google.com ([209.85.160.46]:39931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eueNP-00075d-TM for 30190@debbugs.gnu.org; Sat, 10 Mar 2018 08:17:32 -0500 Original-Received: by mail-pl0-f46.google.com with SMTP id s13-v6so6777054plq.6 for <30190@debbugs.gnu.org>; Sat, 10 Mar 2018 05:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=qRatvfHEMNtWfEbbx7x0GhzeIZKEnbu8U35xYG4k0XA=; b=rDzR2SA3oQmykd67hH/P08MbtPBbI0NwsI2oXuY1RLjY/Vij2zX9QEovNheh2v40mC zlv8zBsOsNBp5yZwMxgjUKj8x7O2L7TSMpYrWcHqoGvvVYlM+I6RrMHEZ6k6uQuWBnOu e/P6Zwk9iw/1frwtcPt0oV0J4eH4ytIrEOcnszEt1URHu//M+vM5Hpp8Kczy5BnU2FRh sJ5XzGBtLt5vHewws4sDKnbNvrQWhgD/3NCUliPgtvynl07aj9nTtNoOjTchRChh/LZB sXUtfnDq5og2cLy1+q4DKvzjeGsIgJrf2Znd7dw7GwX9KAeJ9mSmUuji+79XciTt2pcL 7PMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=qRatvfHEMNtWfEbbx7x0GhzeIZKEnbu8U35xYG4k0XA=; b=ijw+kXalgoXOk33Jbd031ndBJh795fdJ69NSJBqPVREQ3p30C2NASb5uFuMrk8Qyof nB2vwecnc6ZNpVA5u5UcpMMOIiZiBAvpi8+zZmLZwYNHlO6kESiB99JhE+92VIsNWQAU 9Ca+xD0Mhq4pqsuU8VBI8K+WZ4cL9FjWEBdzTL/Gv6o9U+82V7JWHeV4Y2XZej7M3po1 cPxrXFVljncvQfoAct9CAz5fGSHsbHue7amjlS63hR3D+HdCZBFRzdjnbyuzDsjYEEx7 W0UWJ3Qkne1/8W9RzAihLnf80XY2G0T0rmIRY0MZkSES3bO3EQPg7BLQqH4p8rifq8Q2 vaGw== X-Gm-Message-State: AElRT7HNa7lXxynqhkARwNn2D+uX/rRUP9qgwOVCWsUzwo69w20aM35H p94IbaZ/Mca8inixY9rlZdU= X-Google-Smtp-Source: AG47ELsGmlmiD3TWP1vBpuOfK3GeFdQTrfACHZOgzIYAiknlE/aia6YtsPDbFfOboQqEt2eRsG/VMA== X-Received: by 2002:a17:902:8d90:: with SMTP id v16-v6mr2051832plo.168.1520687845915; Sat, 10 Mar 2018 05:17:25 -0800 (PST) Original-Received: from calancha-pc (146.219.128.101.dy.bbexcite.jp. [101.128.219.146]) by smtp.gmail.com with ESMTPSA id e83sm9046261pfk.148.2018.03.10.05.17.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 10 Mar 2018 05:17:23 -0800 (PST) In-Reply-To: <83y3j0t9qs.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 10 Mar 2018 14:07:07 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144107 Archived-At: Eli Zaretskii writes: >> I tried just after I read your message. I don't find a problem. > > Can you please show some examples? First, what text triggers the new > functionality correctly, when the user types a password at some > relevant prompt, and then what happens when an unrelated prompt is > taken by the filter function as a prompt for a password. I'd like to > understand better what happens in each case. Good behaviour: sudo ls # you are prompted in the minibuffer for your pass Bad behaviour: [sudo] password for foo: # This throws 'command not found' BUT _sometimes_ you are prompted for # your password in the minibuffer. # Note: This happens in a dumb shell buffer as well. >> And as a pointed out above, it uses the same mechanism as comint.el >> (e.g. dumb shell buffers), so I don't think you should worry about >> it. > > Sorry, this doesn't really tell me enough, because I don't think I > understand the relevance of dumb shells and comint to the issue at > hand. The relevance is that: I have copied from comint.el how to recognize a password prompt to redirect the prompt into the minibuffer (hidding the password). Whatever misfunction of my patch should happen in a dumb shell buffer started with: M-x shell IMO such side case is not an argument to reject this patch fixing a serious thing. I have uploaded a video running the above examples: https://www.dropbox.com/s/onr7peue6xd5fqh/record-desktop.mkv?dl=01 (BTW, got an offer to be the next 007 right after upload this video. Let's see. I am considering it...)