From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Nicolas Petton Newsgroups: gmane.emacs.bugs Subject: bug#24252: 25.1; json.el doesn't distinguish null and empty object Date: Wed, 13 Jun 2018 15:05:47 +0200 Message-ID: <87wov2q1jo.fsf@petton.fr> References: <87o9hci1c5.fsf@cassou.me> <877enniz5h.fsf@petton.fr> <87tvq9v40s.fsf@cassou.me> <83o9gg3p1o.fsf@gnu.org> <8736xrqhvh.fsf@cassou.me> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Trace: blaine.gmane.org 1528895379 14200 195.159.176.226 (13 Jun 2018 13:09:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 13 Jun 2018 13:09:39 +0000 (UTC) Cc: phst@google.com, mvoteiza@udel.edu, ted@oconnor.cx, 24252@debbugs.gnu.org, dgutov@yandex.ru, yoichi.nakayama@gmail.com To: Damien Cassou , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 13 15:09:34 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fT5Wm-0003Vq-1c for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Jun 2018 15:09:32 +0200 Original-Received: from localhost ([::1]:34121 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fT5Yt-0006pu-1l for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Jun 2018 09:11:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fT5TV-0002Zu-I2 for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2018 09:06:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fT5TR-0008WJ-0h for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2018 09:06:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37959) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fT5TQ-0008Vu-T6 for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2018 09:06:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fT5TQ-0004po-Ll for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2018 09:06:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas Petton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jun 2018 13:06:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24252 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24252-submit@debbugs.gnu.org id=B24252.152889516018561 (code B ref 24252); Wed, 13 Jun 2018 13:06:04 +0000 Original-Received: (at 24252) by debbugs.gnu.org; 13 Jun 2018 13:06:00 +0000 Original-Received: from localhost ([127.0.0.1]:45854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fT5TM-0004pJ-B1 for submit@debbugs.gnu.org; Wed, 13 Jun 2018 09:06:00 -0400 Original-Received: from petton.fr ([89.234.186.68]:40968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fT5TK-0004p3-D3 for 24252@debbugs.gnu.org; Wed, 13 Jun 2018 09:05:58 -0400 In-Reply-To: <8736xrqhvh.fsf@cassou.me> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=petton.fr; s=mail; t=1528895152; bh=kXIJ2UZNHxGswXgUzRjoXXJSCxXY9uQl/hZzLtOmPoU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:MIME-Version:Content-Type; b=YIJbKaJ0yi2hCOhnlUkr+MEKRxeQuJ7k80QdSJfyUy/H2hrobIA3hyoNU58I8zK2KEfFul4x0in3Ejq2z6i1ZHz1faKXPwmSFT2W4en3RsbHhx4VGpLztoYsV5KiAyU5xzxY8ZCdObuKE7Rmlkw0KBB0YPSiAWCsfH1WLDGJvQ8= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147364 Archived-At: --=-=-= Content-Type: text/plain Damien Cassou writes: > I understood Nico's message as a call for help from other Emacs > maintainers, not from me :-). It was just a question :-) > The new code is certainly *not* backward-compatible if you look at the > details. For example, `json-encode-list` was sometimes printing `null` > and it won't do that anymore. I see that as a bug fix because `null` is > not a list but it clearly makes the code not backward compatible. > > On the other hand, all existing unit tests still pass and the patch > includes a bunch of new ones. I have been using this patch since I wrote > it with no problem at all. Seems fair to me. I think we should install the patch. Eli, do you agree? If so, I'll install it in master. Cheers, Nico --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE1AWqLIYsVPF+7mvg6LzXhmr8+XgFAlshFqsACgkQ6LzXhmr8 +XhzcQf/dpHkSkrRKacYRUXG0tCH11dOlNyyw5Y538DhU765VMHb+oNoCVHwyVH1 zzHAayYMy9C7e+taFuYwq0kI69t4Dom9lbqFrA2KqoWJxrV6rFSe6zckEPPA/ZHE LVQbP/4jgPxPY2cvo+Ha7UvyxrwDgE5+SdDvpGCK0q2eaucaUQTr4WxVqyYgHDXD 55rnkIqN0I2HxsQtjwm14cljyb4pVpONy/YRemKPTOqbwMc4lixWONUrkY3zg378 03SU9h72+P4By1k8JOSLK9m9+nU8f78LMrY2J2vg/029dW5r10dap1SePFYNQKw/ m+DRMKOrF7KdDQ9kTQMiVDwPJzuQkQ== =2MyT -----END PGP SIGNATURE----- --=-=-=--