From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#30964: python-mode failing "overlapping strings" assertion lately Date: Sat, 16 Jun 2018 18:36:29 -0400 Message-ID: <87wouytl3m.fsf@gmail.com> References: <5c3e75f096fae419224804c590805b9c.squirrel@dancol.org> <874liqc7fd.fsf@gmail.com> <87muwd9ba1.fsf@gmail.com> <5481253d38230797b677df41cf507790.squirrel@dancol.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529188505 15250 195.159.176.226 (16 Jun 2018 22:35:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Jun 2018 22:35:05 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: =?UTF-8?Q?Cl=C3=83=C2=A9ment?= Pit-Claudel , Philipp Stephani , 30964@debbugs.gnu.org To: "Daniel Colascione" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 17 00:35:00 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUJme-0003qo-Jo for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Jun 2018 00:35:00 +0200 Original-Received: from localhost ([::1]:53062 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUJol-0002qg-R1 for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Jun 2018 18:37:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUJof-0002qY-Pn for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 18:37:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUJoc-0006lg-Md for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 18:37:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44344) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fUJoc-0006lY-IE for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 18:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fUJoc-0001eY-BA for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 18:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jun 2018 22:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30964-submit@debbugs.gnu.org id=B30964.15291885986324 (code B ref 30964); Sat, 16 Jun 2018 22:37:02 +0000 Original-Received: (at 30964) by debbugs.gnu.org; 16 Jun 2018 22:36:38 +0000 Original-Received: from localhost ([127.0.0.1]:52241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUJoE-0001dw-6J for submit@debbugs.gnu.org; Sat, 16 Jun 2018 18:36:38 -0400 Original-Received: from mail-it0-f52.google.com ([209.85.214.52]:34930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUJoC-0001dk-S1 for 30964@debbugs.gnu.org; Sat, 16 Jun 2018 18:36:37 -0400 Original-Received: by mail-it0-f52.google.com with SMTP id a3-v6so7396761itd.0 for <30964@debbugs.gnu.org>; Sat, 16 Jun 2018 15:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=dtjnHDGm7zovj4Xvo1TrGxZzfF37ylNdRuLsV6hR0Os=; b=TB7mdL4uyXlFe7mAGiJht2NbqXrfogbIjeyQxv3QSoLvCmhz5zmu0ZQuMtzssMLdrv jb45F5RmIj4qQ2WO6XOYlY4SNMlKJSxSH5NPIUVby2y1OHzk2BD3FLWpcVBG59tEPcK5 OxUNf41zik96iBqV7nvCd/3qamRbKsubP6RT+MK3j7Ngp9YML1fmP+NFaImb5odhzX4e +1oACpx33ioUlZGLXvh1sljziDC1vrmNd1zyXZOGZjFBs9U2c0mumyLg2DMSFh6EyMo6 2MAHs0s6hC4DAkiJEy84IJnhCFrV/hNfVXKR59TRIqDurKfSfTyTrpr8jLSSVv+9qT9P 3s1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=dtjnHDGm7zovj4Xvo1TrGxZzfF37ylNdRuLsV6hR0Os=; b=MPJ7kkpRi9jvNJDJuyLhOpQePdqACH0uOglcXFVuvzQae8q0uJWzulSn9OncnrEoVC bceSoy9CFbB2q67lYPZ77Pt2QMZ8qvVwH2cKqYINqJN36f9hswTueSp+8SOEaVoSbYtB gPZgIcGRtX48sffOTRmTxa+SQ3C442pbNOa2vU8SUzbzNq0wqvsvEtCWF4oteyDl1lld jqHlq6yuV7zFg9oTgfFhC9rxPRgOBw9E171TI+m0G+CLrHq+tyo2oy2DGPi8RxtGa/U5 87XjCKxZsO5Gd5+tl+WSHHUKAHSIv+0i8xjjtCS8M8ZXP6suhvT+416AVPYiztFptm+k iaUg== X-Gm-Message-State: APt69E38JrqIpbdD7GDzluSPGNPx5J8KBGo2/IGW+Yo6jw33Gztf0lRP KTjM/ymvP3MsXPu17Z1ST00Kv29T X-Google-Smtp-Source: ADUXVKKpnSUnQdU5z5InehW8ml2vFMDkmM/s34FCxnWiEMD/JaPo6Gc1pNwRYYuJu0fuyY80NqARvA== X-Received: by 2002:a24:4516:: with SMTP id y22-v6mr5551112ita.109.1529188591208; Sat, 16 Jun 2018 15:36:31 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id x5-v6sm3942879ioa.65.2018.06.16.15.36.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 16 Jun 2018 15:36:30 -0700 (PDT) In-Reply-To: <5481253d38230797b677df41cf507790.squirrel@dancol.org> (Daniel Colascione's message of "Sat, 16 Jun 2018 13:55:49 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147541 Archived-At: "Daniel Colascione" writes: > So it turns out that it wasn't an off-by-one problem at all. Instead, > python was using (re-search-forward (rx (syntax string-delimiter))), which > was matching incorrectly because re-search-forward didn't update syntax as > it matched. It didn't do that because regex matching in general wasn't > reentrant, and it wasn't reentrant because regex bytecode programs are > self-modifying. > > I checked in some work that makes regex searching update syntax as needed. It seems there were two separate problems. The off-by-one error still happens after your changes, so I pushed my patch to master. [1: 05345babc9]: 2018-06-16 18:34:19 -0400 Fix off by one error in python-mode assertion (Bug#30964) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=05345babc988060cca540770599282102c34f2a7