From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#32348: 27.0.50; EWW/SHR: Please add support for hiding DOM nodes with aria-hidden=true Date: Mon, 27 Aug 2018 20:03:22 -0400 Message-ID: <87wosbtl11.fsf@gmail.com> References: <874lg5y9c7.fsf@gmail.com> <23402.64973.657426.239435@retriever.mtv.corp.google.com> <87a7pnxk6r.fsf@gmail.com> <83k1oqih05.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1535414535 30365 195.159.176.226 (28 Aug 2018 00:02:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Aug 2018 00:02:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 32348@debbugs.gnu.org, raman@google.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 28 02:02:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuRST-0007lR-Po for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Aug 2018 02:02:09 +0200 Original-Received: from localhost ([::1]:35577 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fuRUa-0004u4-8B for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Aug 2018 20:04:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fuRUP-0004s8-79 for bug-gnu-emacs@gnu.org; Mon, 27 Aug 2018 20:04:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fuRUL-0005Uj-WF for bug-gnu-emacs@gnu.org; Mon, 27 Aug 2018 20:04:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57833) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fuRUL-0005UU-Pm for bug-gnu-emacs@gnu.org; Mon, 27 Aug 2018 20:04:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fuRUL-0000Z7-K8 for bug-gnu-emacs@gnu.org; Mon, 27 Aug 2018 20:04:05 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Aug 2018 00:04:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32348 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32348-submit@debbugs.gnu.org id=B32348.15354146142121 (code B ref 32348); Tue, 28 Aug 2018 00:04:05 +0000 Original-Received: (at 32348) by debbugs.gnu.org; 28 Aug 2018 00:03:34 +0000 Original-Received: from localhost ([127.0.0.1]:34616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuRTp-0000Y2-Ve for submit@debbugs.gnu.org; Mon, 27 Aug 2018 20:03:34 -0400 Original-Received: from mail-it0-f44.google.com ([209.85.214.44]:37411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuRTm-0000XX-5p; Mon, 27 Aug 2018 20:03:30 -0400 Original-Received: by mail-it0-f44.google.com with SMTP id h20-v6so138861itf.2; Mon, 27 Aug 2018 17:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=NciORm2bfbomekADocqvpx/GZSAmM38wQ6NcZaBzCio=; b=bww2RzwC5k1vfxG9kgNIuPmmxc+YdwiHj/grO+1+wR6+2aavR5EXa72YXjxB6xrygO EOKQMCSXmM6FWU4xAACfENusFDD4VFByXdZweXo7NgJBxhZaa7YvWUI96nmOS5Tzvdr/ jFXd3jMyWYI31zkgW7Zz5pzB5LoOX2zWsv4qcLGZIFYtxVEoiT3IBKQA9d6TiTZPcoN2 zEefI7l2/D78Z994Vei1drsBm4uoTdcaOy4vMQ9vk8NVHXmOuIALMPA2QVN8QxIE7Yc6 pWO9XnRrN/9XpYjG0g+uEHVWl6lJFrBkiLFPqkGG8LWo8NGLPRdYmqjuaPJfYjILDVht HFNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=NciORm2bfbomekADocqvpx/GZSAmM38wQ6NcZaBzCio=; b=aa27aNZ67YDh18i5Y4wSA4x3IAkEfE7FvSdba5EyuTR2OsWq07SlMMwjhk4PV0dbHK D5upfDErr6b4GmfbYVimPrq8ZlxoT87iWxuAzfBpZ68cZ3rLryRud1CLYYK3vFcQaLJ+ 63TFY9g6DZlNVA58AJ3TJkC1CH4/7ks5hp0X3xHMUFEbd2EGkWhpVzNHRg8Llzfky2J9 ejNynf2X43Llj0ntK2jb9cl9YMV9akrMzaakKxHx7Csav2XG109OvZkT4oFKpXEJIuMX DGalbzX2BxkUGBWFbxun5L3Gjd+fHjWjNGoQ5yfmDAXwc/iNqT+rpND77EQPYQGVbovV 2trA== X-Gm-Message-State: APzg51CqjN7kblP0njYKZQ/Je3mxk3dytEb04q92jCSzSfePYwzhP8Jk cPSAwv5njDS/RmjvltP4pqk2JRht X-Google-Smtp-Source: ANB0VdZdAFx+wElzjg6N9Y893cmG+96aoLD6ExYqZ/rbw90TwsX7VpY5xG4RlJ9kJ9GAI0t1//3guQ== X-Received: by 2002:a02:5c8f:: with SMTP id w15-v6mr11899167jad.109.1535414604707; Mon, 27 Aug 2018 17:03:24 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id k75-v6sm367900itk.31.2018.08.27.17.03.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Aug 2018 17:03:24 -0700 (PDT) In-Reply-To: <83k1oqih05.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Aug 2018 16:21:46 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149782 Archived-At: tags 32348 fixed close 32348 27.1 quit Eli Zaretskii writes: > Thanks, I think the NEWS entry should tell a bit more about the new > option. I added info from the docstring. >> +@vindex shr-discard-aria-hidden >> +@cindex aria-hidden > > @cindex could be more reader-friendly, e.g. > > @cindex @code{aria-hidden}, HTML attribute Done. >> + The HTML attribute @code{aria-hidden} is meant to tell screen >> +readers to ignore a tag's contents. You can customize the variable >> +@code{shr-discard-aria-hidden} to tell @code{shr} to ignore such tags. >> +This can be useful when using a screen reader on the output of >> +@code{shr} (e.g., on EWW buffer text). Or even when not using a >> +screen reader, since web authors often put this tag on non-essential >> +decorative content. > > The last sentence is incomplete, suggest to either make it part of the > previous one, or say something like "It can be useful even when not..." In my head it was one setence, but it gets a bit long that way. I split it like you suggested. [1: 0250d22eeb]: 2018-08-27 19:16:47 -0400 shr: Allow skipping tags with aria-hidden (Bug#32348) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0250d22eeb8427cb87c58f528f337dc83d0419a5