From: Noam Postavsky <npostavs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 32348@debbugs.gnu.org, raman@google.com
Subject: bug#32348: 27.0.50; EWW/SHR: Please add support for hiding DOM nodes with aria-hidden=true
Date: Mon, 27 Aug 2018 20:03:22 -0400 [thread overview]
Message-ID: <87wosbtl11.fsf@gmail.com> (raw)
In-Reply-To: <83k1oqih05.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Aug 2018 16:21:46 +0300")
tags 32348 fixed
close 32348 27.1
quit
Eli Zaretskii <eliz@gnu.org> writes:
> Thanks, I think the NEWS entry should tell a bit more about the new
> option.
I added info from the docstring.
>> +@vindex shr-discard-aria-hidden
>> +@cindex aria-hidden
>
> @cindex could be more reader-friendly, e.g.
>
> @cindex @code{aria-hidden}, HTML attribute
Done.
>> + The HTML attribute @code{aria-hidden} is meant to tell screen
>> +readers to ignore a tag's contents. You can customize the variable
>> +@code{shr-discard-aria-hidden} to tell @code{shr} to ignore such tags.
>> +This can be useful when using a screen reader on the output of
>> +@code{shr} (e.g., on EWW buffer text). Or even when not using a
>> +screen reader, since web authors often put this tag on non-essential
>> +decorative content.
>
> The last sentence is incomplete, suggest to either make it part of the
> previous one, or say something like "It can be useful even when not..."
In my head it was one setence, but it gets a bit long that way. I split
it like you suggested.
[1: 0250d22eeb]: 2018-08-27 19:16:47 -0400
shr: Allow skipping tags with aria-hidden (Bug#32348)
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0250d22eeb8427cb87c58f528f337dc83d0419a5
prev parent reply other threads:[~2018-08-28 0:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 15:25 bug#32348: 27.0.50; EWW/SHR: Please add support for hiding DOM nodes with aria-hidden=true T.V Raman
2018-08-08 0:45 ` Noam Postavsky
2018-08-08 14:27 ` T.V Raman
2018-08-15 23:51 ` Noam Postavsky
2018-08-16 2:23 ` T.V Raman
2018-08-16 11:25 ` Noam Postavsky
2018-08-16 14:09 ` T.V Raman
2018-08-16 13:21 ` Eli Zaretskii
2018-08-28 0:03 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wosbtl11.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=32348@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=raman@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).