From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#32676: Feature request Date: Mon, 17 Sep 2018 02:27:23 +0300 Organization: LINKOV.NET Message-ID: <87worlgh0k.fsf@mail.linkov.net> References: <20180910050802.25922-1-erjoalgo@gmail.com> <83a7ollcq2.fsf@gnu.org> <874let1o3k.fsf@gmail.com> <831s9xl54b.fsf@gnu.org> <874leq1hw4.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1537141044 22312 195.159.176.226 (16 Sep 2018 23:37:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 16 Sep 2018 23:37:24 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: Robert Pluim , 32676@debbugs.gnu.org To: Ernesto Alfonso Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 17 01:37:19 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1gbO-0005gN-N7 for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Sep 2018 01:37:19 +0200 Original-Received: from localhost ([::1]:33002 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1gdV-0000Kp-3q for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Sep 2018 19:39:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1gdK-0000J6-FJ for bug-gnu-emacs@gnu.org; Sun, 16 Sep 2018 19:39:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g1gdD-0007qh-7J for bug-gnu-emacs@gnu.org; Sun, 16 Sep 2018 19:39:14 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38183) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g1gd4-0007ZM-Ba for bug-gnu-emacs@gnu.org; Sun, 16 Sep 2018 19:39:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g1gd4-0000QM-6J for bug-gnu-emacs@gnu.org; Sun, 16 Sep 2018 19:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Sep 2018 23:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32676-submit@debbugs.gnu.org id=B32676.15371411301611 (code B ref 32676); Sun, 16 Sep 2018 23:39:02 +0000 Original-Received: (at 32676) by debbugs.gnu.org; 16 Sep 2018 23:38:50 +0000 Original-Received: from localhost ([127.0.0.1]:42441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1gcs-0000Pv-L7 for submit@debbugs.gnu.org; Sun, 16 Sep 2018 19:38:50 -0400 Original-Received: from pop.dreamhost.com ([64.90.62.162]:59604 helo=pdx1-sub0-mail-a8.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1gcr-0000Pl-90 for 32676@debbugs.gnu.org; Sun, 16 Sep 2018 19:38:49 -0400 Original-Received: from pdx1-sub0-mail-a8.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a8.g.dreamhost.com (Postfix) with ESMTP id 68A65806A1; Sun, 16 Sep 2018 16:38:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=OdCFtojw+wDsIdAFJxU8sv78oZc=; b= xQRKzoYqizVxnSax5HRixg7dS8xzSv1fFCXebqrnWN5GTMhyvR0IESawHrNLeGd8 MTNQg+Ie2ZiB2ZYqDwJ00aJIwNnH8uVWTho0/ynpeZ43oFCW5SCVgWhcZq+g91n6 cfURRcXIBWXUcDcLqHuIi7EKuFQGr6t/HGTsQXmzXa8= Original-Received: from localhost.linkov.net (m91-129-107-237.cust.tele2.ee [91.129.107.237]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a8.g.dreamhost.com (Postfix) with ESMTPSA id 071EC7E446; Sun, 16 Sep 2018 16:38:46 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a8 X-DH-BACKEND: pdx1-sub0-mail-a8 In-Reply-To: (Ernesto Alfonso's message of "Sat, 15 Sep 2018 17:37:12 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150357 Archived-At: >> Do I understand correctly that your proposed feature is like >> next-error-highlight, >> but instead of highlighting the error locus, it highlights the error >> message? > > Yes, although I don't think it's important to support a timer to turn off > highlighting like next-error-highlight does since the error locus > highlighting might get in the user's way in source buffers, but not in the > next-error buffer. I agree that a timer is not necessary in next-error-last-buffer. I just wanted to emphasize that your new customization could be like next-error-highlight defcustom (but without a timer option). > I don't see a reference to compilation-highlight-regexp or > compilation-highlight-overlay in my patch or in this thread. Although I did > use compilation-current-error to find the mark at the error message > location, which I think is not appropriate since that would be > compilation-specific, and I think it should be (point) instead. Is this > what you mean? I guess you need to highlight exactly the same place from where the error was visited. It looks like (point) is always located at this place because compilation-next-error-function sets overlay-arrow-position to (point-marker), so it should be the right place to highlight indeed.