From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: OGAWA Hirofumi Newsgroups: gmane.emacs.bugs Subject: bug#32880: 27.0.50; sieve-upload doesn't work if no sieve-buffer Date: Sun, 30 Sep 2018 17:40:35 +0900 Message-ID: <87wor3cr98.fsf_-_@mail.parknet.co.jp> References: <878t3jevfe.fsf@mail.parknet.co.jp> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1538297077 4142 195.159.176.226 (30 Sep 2018 08:44:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 30 Sep 2018 08:44:37 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: 32880@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 30 10:44:33 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6XL5-0000sq-MB for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Sep 2018 10:44:31 +0200 Original-Received: from localhost ([::1]:54398 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6XNC-0000Pn-6S for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Sep 2018 04:46:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6XHn-0003PJ-CX for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2018 04:41:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6XHi-0000zZ-FH for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2018 04:41:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55152) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g6XHi-0000zQ-9r for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2018 04:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g6XHi-0001wC-0U for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2018 04:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: OGAWA Hirofumi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Sep 2018 08:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32880 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32880-submit@debbugs.gnu.org id=B32880.15382968427416 (code B ref 32880); Sun, 30 Sep 2018 08:41:01 +0000 Original-Received: (at 32880) by debbugs.gnu.org; 30 Sep 2018 08:40:42 +0000 Original-Received: from localhost ([127.0.0.1]:59410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6XHO-0001vY-7i for submit@debbugs.gnu.org; Sun, 30 Sep 2018 04:40:42 -0400 Original-Received: from mail.parknet.co.jp ([210.171.160.6]:45940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6XHL-0001vM-Ha for 32880@debbugs.gnu.org; Sun, 30 Sep 2018 04:40:40 -0400 Original-Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id 8910F15AF4A for <32880@debbugs.gnu.org>; Sun, 30 Sep 2018 17:40:37 +0900 (JST) Original-Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.15.2/8.15.2/Debian-12) with ESMTPS id w8U8eaOx028542 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <32880@debbugs.gnu.org>; Sun, 30 Sep 2018 17:40:37 +0900 Original-Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.15.2/8.15.2/Debian-12) with ESMTPS id w8U8eaje011089 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <32880@debbugs.gnu.org>; Sun, 30 Sep 2018 17:40:36 +0900 Original-Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.15.2/8.15.2/Submit) id w8U8eZlH011088; Sun, 30 Sep 2018 17:40:35 +0900 In-Reply-To: (GNU bug Tracking System's message of "Sat, 29 Sep 2018 23:28:02 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150791 Archived-At: Found another issue while testing. `buffer-name' is used in `sieve-buffer' context too. This adds the fix additionally by setting `script-name' before switching to `sieve-buffer'. --- lisp/net/sieve.el | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff -puN lisp/net/sieve.el~sieve-fixes lisp/net/sieve.el --- emacs/lisp/net/sieve.el~sieve-fixes 2018-09-30 07:33:22.576515187 +0900 +++ emacs-hirofumi/lisp/net/sieve.el 2018-09-30 17:30:39.718548393 +0900 @@ -345,11 +345,14 @@ Used to bracket operations which move po ;;;###autoload (defun sieve-upload (&optional name) (interactive) - (when (or (get-buffer sieve-buffer) (call-interactively 'sieve-manage)) - (let ((script (buffer-string)) err) + (when (or (get-buffer sieve-buffer) + (save-current-buffer (call-interactively 'sieve-manage))) + (let ((script (buffer-string)) + (script-name (file-name-sans-extension (buffer-name))) + err) (with-current-buffer (get-buffer sieve-buffer) (setq err (sieve-manage-putscript - (or name sieve-buffer-script-name (buffer-name)) + (or name sieve-buffer-script-name script-name) script sieve-manage-buffer)) (if (sieve-manage-ok-p err) (message (substitute-command-keys _ -- OGAWA Hirofumi