From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33567: Syntactic fontification of diff hunks Date: Wed, 19 Dec 2018 23:51:24 +0200 Organization: LINKOV.NET Message-ID: <87woo5i3x3.fsf@mail.linkov.net> References: <878t18j4is.fsf@mail.linkov.net> <83a7lobemr.fsf@gnu.org> <87a7lnv6ex.fsf@mail.linkov.net> <83pnuj9kb8.fsf@gnu.org> <875zwajh6c.fsf@mail.linkov.net> <837egpagko.fsf@gnu.org> <87k1koygvm.fsf@mail.linkov.net> <83r2ew8mfx.fsf@gnu.org> <87va475y1m.fsf@mail.linkov.net> <87mupafi73.fsf@mail.linkov.net> <834lbgh3n7.fsf@gnu.org> <87h8fduis0.fsf@mail.linkov.net> <83d0q0dtc0.fsf@gnu.org> <877eg7sq8a.fsf@mail.linkov.net> <47546098-59ef-ae43-878a-fd225b60ec99@yandex.ru> <874lba1n0n.fsf@mail.linkov.net> <87d0pyxtnc.fsf@mail.linkov.net> <532bc1dc-1b44-dc3a-23f0-f96e6d586123@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1545256754 6340 195.159.176.226 (19 Dec 2018 21:59:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Dec 2018 21:59:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 33567@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 19 22:59:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZjrx-0001XI-EW for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Dec 2018 22:59:09 +0100 Original-Received: from localhost ([::1]:34363 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZju4-000318-9S for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Dec 2018 17:01:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZjtq-0002zr-OH for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 17:01:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZjtm-0003q8-MW for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 17:01:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50952) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZjtm-0003pz-Hs for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 17:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gZjtm-00059I-FA for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 17:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Dec 2018 22:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33567-submit@debbugs.gnu.org id=B33567.154525682919700 (code B ref 33567); Wed, 19 Dec 2018 22:01:02 +0000 Original-Received: (at 33567) by debbugs.gnu.org; 19 Dec 2018 22:00:29 +0000 Original-Received: from localhost ([127.0.0.1]:55205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZjtF-00057Z-Eo for submit@debbugs.gnu.org; Wed, 19 Dec 2018 17:00:29 -0500 Original-Received: from otter.birch.relay.mailchannels.net ([23.83.209.139]:11945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZjtD-00057O-UP for 33567@debbugs.gnu.org; Wed, 19 Dec 2018 17:00:28 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 1545D427EF; Wed, 19 Dec 2018 22:00:21 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a54.g.dreamhost.com (unknown [100.96.19.78]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 3F6A143A4C; Wed, 19 Dec 2018 22:00:20 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a54.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Wed, 19 Dec 2018 22:00:20 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Towering-Well-Made: 1ca555240ccdf91c_1545256820533_3163363047 X-MC-Loop-Signature: 1545256820533:1239056108 X-MC-Ingress-Time: 1545256820533 Original-Received: from pdx1-sub0-mail-a54.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a54.g.dreamhost.com (Postfix) with ESMTP id E5E2B803C4; Wed, 19 Dec 2018 14:00:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=49TpTrsd074zolpktQCU8It84A8=; b= VcnTEz3mGSVx7gXKr9ksHDTAHxId3Oh2ae6tzK1SROxpvZlgnCoZoLV79jnDu7HV 9mmPu76pyw4DWnvoKGdgzdJUSpq4ihUvnVTTGF2bbdNGOE+viEbcEREe3PQtnxel /iJoZrKPWwms7ivoch4meqQjAllpvVb3Xv2oo/Guq/Q= Original-Received: from mail.jurta.org (m91-129-106-79.cust.tele2.ee [91.129.106.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a54.g.dreamhost.com (Postfix) with ESMTPSA id 3946A803B5; Wed, 19 Dec 2018 14:00:12 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a54 In-Reply-To: <532bc1dc-1b44-dc3a-23f0-f96e6d586123@yandex.ru> (Dmitry Gutov's message of "Wed, 19 Dec 2018 02:48:58 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudejtddgudehiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtiedrjeelnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtiedrjeelpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgepfe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153619 Archived-At: >> Does it help to remove foreground colors from diff-added and diff-removed? > > Yup. Except if I customize those and restart, I think the +'s and -'s on > the left will become black as well, which is somewhat of a loss. So the > colors might need to be moved to other definitions, > e.g. diff-indicator-added. > > Further, I'm not sure if we should do the same to the look of the diff-mode > buffers when diff-font-lock-syntax is nil. Just something to consider. > > Third, third-party code might rely on those faces looking as they do > now. E.g. in diff-hl, diff-hl-insert inherits from diff-added, although > this package likely won't be affected by this change (the faces define > their own :foreground, for reasons lost to history). A worse situation with Magit - I was asked to update Magit to use this feature, but I don't know where to start: Magit uses green/red colors both for background and foreground. >> Neither GitHub nor GitLab have foreground green/red colors, only background >> green/red colors. > > Those are the interfaces that built up my expectations as well.