From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33567: Syntactic fontification of diff hunks Date: Thu, 20 Dec 2018 23:50:11 +0200 Organization: LINKOV.NET Message-ID: <87woo3kgvg.fsf@mail.linkov.net> References: <878t18j4is.fsf@mail.linkov.net> <83a7lobemr.fsf@gnu.org> <87a7lnv6ex.fsf@mail.linkov.net> <83pnuj9kb8.fsf@gnu.org> <875zwajh6c.fsf@mail.linkov.net> <837egpagko.fsf@gnu.org> <87k1koygvm.fsf@mail.linkov.net> <83r2ew8mfx.fsf@gnu.org> <87va475y1m.fsf@mail.linkov.net> <87mupafi73.fsf@mail.linkov.net> <834lbgh3n7.fsf@gnu.org> <87h8fduis0.fsf@mail.linkov.net> <83d0q0dtc0.fsf@gnu.org> <877eg7sq8a.fsf@mail.linkov.net> <47546098-59ef-ae43-878a-fd225b60ec99@yandex.ru> <874lba1n0n.fsf@mail.linkov.net> <87d0pyxtnc.fsf@mail.linkov.net> <532bc1dc-1b44-dc3a-23f0-f96e6d586123@yandex.ru> <87woo5i3x3.fsf@mail.linkov.net> <54f63175-1def-7227-e10b-e806002f0ed1@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1545345059 17191 195.159.176.226 (20 Dec 2018 22:30:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 20 Dec 2018 22:30:59 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 33567@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 20 23:30:54 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ga6qE-0004Mx-9e for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Dec 2018 23:30:54 +0100 Original-Received: from localhost ([::1]:41144 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ga6sK-0008H5-Vy for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Dec 2018 17:33:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ga6rP-0007qO-Nv for bug-gnu-emacs@gnu.org; Thu, 20 Dec 2018 17:32:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ga6rM-0005ut-AN for bug-gnu-emacs@gnu.org; Thu, 20 Dec 2018 17:32:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52602) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ga6rK-0005ry-3A for bug-gnu-emacs@gnu.org; Thu, 20 Dec 2018 17:32:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ga6rJ-0006ai-Tp for bug-gnu-emacs@gnu.org; Thu, 20 Dec 2018 17:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Dec 2018 22:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33567-submit@debbugs.gnu.org id=B33567.154534509225274 (code B ref 33567); Thu, 20 Dec 2018 22:32:01 +0000 Original-Received: (at 33567) by debbugs.gnu.org; 20 Dec 2018 22:31:32 +0000 Original-Received: from localhost ([127.0.0.1]:56854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ga6qp-0006ZZ-Qq for submit@debbugs.gnu.org; Thu, 20 Dec 2018 17:31:31 -0500 Original-Received: from bonobo.maple.relay.mailchannels.net ([23.83.214.22]:12307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ga6qn-0006ZQ-Gk for 33567@debbugs.gnu.org; Thu, 20 Dec 2018 17:31:30 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 07DDE284D15; Thu, 20 Dec 2018 22:31:28 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a6.g.dreamhost.com (unknown [100.96.19.78]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 9BBE9284889; Thu, 20 Dec 2018 22:31:27 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a6.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Thu, 20 Dec 2018 22:31:27 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Abortive-Shrill: 6a2cb4395bfbf8f5_1545345087767_1952358953 X-MC-Loop-Signature: 1545345087767:169437010 X-MC-Ingress-Time: 1545345087767 Original-Received: from pdx1-sub0-mail-a6.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTP id 2D0F380836; Thu, 20 Dec 2018 14:31:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=LI3h8Hbp0eoJ9z35WpmcZxo9rfw=; b= bYfp3AizSTmLtWUsoy+As5BSV3eezUJEcjbSJ9tfpi1zHc6lTgmHcWqEkRQXYn/5 r1TSCuouI1b6oikcJd2KluzRbD+fODc41UwQ0/njOJjJnOOWtE+3BFg7odiuJ8Ir miZ68lu9nFkLH0oOiNWYrOTJw065aFk8VedbFe/ZAPE= Original-Received: from mail.jurta.org (m91-129-106-79.cust.tele2.ee [91.129.106.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTPSA id 7494780850; Thu, 20 Dec 2018 14:31:22 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a6 In-Reply-To: <54f63175-1def-7227-e10b-e806002f0ed1@yandex.ru> (Dmitry Gutov's message of "Thu, 20 Dec 2018 02:11:20 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudejfedgudeifecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtiedrjeelnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtiedrjeelpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgeptd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153658 Archived-At: >> A worse situation with Magit - I was asked to update Magit >> to use this feature, but I don't know where to start: >> Magit uses green/red colors both for background and foreground. > > Are there cases where it uses only red/green foreground to show a hunk? > I would honestly just skip those cases, if Magit insists on doing things in > several different ways. > > Not sure why you need to port the new feature yourself, though. I see no such cases with only red/green foreground, so it's safe to remove red/green foreground, but probably I'll let Magit developers port it themselves because I don't understand many their design decisions.