From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Federico Tedin Newsgroups: gmane.emacs.bugs Subject: bug#34147: 27.0.50; M-x describe-package groovy-mode breaks Date: Tue, 12 Mar 2019 21:39:11 -0300 Message-ID: <87wol34ngw.fsf@gmail.com> References: <878syt96lg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="41806"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 34147@debbugs.gnu.org To: Xu Chunyang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 13 01:44:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3s0L-000AlK-5p for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Mar 2019 01:44:21 +0100 Original-Received: from localhost ([127.0.0.1]:35765 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3s0J-0008SP-VX for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Mar 2019 20:44:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3s04-0008Q2-LW for bug-gnu-emacs@gnu.org; Tue, 12 Mar 2019 20:44:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3rwA-0000s9-BV for bug-gnu-emacs@gnu.org; Tue, 12 Mar 2019 20:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55547) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h3rwA-0000qD-0B for bug-gnu-emacs@gnu.org; Tue, 12 Mar 2019 20:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h3rw9-0001ay-QE for bug-gnu-emacs@gnu.org; Tue, 12 Mar 2019 20:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Federico Tedin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Mar 2019 00:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34147 X-GNU-PR-Package: emacs Original-Received: via spool by 34147-submit@debbugs.gnu.org id=B34147.15524375636080 (code B ref 34147); Wed, 13 Mar 2019 00:40:01 +0000 Original-Received: (at 34147) by debbugs.gnu.org; 13 Mar 2019 00:39:23 +0000 Original-Received: from localhost ([127.0.0.1]:40858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h3rvW-0001a0-Sw for submit@debbugs.gnu.org; Tue, 12 Mar 2019 20:39:23 -0400 Original-Received: from mail-qt1-f181.google.com ([209.85.160.181]:36320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h3rvV-0001Zn-7J for 34147@debbugs.gnu.org; Tue, 12 Mar 2019 20:39:21 -0400 Original-Received: by mail-qt1-f181.google.com with SMTP id b3so56478qtj.3 for <34147@debbugs.gnu.org>; Tue, 12 Mar 2019 17:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BZRbqj6WS5eGPWzSHDkzhIgHqx5JVGbqu5Q8kadGzIQ=; b=Dv0ouL9InbnOsZgHHbdUlSaSMQmdCxlpNkzwqPjKUa8I/aOPUfsej57mE7lsc/jiTP lgJ2jroLd10Ea15iO5oFZ0f0KJWpmvK5iDP9h6iNF3oqss+OGsCV5BYXRnBYpGgs/SKc can/jNQGJHsVW/tkEgSG6mgS3EduIwKcClVwkkWp1wu8yMS/p98SbvsbfQooU/rYdgax i3Pw2aHV9gk1Gu2qcqo70zHfyUQx7zNcQTJflh0PvT3yWdEEF+/GrQKM/Elbh+x61BsI Fo5DIJaE9kyolMALSX2cCMZc4cvzn3TtiuwlceBp/LB8ErXv/VCdUFsVy+EMGV15V2T6 1y3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BZRbqj6WS5eGPWzSHDkzhIgHqx5JVGbqu5Q8kadGzIQ=; b=RHyvDA59E1zG4euVB9+AZJ2Lovi49fN9cDVY/hbRZOpIiDzVDS2XgGvztGEZWX/7UZ 7kAv/A4BfgKgHokdb5bXKw4OaRFai0kb0g7SSiz09/cmcZ3+iFkBbOhRp61OJruNEf0G A/xGPP38mGeL0cVkeYpg2HSZ5QfQKisrNCTcg90PuHOmmuqBaTwmFA2EHnoLV/dCf1xf +4MTUEvbWw88tZCIxBAj8XgCXKi1EEHv28FxJln2uVsI1tq/iWUcjSL9UEXRCrL7JE8h 8mqLDrUCXLvybzQV569r6JCf8i6UtEQfF2NMnCDc/QtNLyLdzDmx3qIFfcK+NzhPcMZ/ eORA== X-Gm-Message-State: APjAAAXuNszsYUA3+wvlKWdy0Rk+TXCzKeVE8r3eJQU4e2j3RyHbSFZZ ThIcxCNnRsboy58gS9rlfLsW7w1C/Ac= X-Google-Smtp-Source: APXvYqwX/vnHX97KaQRV9Zi3atPSi6YepuOC7FZJnvHeUgd7SR7Nv0wC4kIMI2MB2hUkCduChwiYWA== X-Received: by 2002:ac8:2945:: with SMTP id z5mr32352359qtz.100.1552437555169; Tue, 12 Mar 2019 17:39:15 -0700 (PDT) Original-Received: from hideo ([181.170.211.157]) by smtp.gmail.com with ESMTPSA id b10sm7323650qtb.93.2019.03.12.17.39.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Mar 2019 17:39:14 -0700 (PDT) In-Reply-To: <878syt96lg.fsf@gmail.com> (Federico Tedin's message of "Tue, 05 Feb 2019 20:08:11 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156283 Archived-At: --=-=-= Content-Type: text/plain I'm attaching a small patch with the changes I suggested above. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=package.patch Content-Description: patch >From b842f54518a6565edd78a363b65e8a8b690dbdf8 Mon Sep 17 00:00:00 2001 From: Federico Tedin Date: Tue, 12 Mar 2019 21:34:31 -0300 Subject: [PATCH 1/1] Correctly handle packages without description in describe-package * lisp/emacs-lisp/package.el (describe-package-1): Do not call insert if package description is nil (Bug#34147). --- lisp/emacs-lisp/package.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 5e8864ec73..ad1fb363f1 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2482,7 +2482,8 @@ describe-package-1 (insert ?\n))) (setq readme-string (buffer-string)) t) - (insert readme-string)) + (when readme-string + (insert readme-string))) )))) (defun package-install-button-action (button) -- 2.17.1 --=-=-=--