From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#35123: [PATCH] Use lexical-binding in bug-reference Date: Wed, 03 Apr 2019 09:40:59 -0500 Message-ID: <87wokbb18k.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="204801"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.1.0; emacs 27.0.50 To: 35123@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 03 16:42:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBh5j-000r8E-3k for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Apr 2019 16:42:15 +0200 Original-Received: from localhost ([127.0.0.1]:42954 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBh5i-0001HF-3I for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Apr 2019 10:42:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBh5a-0001Gw-Gb for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 10:42:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBh5X-0003ST-Lr for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 10:42:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57794) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBh5X-0003Pl-3I for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 10:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hBh5W-0008IL-Ll for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 10:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Apr 2019 14:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35123 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.155430247531830 (code B ref -1); Wed, 03 Apr 2019 14:42:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Apr 2019 14:41:15 +0000 Original-Received: from localhost ([127.0.0.1]:43105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBh4l-0008HJ-74 for submit@debbugs.gnu.org; Wed, 03 Apr 2019 10:41:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBh4i-0008H6-Pb for submit@debbugs.gnu.org; Wed, 03 Apr 2019 10:41:13 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:44582) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hBh4d-0000gJ-Fo for submit@debbugs.gnu.org; Wed, 03 Apr 2019 10:41:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBh4c-0000sO-4N for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 10:41:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBh4a-0000YG-Lg for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 10:41:05 -0400 Original-Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]:46007) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBh4a-0000Uf-34 for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 10:41:04 -0400 Original-Received: by mail-ot1-x330.google.com with SMTP id e5so15582906otk.12 for ; Wed, 03 Apr 2019 07:41:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=zZpraizo0h/7Y7FIYRjQ1BZVrA+kKlcRdxwFlQvvp5M=; b=iEGCcmcSJ46HQ41i5mcNiTDZf4uhDkNl1cdJoInMc7n9r71ob2pjZvVjAxhdN0zoS7 9ZNh7eppoSvKBf6wMMX7lG/hCIUTsC5dfI1ONiWupz9A+dT8vlFpJQW1Gf4+4OiTI+uU bCJ9s4/oTXSitxuoYW1VntFBxPnkbIEx1GvcZR933zd7LVfbk3NE0tftXq+ov3tAs5aX U25f01yLsTQruoXeOUJzTXyal36d9GovAfh9TzcxjRFYAKkVzgqky4f816xB0xMyfsYg CKQqqe1x1x3ZB37inJhGZggYslsnLrnrmtNKiruJPjkEg+4oMUcBxVCa4Rk7FKmX0gPs ZMBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=zZpraizo0h/7Y7FIYRjQ1BZVrA+kKlcRdxwFlQvvp5M=; b=nR192zmTffF+ofitxukASXnTu2fVUjmXDISkXwzGzuKDhaBYkvl+zFQBQHSozXXtj/ 9kyQaERJ80MZPsO5N1MI3ndkKsqJkNqPesDh6AWZMlGRmxbMTeJWFd6R1OD/eXVSVcpT dN00LMWQJiOIMHHWBOjQMfAmdjEWXwqeqxBTs3YC0RcQLSM1nqFdweTepMN0026zpU+O l66XZqxOWNS+hrB7PlskRMdt0HO1nIrOKUbF+Dy3KDX6qWtfnwsSTlQ7GXjpiA8X+SB/ kP4y3EmRkLIVyHuEORSJSJPWvWyAJOu8YnOBhMkGPQ0m7FYJfB5bvulZx+d5iZempeYK FL/w== X-Gm-Message-State: APjAAAWSvTe+NuAE2065KJGd+MUt1pno5Msj8+SYUo9FUh4ckP8+qOk2 kkLOvMPIuj66r7L+7EAz6szPthnQ X-Google-Smtp-Source: APXvYqzwEVxpXiW7AXctXMW0y0Es+yYd9+0dl7K1aU3vpRSq6Y8CpaBbsi8YQ3XN6gayUR/pDKGkYw== X-Received: by 2002:a9d:2942:: with SMTP id d60mr20202otb.82.1554302462567; Wed, 03 Apr 2019 07:41:02 -0700 (PDT) Original-Received: from mars (nat-128-62-49-203.public.utexas.edu. [128.62.49.203]) by smtp.gmail.com with ESMTPSA id a198sm6880378oib.19.2019.04.03.07.41.01 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Apr 2019 07:41:01 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157124 Archived-At: --=-=-= Content-Type: text/plain Hi - The attached patch switches bug-reference.el to use lexical binding. There don't appear to be any tests for bug-reference, but I've tested it locally and everything seems to work just fine. The patch also updates .dir-locals so that bug-reference-url-format is set in all modes, not just changelog mode. This helps users who e.g. use magit. Arguably that should be two commits. Just let me know if you'd prefer that and I can split it out. Thanks, Alex --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Use-lexical-binding-in-bug-reference.el.patch >From 2c463bf99835f907ab2c93ffc79fe8d7a4054e4b Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Wed, 3 Apr 2019 09:36:23 -0500 Subject: [PATCH] Use lexical binding in bug-reference.el * .dir-locals.el: Set bug-reference-url-format in all modes, not just changelog mode. * lisp/progmodes/bug-reference.el: Use lexical binding. (bug-reference-unfontify): (bug-reference-fontify): Mention args in docstring. --- .dir-locals.el | 4 ++-- lisp/progmodes/bug-reference.el | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.dir-locals.el b/.dir-locals.el index 9cd39920c2..506edfcf73 100644 --- a/.dir-locals.el +++ b/.dir-locals.el @@ -1,6 +1,7 @@ ((nil . ((tab-width . 8) (sentence-end-double-space . t) - (fill-column . 70))) + (fill-column . 70) + (bug-reference-url-format . "https://debbugs.gnu.org/%s"))) (c-mode . ((c-file-style . "GNU") (c-noise-macro-names . ("INLINE" "ATTRIBUTE_NO_SANITIZE_UNDEFINED" "UNINIT" "CALLBACK" "ALIGN_STACK")) (electric-quote-comment . nil) @@ -12,7 +13,6 @@ (log-edit-setup-add-author . t))) (change-log-mode . ((add-log-time-zone-rule . t) (fill-column . 74) - (bug-reference-url-format . "https://debbugs.gnu.org/%s") (mode . bug-reference))) (diff-mode . ((mode . whitespace))) (emacs-lisp-mode . ((indent-tabs-mode . nil) diff --git a/lisp/progmodes/bug-reference.el b/lisp/progmodes/bug-reference.el index 8baf74854f..d21f5b984f 100644 --- a/lisp/progmodes/bug-reference.el +++ b/lisp/progmodes/bug-reference.el @@ -1,4 +1,4 @@ -;; bug-reference.el --- buttonize bug references +;; bug-reference.el --- buttonize bug references -*- lexical-binding: t; -*- ;; Copyright (C) 2008-2019 Free Software Foundation, Inc. @@ -91,7 +91,7 @@ The second subexpression should match the bug reference (usually a number)." (bug-reference-set-overlay-properties) (defun bug-reference-unfontify (start end) - "Remove bug reference overlays from region." + "Remove bug reference overlays from the region between START and END." (dolist (o (overlays-in start end)) (when (eq (overlay-get o 'category) 'bug-reference) (delete-overlay o)))) @@ -99,7 +99,7 @@ The second subexpression should match the bug reference (usually a number)." (defvar bug-reference-prog-mode) (defun bug-reference-fontify (start end) - "Apply bug reference overlays to region." + "Apply bug reference overlays to region between START and END." (save-excursion (let ((beg-line (progn (goto-char start) (line-beginning-position))) (end-line (progn (goto-char end) (line-end-position)))) -- 2.19.2 --=-=-=--