unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Garreau\, Alexandre" <galex-713@galex-713.eu>
Cc: 33224@debbugs.gnu.org
Subject: bug#33224: `message-simplify-subject' simplification (and extensibility)
Date: Mon, 13 May 2019 16:36:21 -0400	[thread overview]
Message-ID: <87woiuqegq.fsf@mouse.gnus.org> (raw)
In-Reply-To: <87zhutmi7a.fsf@portable.galex-713.eu> (Alexandre Garreau's message of "Thu, 01 Nov 2018 07:21:13 +0100")

"Garreau, Alexandre" <galex-713@galex-713.eu> writes:

> Hi, here a patch simplyfing `message-simplify-subject' to make it
> extensible (users can now add their own tailor-made one-arg function to
> `message-simplify-subject-functions'), by removing all the explicit
> checks and funcall, and just calling all the functions (implicit check
> for `message-strip-list-identifiers' is moved to its body, and one for
> `message-strip-subject-re' is removed based on previous patch from
> <Bug#33200>).

I have no idea why that function was written in that strange way, and
I've applied your patch.

> This is my second patch, please tell-me if there’s a problem anywhere.
> Not sure if I know how to make patch properly, nor to report bugs
> properly.

Everything seems to work for me when testing.  As your total added lines
was less than ten, no FSF copyright assignment paperwork is needed, but
if you intend on contributing further, it might be nice to start that
process now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      reply	other threads:[~2019-05-13 20:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01  6:21 bug#33224: `message-simplify-subject' simplification (and extensibility) Garreau, Alexandre
2019-05-13 20:36 ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87woiuqegq.fsf@mouse.gnus.org \
    --to=larsi@gnus.org \
    --cc=33224@debbugs.gnu.org \
    --cc=galex-713@galex-713.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).