From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#27775: footnotes mode hanging indent [CODE INCLUDED] Date: Tue, 23 Jul 2019 13:03:35 +0200 Message-ID: <87wog9108o.fsf@mouse.gnus.org> References: <20170720210849.GJ803@E15-2016.optimum.net> <87o91n5u0s.fsf@mouse.gnus.org> <87wog9wogl.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="256472"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 27775@debbugs.gnu.org, Boruch Baum To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 23 13:04:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpsaW-0014VS-SK for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jul 2019 13:04:08 +0200 Original-Received: from localhost ([::1]:41244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpsaV-0003qH-R7 for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jul 2019 07:04:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46477) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpsaS-0003qB-PM for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2019 07:04:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpsaR-000641-Fp for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2019 07:04:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53517) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hpsaR-00063p-Bx for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2019 07:04:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hpsaQ-0003Ej-Vj for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2019 07:04:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jul 2019 11:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27775 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 27775-submit@debbugs.gnu.org id=B27775.156387982612418 (code B ref 27775); Tue, 23 Jul 2019 11:04:02 +0000 Original-Received: (at 27775) by debbugs.gnu.org; 23 Jul 2019 11:03:46 +0000 Original-Received: from localhost ([127.0.0.1]:34105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpsa9-0003ED-S1 for submit@debbugs.gnu.org; Tue, 23 Jul 2019 07:03:46 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:37476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpsa8-0003E3-1X for 27775@debbugs.gnu.org; Tue, 23 Jul 2019 07:03:45 -0400 Original-Received: from [80.169.244.84] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpsa0-0007v1-Lj; Tue, 23 Jul 2019 13:03:40 +0200 In-Reply-To: <87wog9wogl.fsf@gmail.com> (Noam Postavsky's message of "Mon, 22 Jul 2019 21:04:42 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163626 Archived-At: Noam Postavsky writes: > Lars Ingebrigtsen writes: > >> so I've added a new fill-paragraph function to the Emacs trunk. > > Hmm, you did > > (define-minor-mode footnote-mode > ... > (setq-local fill-paragraph-function #'footnote--fill-paragraph) > > But since footnote-mode is a minor mode, isn't it a mistake to just take > over fill-paragraph-function like that? What if the major mode has > installed some fill-paragraph-function? Oh, yeah, that's true. How are minor modes supposed to do the paragraph filling? Hm... For adaptive fill footnote does: (unless adaptive-fill-function ;; nil and `ignore' have the same semantics for adaptive-fill-function, ;; but only `ignore' behaves correctly with add/remove-function. (setq adaptive-fill-function #'ignore)) (remove-function (local 'adaptive-fill-function) #'footnote--adaptive-fill-function) [...] (add-function :around (local 'adaptive-fill-function) #'footnote--adaptive-fill-function) and I guess it could do the same for fill-paragraph-function? (It seems like a mouthful, though -- perhaps there should be a helper function to do all this?) Hm! Or will using fill-forward-paragraph-function do the right thing both for adaptive filling and paragraph filling? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no