From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters Date: Sat, 27 Jul 2019 19:26:25 +0200 Message-ID: <87wog3pewu.fsf@gmail.com> References: <87zho2cd4f.fsf@gmail.com> <87wohvf22u.fsf@gmail.com> <87h88cvpkj.fsf_-_@gmail.com> <87imsinbmr.fsf_-_@gmail.com> <87y313z3tp.fsf@gmail.com> <83wog3lo5c.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="141193"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: michael_heerdegen@web.de, 35564@debbugs.gnu.org, monnier@iro.umontreal.ca, npostavs@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 27 19:27:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrQTR-000aXo-Dg for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jul 2019 19:27:13 +0200 Original-Received: from localhost ([::1]:46750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrQTL-00013x-27 for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jul 2019 13:27:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55209) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrQTH-00013c-TP for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 13:27:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrQTG-0005LD-NY for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 13:27:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36555) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hrQTG-0005Kw-KF for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 13:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hrQTG-0006f0-Eq for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 13:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jul 2019 17:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35564-submit@debbugs.gnu.org id=B35564.156424839725564 (code B ref 35564); Sat, 27 Jul 2019 17:27:02 +0000 Original-Received: (at 35564) by debbugs.gnu.org; 27 Jul 2019 17:26:37 +0000 Original-Received: from localhost ([127.0.0.1]:45376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrQSq-0006eG-Lh for submit@debbugs.gnu.org; Sat, 27 Jul 2019 13:26:36 -0400 Original-Received: from mail-wr1-f68.google.com ([209.85.221.68]:32881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrQSm-0006dy-To for 35564@debbugs.gnu.org; Sat, 27 Jul 2019 13:26:35 -0400 Original-Received: by mail-wr1-f68.google.com with SMTP id n9so57616942wru.0 for <35564@debbugs.gnu.org>; Sat, 27 Jul 2019 10:26:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=G1gCwtMQmx9wibDYGZ7I2a8UWycoXunib42GtqBF54c=; b=irxCMfrkbSz6bJhBa4m1YrHvgQoiptD8FG3s43ulakskW6mXRqKzbJABMieB6A0QDA CH5D/XcH7hh/mVEDVEcDLZwUN0lrl28CITHd3Vta8BJeF6lLzGH2/FKrjiEm3XFPcbn/ UtwGnZ7U33kJHJW9afOdUsYyO1m8Kt15bS0XvC/BdgZN5rgpEp1noKnN7vSRHXXIDCeG UgTFiMAw+NU4VrykzsGAZoX2RvbFYRc8uzfasnTh3j+4n9ruMrELgeE5hoCSYLaMTw0+ v8wvCMZKYjR7Qswx6OztOKKRF/NlHfl+i9L6ixsko7dXMY6gQjg9+kelM2PbTX3ftyhb xWQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=G1gCwtMQmx9wibDYGZ7I2a8UWycoXunib42GtqBF54c=; b=ZTtAT4C/27P8bKwGr2JDlBUvOOX2//6R5xYqs3Pxx9Vz1CDvosCWCMyzzCf5+5UgMb AOHl2zC3kmAnwV6+h0uNvLJ//chYQomO83EZtbrxme66CZzCFU8eKYaYOHD2RUTkWbaG CSbmVHD9GeftUwYygEL2O/4wEfPzYhkiNapPB0AHgIlrkvkqgQ5Y/BrVsDBzoc9LEUMV ucFBrj5R5hLslhj5bXT0HEVZ8w6unrYlwBPK607ApHVuxnPTbsOaw7FMso/1gRzITDDV OeuoAjH7l8Ag2f2Y0wmR9t75sORHE9Ke3N6x8HTjMRhc25XbPNew5LV37/fGByyl3KWB nMNQ== X-Gm-Message-State: APjAAAWlcMv5087YvYw6eFZi7a3I/Eh+BVEnSwqCPyRqpmWLtPsMv2LZ 0xjjQ3suKZmGwiCgVUCp4k4= X-Google-Smtp-Source: APXvYqyfFDHZp2wipe/97mdC8rmLQaqtKavDWXto1hR7bCrNoahxQXnraduedZM2hnf89TvXEV5QBQ== X-Received: by 2002:adf:e790:: with SMTP id n16mr92005107wrm.120.1564248387148; Sat, 27 Jul 2019 10:26:27 -0700 (PDT) Original-Received: from nc10-laptop (2a01cb04010fc800c8771fb97d0446e3.ipv6.abo.wanadoo.fr. [2a01:cb04:10f:c800:c877:1fb9:7d04:46e3]) by smtp.gmail.com with ESMTPSA id g10sm40992829wrw.60.2019.07.27.10.26.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 27 Jul 2019 10:26:26 -0700 (PDT) In-Reply-To: <83wog3lo5c.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Jul 2019 14:20:31 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163910 Archived-At: Eli Zaretskii writes: >> From: K=C3=A9vin Le Gouguec >> Cc: Eli Zaretskii , Stefan Monnier >> , Drew Adams , Noam >> Postavsky >> Date: Fri, 12 Jul 2019 17:10:26 +0200 >>=20 >> I have now added '^' markers below the highlighted command, on condition >> that the echo area is wide enough not to wrap lines. >>=20 >> Do we want to add some customizability (highlight face, whether or not >> to display '^' markers), or is this good enough for now? >>=20 >>=20 >> The patch series now includes: >>=20 >> - two patches to make y-or-n-p preserve text properties and implement an >> initial version of highlighting, >> - Noam's refactoring patch, plus fixups, >> - one patch to add '^' markers, >> - one last patch to make tests less tedious to maintain. > > Any more comments, anyone? Michael had some comments over at bug#28969, but no objections AFAICT. Michael, did you get the chance to try the patch out? > Is there anything in these changes that would warrant a NEWS entry? The changes are only cosmetic: the user interaction has not changed (tell Dired to run a command, press 'y' to confirm). The prompt is simply more verbose now. There are no new variables for the user to customize either, if I am not mistaken. NB: I squashed all those patches in [2], to make it easier to try the new prompt out. The squashed patch's commit message summarizes every change, and mentions both bugs; I don't know if it makes more sense to commit the series or the squashed patch to the repository. [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28969#22 [2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28969#19