From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#26328: 26.0.50; checkdoc action for join lines drops final " Date: Thu, 15 Aug 2019 16:18:30 -0700 Message-ID: <87wofet3uh.fsf@mouse.gnus.org> References: <84y3vkqzmd.fsf@tm6592> <878sslnk5w.fsf@mouse.gnus.org> <8736iquuda.fsf@gmail.com> <877e7eowe2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="189997"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Marco Wahl , Noam Postavsky , 26328@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 16 01:19:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyP1R-000nHv-1R for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Aug 2019 01:19:09 +0200 Original-Received: from localhost ([::1]:47848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyP1P-0000EO-UF for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Aug 2019 19:19:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43168) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyP1L-0000EH-3l for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 19:19:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyP1K-0008NK-07 for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 19:19:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43833) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hyP1J-0008N8-TH for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 19:19:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hyP1J-00081k-O2 for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 19:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Aug 2019 23:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26328 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 26328-submit@debbugs.gnu.org id=B26328.156591111830825 (code B ref 26328); Thu, 15 Aug 2019 23:19:01 +0000 Original-Received: (at 26328) by debbugs.gnu.org; 15 Aug 2019 23:18:38 +0000 Original-Received: from localhost ([127.0.0.1]:52654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyP0w-000817-AD for submit@debbugs.gnu.org; Thu, 15 Aug 2019 19:18:38 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:48990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyP0v-00080z-2k for 26328@debbugs.gnu.org; Thu, 15 Aug 2019 19:18:37 -0400 Original-Received: from [50.225.213.182] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyP0r-0007yo-8x; Fri, 16 Aug 2019 01:18:35 +0200 In-Reply-To: <877e7eowe2.fsf@gmail.com> (Alex Branham's message of "Thu, 15 Aug 2019 18:13:09 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165155 Archived-At: Alex Branham writes: >>> AFAICT, both proposed patches will do the wrong thing for this case: >>> >>> (defun foo () >>> "Bla bla >>> bla bla. More words >>> bla bla bla.") [...] > + (when (checkdoc-autofix-ask-replace > + p (1+ p) > + "1st line not a complete sentence. Join these lines? " > + " " t) > + ;; They said yes. We have more fill work to do... > + (delete-indentation nil p (1+ p)) > + (setq msg nil))))) This looks like the right thing for the original use case, but will it fix the example above? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no