unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: philip@warpmail.net (Philip K.)
To: 41095@debbugs.gnu.org
Subject: bug#41095: ERC header line
Date: Tue, 05 May 2020 14:46:47 +0200	[thread overview]
Message-ID: <87wo5q1rd4.fsf@bulbul> (raw)

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]


Hi,

when trying out a dark theme I noticed that the ERC header line was out
of place. It turns out that this is because it's fore- and background
color are hard-coded to gray20 and gray90. Since these are fairly
similar to the default colours of header-line using a light
colour-scheme, I suggest inheriting it's values by default.c

-- 
	Philip K.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Make-erc-header-line-inherit-from-header-line.patch --]
[-- Type: text/x-diff, Size: 710 bytes --]

From e5083ec06ee6a2be637fb8773a9c6cd907b26fc5 Mon Sep 17 00:00:00 2001
From: Philip K <philip@warpmail.net>
Date: Tue, 5 May 2020 14:41:06 +0200
Subject: [PATCH] Make erc-header-line inherit from header-line

---
 lisp/erc/erc.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index cfde84e19a..a237ca7ce9 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -1212,7 +1212,7 @@ erc-direct-msg-face
   :group 'erc-faces)
 
 (defface erc-header-line
-  '((t :foreground "grey20" :background "grey90"))
+  '((t :inherit header-line))
   "ERC face used for the header line.
 
 This will only be used if `erc-header-line-face-method' is non-nil."
-- 
2.20.1


             reply	other threads:[~2020-05-05 12:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 12:46 Philip K. [this message]
2020-07-29  4:54 ` bug#41095: ERC header line Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wo5q1rd4.fsf@bulbul \
    --to=philip@warpmail.net \
    --cc=41095@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).