From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#20092: 24.4.91; False matches with incremental search in Info Date: Tue, 25 Aug 2020 11:40:37 +0200 Message-ID: <87wo1ncbca.fsf@gnus.org> References: <87egov3udi.fsf@moondust.localdomain> <87zj7ix55f.fsf@moondust.localdomain> <87bnjy9tn2.fsf@moondust.localdomain> <878uf2dmow.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23843"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 20092@debbugs.gnu.org, "N. Jackson" , Stefan Monnier To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 25 11:41:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAVS7-00065v-OY for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Aug 2020 11:41:15 +0200 Original-Received: from localhost ([::1]:47992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAVS6-0008Uj-8j for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Aug 2020 05:41:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAVRv-0008UP-OP for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2020 05:41:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48767) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAVRu-0008TR-AN for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2020 05:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kAVRu-0002bw-7S for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2020 05:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Aug 2020 09:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20092 X-GNU-PR-Package: emacs Original-Received: via spool by 20092-submit@debbugs.gnu.org id=B20092.159834845910016 (code B ref 20092); Tue, 25 Aug 2020 09:41:02 +0000 Original-Received: (at 20092) by debbugs.gnu.org; 25 Aug 2020 09:40:59 +0000 Original-Received: from localhost ([127.0.0.1]:60312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAVRr-0002bU-JS for submit@debbugs.gnu.org; Tue, 25 Aug 2020 05:40:59 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:39102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAVRo-0002bB-TH for 20092@debbugs.gnu.org; Tue, 25 Aug 2020 05:40:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lVQRKNFpBSoV3b2A1df2kjryzKNOeTDi6JadeGFLmUQ=; b=QITQfWql4G9LBiptk4Isd6EJUW uqY6Kxu/UhOSL4R/9lVSS79KuWwuD6HwVmEw5KT+q9E4DpbToDMfcQkY4z2+gG8KwH78OU7lqr/sB Gy5PTp9glM7DMi7Etq1wMFjOFoYWKOdZ3s4SYL5fScPi/9JxpuInU2bdZ4IEQ2ucgSEc=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAVRX-0003q5-B6; Tue, 25 Aug 2020 11:40:49 +0200 X-Now-Playing: Orchestral Manoeuvres in the Dark's _Souvenir (3): Unreleased Archives Vol 1_: "Radio Swiss International" In-Reply-To: <878uf2dmow.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 12 Mar 2015 21:45:33 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186245 Archived-At: Juri Linkov writes: > Since Info doesn't open invisible text, then maybe `Info-mode' should > set the buffer-local value of `search-invisible' to nil? > > diff --git a/lisp/info.el b/lisp/info.el [...] > + (setq-local search-invisible nil) Makes sense to me, but this was never applied? >> I'm not sure what's the best and/or simplest way to fix it. >> Maybe a first step would be to emit a message explaining that the match >> is inside hidden text (at least so the user gets a clue about what's >> going on). [...] > Or maybe better in the message suffix? > > diff --git a/lisp/isearch.el b/lisp/isearch.el > index 191ec82..4bc2129 100644 > --- a/lisp/isearch.el > +++ b/lisp/isearch.el > @@ -2544,6 +2545,7 @@ (defun isearch-message-suffix (&optional c-q-hack) > (if isearch-error > (concat " [" isearch-error "]") > "") > + (if isearch-hidden " [hidden]" "") > (or isearch-message-suffix-add ""))) I think that would be a good idea, but I tried the patch, and I could never get it to actually show the [hidden] suffix. I tried debugging this, but... it seems like isearch-hidden is never set? At least not in my test cases here? Is there another bug in this area? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no