From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 13884@debbugs.gnu.org
Subject: bug#13884: 24.3.50; `mouse-secondary-save-then-kill' should not affect the kill ring (+ regression)
Date: Sun, 06 Dec 2020 20:03:52 +0100 [thread overview]
Message-ID: <87wnxurc2v.fsf@gnus.org> (raw)
In-Reply-To: <65E5B3EECB024BECBFE64DDE1C8CCFF7@us.oracle.com> (Drew Adams's message of "Tue, 5 Mar 2013 15:19:52 -0800")
"Drew Adams" <drew.adams@oracle.com> writes:
> Prior to Emacs 24, if you clicked `M-mouse-3' without first clicking
> `M-mouse-1' you got a "Wrong buffer" error msg informing you that the
> secondary selection was not in this buffer. That was consistent and
> reasonable behavior.
>
> Starting with Emacs 24, if you do that Emacs moves the secondary
> selection to the current buffer, from point to the clicked position.
>
> 1. It could be argued that this is a regression, especially as:
(I think it's too late to change how this works at this point.)
> 2. Be that as it may, if this behavior is to remain, there is
> nevertheless the following bug, the main purpose of this report: In this
> case (no start of secondary selection in current buffer, so using point
> as the start position), the code mistakenly does this, in addition to
> doing what it needs to do to establish the secondary selection:
>
> (kill-ring-save (point) click-pt)
>
> That code is a vestige, presumably. In any case, it has no business
> being there. Setting the secondary selection should not in any way
> affect the `kill-ring'. The secondary selection is entirely separate
> from the region and the kill ring. This sexp should be removed.
The doc string says:
----
Set the secondary selection and save it to the kill ring.
----
So this is presumably intended behaviour. Closing.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2020-12-06 19:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 23:19 bug#13884: 24.3.50; `mouse-secondary-save-then-kill' should not affect the kill ring (+ regression) Drew Adams
2020-12-06 19:03 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnxurc2v.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=13884@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).