From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#46364: regression in lm-commentary Date: Mon, 08 Feb 2021 07:39:54 +0100 Message-ID: <87wnvjm5ad.fsf@gnus.org> References: <20210207140125.6rn7lfg33qnkb222@E15-2016.optimum.net> <87lfbzzpsm.fsf@gnus.org> <878s7z1urq.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24983"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , 46364@debbugs.gnu.org, Bruno =?UTF-8?Q?F=C3=A9lix?= Rezende Ribeiro To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 08 11:57:56 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l94Et-0006NN-WE for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Feb 2021 11:57:56 +0100 Original-Received: from localhost ([::1]:59916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l94Eo-0001S3-VH for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Feb 2021 05:57:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l90Eb-0003a4-4V for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 01:41:28 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l90EI-0000Um-A6 for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 01:41:10 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l90EI-000789-7x for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 01:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2021 06:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46364 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 46364-submit@debbugs.gnu.org id=B46364.161276642227312 (code B ref 46364); Mon, 08 Feb 2021 06:41:02 +0000 Original-Received: (at 46364) by debbugs.gnu.org; 8 Feb 2021 06:40:22 +0000 Original-Received: from localhost ([127.0.0.1]:49481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l90Dd-00076S-WE for submit@debbugs.gnu.org; Mon, 08 Feb 2021 01:40:22 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:44110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l90DN-00075C-9S for 46364@debbugs.gnu.org; Mon, 08 Feb 2021 01:40:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jO6WJG/buo3Y0rk+uVuj4Pui34DHbwgAfEcYJoR+qJ0=; b=LeAzwY6AMQNXYbe73n4xqZHOQ6 DvMEvC5qggYODRgzEVPR4auXdVRmESUvvOzpL+0ZWFN704R5pJ9diunv5XqUo6sau0rFDW6Giba6X JfhwfLAbu7TYZsTc6IkFzlqbRMd4Rllgz4bO9ykzWdIjFMSnYLVxf/LMhK2xJHmmnflc=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l90DE-00023N-5J; Mon, 08 Feb 2021 07:39:58 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEVONSCYbDjGnVzo w4/////FvwTCAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UCCAYAF7J3omsAAAGiSURBVDjLZVSJccQw CASnAcE1YFADkdx/b1nQY/viyUQMK2BZ0BEVFilMhEP8VJ8ficE2YOkylfmR93pdHS4cMD4Bi7CQ WlzMv4ywvM8WuWl+UWwYhcKJC2XW6CNVFk+EVvG2WF0ZiWoohdo3kBGUxYNVUgijXkR3aUWkScao b/dgER0E40E1RJH4N5gISnvP2xytzVtxSWcNlkhbdjWU0Wt3KshII1sWG3cKF9YQcZCRHc1O2Yav CBoG1xp9X2e1slOFVa/0A0gKyZ6Q9cCcEmg+IrIn/6UDU+w5wAkEf5JPCaB5qzHx1YiTSzuq1waF VA6jHQFJDzuPBrsaPwDSzn6yCYosgHJ9xFhDEhCzpUTSdWG3GFMFUGjTZTlZ4wAVWxotEcVKyvDw L9Ei12MgW3Z9eOfsbxYPQNdewXwBsVvLLnu1ie9NjLXiaRWI/QAADQFZ2N8A1MzHIpD6DaDgSXvZ b+Do8RTjNX4BKrnNRnn4TVJyIR/HluENLPY8gTzs1gp+15kcB5jrouTz/X/R/fF/3+oaSSLRNyDx o2Mx9o39AQbITJimC/42AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTAyLTA4VDA2OjAwOjIzKzAw OjAwzztZsQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wMi0wOFQwNjowMDoyMyswMDowML5m4Q0A AAAASUVORK5CYII= X-Now-Playing: Bob Dylan's _Blonde On Blonde_: "4th Time Around" In-Reply-To: (Matt Armstrong's message of "Sun, 07 Feb 2021 16:19:14 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199589 Archived-At: Matt Armstrong writes: > The issue is a behavior change in `lm-commentary' that probably deserves > some consideration, because it seems suboptimal in this example. The > behavior change is most likely caused by commit > 963a9ffd66cb29f0370e9a4b854dddda242c54a6. Right. The rationale was: > I decided to tackle the problem=E2=80=99s root. After figuring out that = every > function depending on =E2=80=98lm-commentary=E2=80=99 implemented their o= wn ad-hoc > sanitation for the same effect, I changed =E2=80=98lm-commentary=E2=80=99= to return a > sanitized string and removed the code/functionality duplication from all > callers. (I've added Bruno to the CCs.) > Prior to that commit, and in Emacs 27.1, the function returns the file's > commentary as an verbatim substring of the elisp source, including the > elisp comment characters, commentary headline, etc. E.g. a string like > this (I'll quote the string for email sanity): [...] > It seems `lm-commentary' now strips all leading whitespace from every > line, as a "sanitization" step, and this has the unsatisfying side > effect of ruining any indentation formatting in the original commentary. Is the removal of the leading white-space the only problem with the sanitization? Then perhaps that bit could be tweaked? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no