From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#46364: regression in lm-commentary Date: Mon, 08 Feb 2021 20:51:12 +0000 Message-ID: <87wnviqo5b.fsf@tcd.ie> References: <20210207140125.6rn7lfg33qnkb222@E15-2016.optimum.net> <87lfbzzpsm.fsf@gnus.org> <878s7z1urq.fsf@tcd.ie> <87wnvjm5ad.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28001"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46364@debbugs.gnu.org, Lars Ingebrigtsen , Bruno =?UTF-8?Q?F=C3=A9lix?= Rezende Ribeiro To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 09 00:43:26 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9GBi-0007Aq-4R for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Feb 2021 00:43:26 +0100 Original-Received: from localhost ([::1]:35440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9GBh-0001M0-32 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Feb 2021 18:43:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9DVr-0002lW-0T for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 15:52:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40469) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9DVp-0008LV-Jh for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 15:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9DVp-0003qG-IY for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 15:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2021 20:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46364 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 46364-submit@debbugs.gnu.org id=B46364.161281748214711 (code B ref 46364); Mon, 08 Feb 2021 20:52:01 +0000 Original-Received: (at 46364) by debbugs.gnu.org; 8 Feb 2021 20:51:22 +0000 Original-Received: from localhost ([127.0.0.1]:52015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9DVC-0003pC-Id for submit@debbugs.gnu.org; Mon, 08 Feb 2021 15:51:22 -0500 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:39785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9DVA-0003oy-Mc for 46364@debbugs.gnu.org; Mon, 08 Feb 2021 15:51:21 -0500 Original-Received: by mail-wr1-f43.google.com with SMTP id h12so2554294wrw.6 for <46364@debbugs.gnu.org>; Mon, 08 Feb 2021 12:51:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=3A1oLi2nMelyy7terV7TUGp6vu5RGCQcQFMP97nNvYQ=; b=I7fjQCTdPL80/oDKlEv4cNPoOGsQIR2WW7eKKW1nGhI0aTJpzI9ycJb7bq5zO4lqXS b4HPwzJcQAgkyKWBXzlkNJAuTvPt8CjgnWRcIbltJGTup26JfCqsWd7KLNxArVd9lQuT amvZImQ4EVdhFpPGMYgXDcbpDFC2/F2nbG/nN0VUHwUwtTrYOI5h/ttQJp6KDZx8rcbO tRye5OY0qZe0lKLB/tJck1EBidsn9c5HNnht4i0V2HqQprVAC1OLXpmu5l7uqXYhFTRo H6JE260N3/3bzCk/aFnuJaDJwfgLKdG1mHKJIA4OEiq9iuT8x908MLdnpKNgPH1m6OSn 6K1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=3A1oLi2nMelyy7terV7TUGp6vu5RGCQcQFMP97nNvYQ=; b=GZ87DKu4hL+DtRukTOS79l6pL9P38ax+SdCQr5jBTdZU6nEU+GDbq4pHCbNdOmWR8x HMdduMSow7NcqT6KEaKPQJbJvnnC2H0Zav60np8tYOVXFyOg3IncTnk/gMnD+C7VPjER 5h7xn++3Xw0vRTTp0nHem/unFTRg7Ofm08Dlg8wARx3ebALncw9Wy8czXYkmkHs7crnL QCFl3KZLjHZ8XcS9vM6e/3IsEOjjRzDnpyY4sTI8hjw2y2wiVTyQoiyVJ1eF4ECDvccK et2cs87tHZ4ODLGzb+vycseV8DAPt2BEljnACIAymYSeSmEv+8eRhNaQWiykjaTLCBMw n6sw== X-Gm-Message-State: AOAM5314etuVo2sq8Cc6t1yzNfQrR6s/e0ZUCeMGcs3dAa4vCDnD/ZEP 9xtIONAh5/fIyUtvEgOf4kcNHQ== X-Google-Smtp-Source: ABdhPJycgdXCCCWV55MefKZ2G8sPoNb69hplaiJ/1NWBONk0cm4d/u/TlW/XQw9J5z5V+iauUd6SLQ== X-Received: by 2002:a05:6000:2aa:: with SMTP id l10mr21757709wry.368.1612817474870; Mon, 08 Feb 2021 12:51:14 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id k6sm33648969wro.27.2021.02.08.12.51.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 12:51:13 -0800 (PST) In-Reply-To: (Matt Armstrong's message of "Mon, 08 Feb 2021 10:59:28 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199639 Archived-At: Matt Armstrong writes: > Lars Ingebrigtsen writes: > >> Matt Armstrong writes: > > [...] > >>> It seems `lm-commentary' now strips all leading whitespace from every >>> line, as a "sanitization" step, and this has the unsatisfying side >>> effect of ruining any indentation formatting in the original commentary. >> >> Is the removal of the leading white-space the only problem with the >> sanitization? Then perhaps that bit could be tweaked? > > I noticed that Basil's commit 963a9ffd66cb29f0370e9a4b854dddda242c54a6 ^^^^^^^ Bruno's ;) > consolidated normalization logic but also changed the regex slightly > such that all leading whitespace was erased. I've attached a patch to go > back to the old ways. It seems to work. Given that lm-commentary is used outside of Emacs, I suggest its behaviour be reverted to that in Emacs 27, and any sanitisation provided as a separate function instead. Thanks, -- Basil