From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#46396: 27.1.90; Ediff's non-focused diff section, background too light in --reverse Date: Wed, 10 Feb 2021 21:39:35 +0200 Organization: LINKOV.NET Message-ID: <87wnvfwwfg.fsf@mail.linkov.net> References: <87blcs2f9q.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14154"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 46396@debbugs.gnu.org To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 10 20:41:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9vML-0003ZL-As for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Feb 2021 20:41:09 +0100 Original-Received: from localhost ([::1]:60790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9vMK-0006nd-Ci for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Feb 2021 14:41:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9vMD-0006nB-Uz for bug-gnu-emacs@gnu.org; Wed, 10 Feb 2021 14:41:01 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45721) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9vMD-0001vh-O4 for bug-gnu-emacs@gnu.org; Wed, 10 Feb 2021 14:41:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9vMD-00054x-Li for bug-gnu-emacs@gnu.org; Wed, 10 Feb 2021 14:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Feb 2021 19:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46396 X-GNU-PR-Package: emacs Original-Received: via spool by 46396-submit@debbugs.gnu.org id=B46396.161298605719499 (code B ref 46396); Wed, 10 Feb 2021 19:41:01 +0000 Original-Received: (at 46396) by debbugs.gnu.org; 10 Feb 2021 19:40:57 +0000 Original-Received: from localhost ([127.0.0.1]:57265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9vM8-00054Q-NT for submit@debbugs.gnu.org; Wed, 10 Feb 2021 14:40:56 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:39899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9vM5-000548-RU; Wed, 10 Feb 2021 14:40:55 -0500 X-Originating-IP: 91.129.108.204 Original-Received: from mail.gandi.net (m91-129-108-204.cust.tele2.ee [91.129.108.204]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 363E0FF804; Wed, 10 Feb 2021 19:40:45 +0000 (UTC) In-Reply-To: (Matt Armstrong's message of "Wed, 10 Feb 2021 10:24:05 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199795 Archived-At: tags 46396 fixed close 46396 28.0.50 thanks >> Do you see more problems with the following patch? > > Juri, this is a definite improvement, thank you. Committing it as it is > seems reasonable since it makes unreadable text readable again. Thanks for confirming, now committed to master for Emacs 28. > I applied this patch and played around with applying various light and > dark themes. > > Some comments: > > In the "tango-dark" theme: > > a) the non-current diff backgrounds are quite close to the theme's dark > background color, so they are not very noticeable. > b) the current diff (such as `ediff-current-diff-B`) is also quite close > to the theme's background color. > > In the "tango-light" theme: > > c) `ediff-current-diff-A' is quite dark (a darker blue/purple), and the > foreground color is hard to read over it. This is a little odd, > because `ediff-current-diff-B' is a fairly bright yellow background. > > I saw similar issues in the various other standard themes (loading up > the mater branch with src/emacs -Q). > > The issues I see with ediff-current-* faces are arguably a tangent to > this bug. Perhaps those faces could use :distant-foreground as well, for > similar reasons? I'm not sure if it's possible to find such default colors that would work well for all standard themes. But there is no need to use :distant-foreground in themes, because the authors of themes can find the right combination of the default/ediff colors and adjust their themes accordingly. > As for the background colors possibly being quite similar to the theme's > background, I'm not sure what to do about that. Implementing something like :distant-background is less important than :distant-foreground, because :distant-foreground is important to make the text readable, while :distant-background would only help making the background color differ from the default background color.