From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Miha =?UTF-8?Q?Rihtar=C5=A1i=C4=8D?= Newsgroups: gmane.emacs.bugs Subject: bug#46727: 27.1; Only the first function from prefix-command-echo-keystrokes-functions is used Date: Tue, 23 Feb 2021 21:44:29 +0100 Message-ID: <87wnuy1ple.fsf@miha-pc> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12791"; mail-complaints-to="usenet@ciao.gmane.io" To: 46727@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 23 21:45:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lEeYZ-0003EH-HZ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Feb 2021 21:45:19 +0100 Original-Received: from localhost ([::1]:35308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEeYY-0002AZ-JQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Feb 2021 15:45:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEeWN-0000pj-0i for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2021 15:43:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49159) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lEeWM-0002Po-PB for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2021 15:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lEeWM-00089H-NS for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2021 15:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Miha =?UTF-8?Q?Rihtar=C5=A1i=C4=8D?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Feb 2021 20:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 46727 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.161411297231305 (code B ref -1); Tue, 23 Feb 2021 20:43:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Feb 2021 20:42:52 +0000 Original-Received: from localhost ([127.0.0.1]:60705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEeWC-00088r-8L for submit@debbugs.gnu.org; Tue, 23 Feb 2021 15:42:52 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:60410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEeUm-00086P-9V for submit@debbugs.gnu.org; Tue, 23 Feb 2021 15:41:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEeUm-0008Ge-23 for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2021 15:41:24 -0500 Original-Received: from mail.kamnitnik.top ([2001:19f0:5001:bf2:5400:2ff:fee0:2626]:38644) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEeUj-0001dj-Jo for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2021 15:41:23 -0500 Original-Received: from localhost (BSN-77-156-43.static.siol.net [193.77.156.43]) by mail.kamnitnik.top (Postfix) with ESMTPSA id 94A412045E for ; Tue, 23 Feb 2021 20:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kamnitnik.top; s=mail; t=1614112877; bh=UaE0hY4SWoKidE05RhThyta+hWLr679prsDo6CSscBc=; h=From:To:Subject:Date:From; b=AwY4/LuWj5q3A4Q2Hx3Mx1JLogsPkjkUiwyDC7Dq+Ptat9GoXNjBo1+0F1HXUbKdv YgD1W4XYhBftGtVBs3ok2Z0Fck47sKLkp/t7EdaX42hYlwwMsI6Y0x0bcsy4JgTZff xseTe6/ugP0STBBPQdoUvj6EEd/FkNxZEu3clCPyt8nY2CLgydIXjDQGCXeWxPROIl MmYrNZnJJkmNKq4XPh3y1NvsfmFPVl8kSB6H0JkCrT5TmRyDl9IFGMIB8kHEgr81tm Cm0QUI2L2TbrdgNPcw03JHZEvjxZLPXeMRXTASuSjWqOUdrQe+xcFVQde+lKK2nJcd /qoonbLr4/FGg== Received-SPF: pass client-ip=2001:19f0:5001:bf2:5400:2ff:fee0:2626; envelope-from=miha@kamnitnik.top; helo=mail.kamnitnik.top X-Spam_score_int: 11 X-Spam_score: 1.1 X-Spam_bar: + X-Spam_report: (1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.499, FROM_SUSPICIOUS_NTLD_FP=0.735, PDS_OTHER_BAD_TLD=1.967, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 23 Feb 2021 15:42:51 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200683 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Greetings. Looking at the function internal-echo-keystrokes-prefix, it is heavily implied that all functions from `prefix-command-echo-keystrokes-functions` should be used and their return values concatenated. This isn't the case, however, because `run-hook-wrapped` aborts on first non-nil returned value. The following simple patch fixes this. diff --git a/lisp/simple.el b/lisp/simple.el index 1dfc3374ad..403861351c 100644 =2D-- a/lisp/simple.el +++ b/lisp/simple.el @@ -4670,7 +4670,7 @@ internal-echo-keystrokes-prefix (setq prefix-command--last-echo (let ((strs nil)) (run-hook-wrapped 'prefix-command-echo-keystrokes-functions =2D (lambda (fun) (push (funcall fun) strs))) + (lambda (fun) (push (funcall fun) strs) nil)) (setq strs (delq nil strs)) (when strs (mapconcat #'identity strs " ")))))) =20 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCAAxFiEEmxVnesoT5rQXvVXnswkaGpIVmT8FAmA1aS0THG1paGFAa2Ft bml0bmlrLnRvcAAKCRCzCRoakhWZP48AD/4v2hlzs3sKP9MH9PTqfvh0AHPcXKPl w41Oaq9Oo/NWH7i6bUOVs7tfiLVeg+oa86wSQKKG7+Hjq3VUZvJmynNcjH/gVuFl FGasBfOlhDjQrX7Y8nkbTUTvht/Yhoa56gq7QYZBKTlDLjqfP3lphZUM3FUosHcl 28fKWcfx2SLXI8N8uz2PstUqC3+MWxyC3GxlNGhMewA5xZGymbhs0qLSrFjPdtRF CGKqKztwvioIMcPMFvYgLZQOfbQI7mZhPKrETdahyNxmrUjzWJAl8KGB2i1p1CoT cuzSrtDJhbn4w/tNLzg4c8yizzyhTKBvfD/LtGpxDP0kKP4iHRyI9XBnyUBx7Lw1 cx//5aiXYOMwxRPlEBcu6vBpDCpsbFML3RRgje9WKgtVtSzXF3YMlF4Tf9n+JKQ3 Y23AdGmT7HTfSAGvqOqn1hzIScVWNjWrivYLQThpGjZpRpF2mR+F/i+X3RIio8Kw mqyVqywVb8/7c3fjzNUqVeq7Y9ym/Q97f1zTp9H3NW2zAEptQ8LD771uOc8Iu+me r2QR6dtV4PiUuTldHuZU5CwVkpsU0IgqBW12HqTze2P5zOhv3OrnDkrvXEuYFc5e VVzDt0L0RUmSdRI2Mfi/Oeg7H/rlQf952gkXEliPfp8f94yZctNvGVHCApIy21WF tJx4Lxg/o6JJ4w== =G5Jv -----END PGP SIGNATURE----- --=-=-=--