From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#46727: 27.1; Only the first function from prefix-command-echo-keystrokes-functions is used Date: Wed, 24 Feb 2021 17:42:03 +0100 Message-ID: <87wnux76zo.fsf@gnus.org> References: <87wnuy1ple.fsf@miha-pc> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12906"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46727@debbugs.gnu.org To: Miha =?UTF-8?Q?Rihtar=C5=A1i=C4=8D?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 24 17:43:38 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lExGE-0003FN-4a for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Feb 2021 17:43:38 +0100 Original-Received: from localhost ([::1]:38994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lExGD-0002iF-6p for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Feb 2021 11:43:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lExFd-0002hJ-RT for bug-gnu-emacs@gnu.org; Wed, 24 Feb 2021 11:43:01 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52391) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lExFd-00026u-Kb for bug-gnu-emacs@gnu.org; Wed, 24 Feb 2021 11:43:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lExFd-0002th-I2 for bug-gnu-emacs@gnu.org; Wed, 24 Feb 2021 11:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Feb 2021 16:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46727 X-GNU-PR-Package: emacs Original-Received: via spool by 46727-submit@debbugs.gnu.org id=B46727.161418493711074 (code B ref 46727); Wed, 24 Feb 2021 16:43:01 +0000 Original-Received: (at 46727) by debbugs.gnu.org; 24 Feb 2021 16:42:17 +0000 Original-Received: from localhost ([127.0.0.1]:35701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lExEv-0002sY-7Q for submit@debbugs.gnu.org; Wed, 24 Feb 2021 11:42:17 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:44080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lExEs-0002sJ-EL for 46727@debbugs.gnu.org; Wed, 24 Feb 2021 11:42:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PmP2RhGiTMU9RTn1nn0BLPzbVinCln7/QSK4ByKiE9o=; b=BmPtNQSQVG9v3oBS6EJZ29SEFM rFtFkKxl9UvDJDuTNzMWvV4cTG3rkfrrSxb7YA2QMsuuzQSe5jgXQ+8ije14P5fyRWUvIeyvUUKz2 oE8f15IK12owjMTMxYWA3qILdWxw5F+FQYB8pCz6AaNQNcWsBXTjXrAOYNSQyuu1bawA=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lExEi-0005pc-Tm; Wed, 24 Feb 2021 17:42:07 +0100 X-Now-Playing: Moor Mother & billy woods's _BRASS_: "Furies" In-Reply-To: <87wnuy1ple.fsf@miha-pc> ("Miha =?UTF-8?Q?Rihtar=C5=A1i=C4=8D?="'s message of "Tue, 23 Feb 2021 21:44:29 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200736 Archived-At: Miha Rihtar=C5=A1i=C4=8D writes: > Greetings. > > Looking at the function internal-echo-keystrokes-prefix, it is heavily > implied that all functions from > `prefix-command-echo-keystrokes-functions` should be used and their > return values concatenated. This isn't the case, however, because > `run-hook-wrapped` aborts on first non-nil returned value. The following > simple patch fixes this. [...] > (run-hook-wrapped 'prefix-command-echo-keystrokes-functions > - (lambda (fun) (push (funcall fun) strs))) > + (lambda (fun) (push (funcall fun) strs) ni= l)) Thanks. I poked around in the code, and I think your interpretation here must be correct, and I've applied your patch to Emacs 28. (Besides, `push' has an undefined return value... and always returns non-nil, so the old code would, as you said, never use more than the first function in `prefix-command-echo-keystrokes-functions'.) This change was small enough to apply without assigning copyright to the FSF, but for future patches you want to submit, it might make sense to get the paperwork started now, so that subsequent patches can be applied speedily. Would you be willing to sign such paperwork? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no