From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Date: Thu, 04 Mar 2021 02:04:41 +0000 Message-ID: <87wnunbrnq.fsf@tcd.ie> References: <87im9fgm27.fsf@protesilaos.com> <83im9814oh.fsf@gnu.org> <87sg6po0yd.fsf_-_@protesilaos.com> <83czxt2fpd.fsf@gnu.org> <87h7m0n0em.fsf@protesilaos.com> <83v9agryuz.fsf@gnu.org> <87tupyw83e.fsf@protesilaos.com> <83zgzqncxx.fsf@gnu.org> <874khwn1qf.fsf@protesilaos.com> <603b8171.1c69fb81.aa664.7f40@mx.google.com> <87mtvoxsvs.fsf@protesilaos.com> <603b9b9d.1c69fb81.f37aa.cb7c@mx.google.com> <83eegz7xcx.fsf@gnu.org> <87o8g3exjv.fsf@protesilaos.com> <603d053a.1c69fb81.f4cb8.fb14@mx.google.com> <87h7luga3p.fsf@protesilaos.com> <87o8g2bg89.fsf@tcd.ie> <87r1kyrtrl.fsf@protesilaos.com> <878s75x2uk.fsf@tcd.ie> <87o8g0ryfz.fsf@tcd.ie> <871rcw8631.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27287"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Mauro Aranda , 45068@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 04 03:05:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHdMk-00070C-OX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 03:05:26 +0100 Original-Received: from localhost ([::1]:44438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHdMj-0003eL-QG for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Mar 2021 21:05:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHdMM-0003dK-Gb for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 21:05:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45779) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHdMM-0003V2-8z for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 21:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHdMM-0008CI-2r for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 21:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Mar 2021 02:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.161482349131491 (code B ref 45068); Thu, 04 Mar 2021 02:05:02 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 4 Mar 2021 02:04:51 +0000 Original-Received: from localhost ([127.0.0.1]:57325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHdMB-0008Br-7O for submit@debbugs.gnu.org; Wed, 03 Mar 2021 21:04:51 -0500 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:54109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHdMA-0008Bc-3S for 45068@debbugs.gnu.org; Wed, 03 Mar 2021 21:04:50 -0500 Original-Received: by mail-wm1-f53.google.com with SMTP id e23so6662716wmh.3 for <45068@debbugs.gnu.org>; Wed, 03 Mar 2021 18:04:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+67WJXWtlYXW27ZKI5lw56JTKQ8/NrTFitO9HRqO5ws=; b=U5xcnabk+cC1ckiifwEGe2DlO/kYigGJZwXnVxRwz6IsPg4SP2Q9mXE3MndOutn+rv DKlGTaJbqUeoSBl/eh7Qy25qRbbcOJvrqeWfWfYeJF1mp9w0cCJ6w/UjRCMFrOPGJxGS oxxLzjyx2xvFcZGScLe+Fm6Uav93hz2PsN0Xrsl3v1msRu3jb8pI2TEJJI81qpmLeX5m wP2fFdJq3Jm0aj5a43dfSlOR7xZ3AKFTntrhISVvLtkCu+yxaJ1gBkGyaZEUalUULjDu uUtwLg3msxdOmX6EPKE8QOqD+MYxzQjKc4cPgAG5hqDebLtaLnUQSH7tv3aGgrh+bmMC 7dVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+67WJXWtlYXW27ZKI5lw56JTKQ8/NrTFitO9HRqO5ws=; b=DdaGMNSnz9+/vKsQ2s1pSikaL/0ceSpQXtqrEDIT3D0mxufZkU9UIHzo7ZHblKjT6x O314IRG9vZaVoWdMr9JJq7LRU2b9WZ6lkDuYZQOutxs4dTZ7zyHU2BD2kWTpKDDaxgC+ EI0D3yEW5hh+fCpabbNZhAJqBhKFnaQ+5uZS1UvejvBYngnH/67Z4Vds+KiMV+gL2g5u KclamADTQPT/M2XJwDfqEjXIH5tX37NITm4wGHDNHd5TtX0wW1CDKFxSKYaxejB9rqa7 nmghG5w2tXfvKG3UU/LmCWwG61zU2QP0EjQ81q+Ec3DCdWDIalofJg/f5Q5UFmkgxn3J 7Q1Q== X-Gm-Message-State: AOAM5310INPQvwIV6SjLvajDupRWb128NyU8eHhiTgH6fENLv+F7k18R /zhAHLXr6vhDQ61/R1ExjZp2zA== X-Google-Smtp-Source: ABdhPJyL2PKImmW6Bu7iCvhzq8FuGy36KY/I1pwi9637F3XZt62NZ/POCBOvHwk5J8ZHWDe61HCFeA== X-Received: by 2002:a7b:cb90:: with SMTP id m16mr1453402wmi.162.1614823484376; Wed, 03 Mar 2021 18:04:44 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id u4sm32674967wrr.37.2021.03.03.18.04.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 18:04:43 -0800 (PST) In-Reply-To: <871rcw8631.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Wed, 03 Mar 2021 20:06:42 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201349 Archived-At: Protesilaos Stavrou writes: > I applied it and it works for what I want to do. The decoupling feels > more appropriate. Thanks for reviewing it. > The major difference I see between evaluating 'require-theme' and > 'require' forms is that the latter errors with a backtrace buffer, while > the former logs a message. > > Compare those: > > (require 'give-me-error) > (require-theme 'give-me-error) Hm, how are you evaluating them? Here's what I tried: 0. ./src/emacs -Q 1. (require 'give-me-error) C-j Debugger entered--Lisp error: (file-missing "Cannot open load file" "No such file or directory" "give-me-error") require(give-me-error) (progn (require 'give-me-error)) eval((progn (require 'give-me-error)) t) elisp--eval-last-sexp(t) eval-last-sexp(t) eval-print-last-sexp(nil) funcall-interactively(eval-print-last-sexp nil) call-interactively(eval-print-last-sexp nil nil) command-execute(eval-print-last-sexp) 2. q 3. (require-theme 'give-me-error) C-j Debugger entered--Lisp error: (file-missing "Cannot open load file" "No such file or directory" "give-me-error") require(give-me-error) require-theme(give-me-error) (progn (require-theme 'give-me-error)) eval((progn (require-theme 'give-me-error)) t) elisp--eval-last-sexp(t) eval-last-sexp(t) eval-print-last-sexp(nil) funcall-interactively(eval-print-last-sexp nil) call-interactively(eval-print-last-sexp nil nil) command-execute(eval-print-last-sexp) The patch implements require-theme in terms of require, so even the error symbol and data should be identical. > At any rate, tomorrow I will share with you the new version of my themes > and their manual. I look forward to it. Thanks, -- Basil