From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#48478: 28.0.50; yank-from-kill-ring and kill-ring-yank-pointer Date: Mon, 31 May 2021 01:32:15 +0300 Organization: LINKOV.NET Message-ID: <87wnrfx380.fsf@mail.linkov.net> References: <83h7j1twym.fsf@gnu.org> <874kf1yq92.fsf@mail.linkov.net> <83o8d8s1jd.fsf@gnu.org> <878s4bzt6v.fsf@mail.linkov.net> <83fsyjqwtr.fsf@gnu.org> <87h7iyn0s5.fsf@mail.linkov.net> <831ra1px7n.fsf@gnu.org> <875yzdb7vz.fsf@mail.linkov.net> <83lf89ns51.fsf@gnu.org> <87eee19o24.fsf@mail.linkov.net> <83fsyhnp2r.fsf@gnu.org> <871ra19luh.fsf@mail.linkov.net> <83cztkocqt.fsf@gnu.org> <87h7iwuf0m.fsf@mail.linkov.net> <83o8d3l179.fsf@gnu.org> <87k0nqo570.fsf@mail.linkov.net> <83a6olkjca.fsf@gnu.org> <87pmxe649v.fsf@mail.linkov.net> <835yz5bszn.fsf@gnu.org> <87y2c1yvqq.fsf@mail.linkov.net> <835yz4ab0s.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30389"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 48478@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 31 00:39:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnU5b-0007gM-QM for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 May 2021 00:39:23 +0200 Original-Received: from localhost ([::1]:52010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnU5a-0003r6-QJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 May 2021 18:39:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnU5H-0003nv-KM for bug-gnu-emacs@gnu.org; Sun, 30 May 2021 18:39:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49018) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lnU5H-0002wJ-DA for bug-gnu-emacs@gnu.org; Sun, 30 May 2021 18:39:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lnU5H-0007qZ-9h for bug-gnu-emacs@gnu.org; Sun, 30 May 2021 18:39:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 May 2021 22:39:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48478 X-GNU-PR-Package: emacs Original-Received: via spool by 48478-submit@debbugs.gnu.org id=B48478.162241432130121 (code B ref 48478); Sun, 30 May 2021 22:39:03 +0000 Original-Received: (at 48478) by debbugs.gnu.org; 30 May 2021 22:38:41 +0000 Original-Received: from localhost ([127.0.0.1]:60562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnU4v-0007pl-Iu for submit@debbugs.gnu.org; Sun, 30 May 2021 18:38:41 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:40703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnU4l-0007ox-CG for 48478@debbugs.gnu.org; Sun, 30 May 2021 18:38:31 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 511E81BF203; Sun, 30 May 2021 22:38:23 +0000 (UTC) In-Reply-To: <835yz4ab0s.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 May 2021 10:30:59 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207647 Archived-At: >> When read-from-kill-ring returns an edited string, >> how yank-from-kill-ring could use it to adjust kill-ring-yank-pointer? > > read-from-kill-ring could store the pointer in some variable, I guess? There is no way to get the pointer to point to the entry of the kill ring, because we can't find the edited string in the kill ring. >> > yank-from-kill-ring is a new function, and its return value isn't >> > documented. So you could change it to return kill-ring-yank-pointer >> > instead, and then yank-pop could move it. >> >> I don't understand what value of kill-ring-yank-pointer >> should be returned: its old value or some modified value? > > It depends on whether we add the edited string to the kill ring or > not. Currently, we don't add it, so I think the value should be that > of the unedited entry in the kill ring. The minibuffer returns only the edited entry that we can't use to find the unedited entry in the kill ring. >> BTW, the recent fix in ef7a6eec20 broke such use case: >> M-w on some region, but then M-y M-p doesn't insert the last item >> to the minibuffer, i.e. the same item that is inserted to the buffer > > Sorry, I don't understand how does minibiffer enter the picture. Can > you show a complete recipe? M-y activates the minibuffer and uses its (HISTVAR . HISTPOS) to set the initial position for use by the minibuffer history to the entry pointed by kill-ring-yank-pointer. So this is similar to what C-y does when it yanks the same entry pointed by kill-ring-yank-pointer.