unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 48478@debbugs.gnu.org
Subject: bug#48478: 28.0.50; yank-from-kill-ring and kill-ring-yank-pointer
Date: Mon, 31 May 2021 01:32:15 +0300	[thread overview]
Message-ID: <87wnrfx380.fsf@mail.linkov.net> (raw)
In-Reply-To: <835yz4ab0s.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 May 2021 10:30:59 +0300")

>> When read-from-kill-ring returns an edited string,
>> how yank-from-kill-ring could use it to adjust kill-ring-yank-pointer?
>
> read-from-kill-ring could store the pointer in some variable, I guess?

There is no way to get the pointer to point to the entry of the kill ring,
because we can't find the edited string in the kill ring.

>> > yank-from-kill-ring is a new function, and its return value isn't
>> > documented.  So you could change it to return kill-ring-yank-pointer
>> > instead, and then yank-pop could move it.
>>
>> I don't understand what value of kill-ring-yank-pointer
>> should be returned: its old value or some modified value?
>
> It depends on whether we add the edited string to the kill ring or
> not.  Currently, we don't add it, so I think the value should be that
> of the unedited entry in the kill ring.

The minibuffer returns only the edited entry that
we can't use to find the unedited entry in the kill ring.

>> BTW, the recent fix in ef7a6eec20 broke such use case:
>> M-w on some region, but then M-y M-p doesn't insert the last item
>> to the minibuffer, i.e. the same item that is inserted to the buffer
>
> Sorry, I don't understand how does minibiffer enter the picture.  Can
> you show a complete recipe?

M-y activates the minibuffer and uses its (HISTVAR . HISTPOS)
to set the initial position for use by the minibuffer history
to the entry pointed by kill-ring-yank-pointer.  So this is similar
to what C-y does when it yanks the same entry pointed by kill-ring-yank-pointer.





  reply	other threads:[~2021-05-30 22:32 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 11:34 bug#48478: 28.0.50; yank-from-kill-ring and kill-ring-yank-pointer Eli Zaretskii
2021-05-17 14:35 ` Lars Ingebrigtsen
2021-05-17 21:10 ` Juri Linkov
2021-05-18 11:51   ` Eli Zaretskii
2021-05-18 20:24     ` Juri Linkov
2021-05-19  2:30       ` Eli Zaretskii
2021-05-19 16:31         ` Juri Linkov
2021-05-20  9:32           ` Eli Zaretskii
2021-05-20 18:02             ` Juri Linkov
2021-05-20 19:04               ` Eli Zaretskii
2021-05-20 19:56                 ` Juri Linkov
2021-05-20 20:10                   ` Eli Zaretskii
2021-05-20 20:44                     ` Juri Linkov
2021-05-21  5:51                       ` Eli Zaretskii
2021-05-21 18:18                         ` Juri Linkov
2021-05-22  6:41                           ` Eli Zaretskii
2021-05-22 20:59                             ` Juri Linkov
2021-05-23  7:19                               ` Eli Zaretskii
2021-05-25 20:35                                 ` Juri Linkov
2021-05-26 12:05                                   ` Eli Zaretskii
2021-05-26 22:09                                     ` Juri Linkov
2021-05-27  7:30                                       ` Eli Zaretskii
2021-05-30 22:32                                         ` Juri Linkov [this message]
2021-05-31 12:08                                           ` Eli Zaretskii
2021-05-31 20:20                                             ` Juri Linkov
2021-06-01 12:13                                               ` Eli Zaretskii
2021-06-01 20:32                                                 ` Juri Linkov
2021-06-02 14:57                                                   ` Eli Zaretskii
2021-06-02 21:10                                                     ` Juri Linkov
2021-06-03  6:19                                                       ` Eli Zaretskii
2021-06-03 20:55                                                         ` Juri Linkov
2021-06-04  5:57                                                           ` Eli Zaretskii
2021-06-04 16:46                                                             ` Juri Linkov
2021-06-04 19:04                                                               ` Eli Zaretskii
2021-06-05 21:35                                                                 ` Juri Linkov
2021-06-06  5:52                                                                   ` Eli Zaretskii
2021-06-06 20:52                                                                     ` Juri Linkov
2021-06-07 12:16                                                                       ` Eli Zaretskii
2021-06-08 16:55                                                                         ` Juri Linkov
2021-06-10 12:07                                                                           ` Eli Zaretskii
2021-06-11 17:10                                                                             ` Juri Linkov
2021-06-11 18:06                                                                               ` Eli Zaretskii
2021-06-11 18:33                                                                                 ` Juri Linkov
2021-06-11 19:23                                                                                   ` Eli Zaretskii
2021-06-11 19:16                                                                                 ` Eli Zaretskii
2021-05-30 22:23                   ` Juri Linkov
2021-05-31 12:04                     ` Eli Zaretskii
2021-05-31 20:17                       ` Juri Linkov
2021-06-01 12:12                         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnrfx380.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=48478@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).