From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#6399: Confirm vc commits when the files do not match those marked in vc-dir Date: Sun, 18 Jul 2021 15:10:45 +0200 Message-ID: <87wnpnrcmi.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40338"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 6399@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 18 15:11:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m56Zm-000AKb-6b for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Jul 2021 15:11:22 +0200 Original-Received: from localhost ([::1]:60944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m56Zk-0002nz-6L for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Jul 2021 09:11:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m56ZS-0002nq-GD for bug-gnu-emacs@gnu.org; Sun, 18 Jul 2021 09:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m56ZS-0002ox-8L for bug-gnu-emacs@gnu.org; Sun, 18 Jul 2021 09:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m56ZS-00028D-3q for bug-gnu-emacs@gnu.org; Sun, 18 Jul 2021 09:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jul 2021 13:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6399 X-GNU-PR-Package: emacs Original-Received: via spool by 6399-submit@debbugs.gnu.org id=B6399.16266138568177 (code B ref 6399); Sun, 18 Jul 2021 13:11:02 +0000 Original-Received: (at 6399) by debbugs.gnu.org; 18 Jul 2021 13:10:56 +0000 Original-Received: from localhost ([127.0.0.1]:55427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m56ZM-00027o-Id for submit@debbugs.gnu.org; Sun, 18 Jul 2021 09:10:56 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:34028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m56ZK-00027a-Sr for 6399@debbugs.gnu.org; Sun, 18 Jul 2021 09:10:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vhM7nl6iYlNqSbQvK8MOvSYnojuoS5KTEU2zlhnekmI=; b=XYHFVQHrJDO/OD3bgDHxrO/4az S2UteCRfqhpHcTWwou4v4jhiGSzLsHePP++9JOvDEeZSMnoX3KraWAiXUglPjxenUerynAzxDuwGl a4ilhFJc1Es9kD4/T7M6p9HFxtkHrjwcI0prj9odXelyPTb2OHDG9sSVhyds7D/XmU1w=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m56ZC-0000p7-8P; Sun, 18 Jul 2021 15:10:48 +0200 X-Now-Playing: The Meters's _Gettin' Funkier All The Time (1): Here Comes The Meter Man & Looka-Ya Py Py_: "Oh, Calcutta!" In-Reply-To: (Glenn Morris's message of "Thu, 10 Jun 2010 23:50:24 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210180 Archived-At: Glenn Morris writes: > I've made this mistake a few times now: > > 1) Mark say 5 files in vc-dir. > > 2) Press v to get a vc-log buffer. > > 3) Realize I should not have marked one of the 5 files, and unmark it > in the vc-dir buffer. > > 4) Forget to kill the existing vc-log buffer, and so end up committing > all 5 files anyway. Somehow that has never happened to me, so I guess it's never occurred to me to do something like that. But I see that the problem is still present in Emacs 28. > I wish that at step 4 when I try to commit, Emacs would check if the > files about to be commited match those marked in the vc-dir buffer, > and if not ask me to confirm the commit. Yeah, that seems like a good idea. I can't really imagine somebody altering the marked files in the vc-dir buffer without wanting to affect which files get checked in on the `C-c C-c'. But before I start poking at this -- would adding a query like this disrupt somebody's work flow? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no