From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#50011: 28.0.50; ffap on a URL in a file is broken Date: Wed, 11 Aug 2021 17:53:51 +0200 Message-ID: <87wnos7zao.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13667"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: 50011@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 11 17:54:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDqYU-0003Lf-AF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Aug 2021 17:54:10 +0200 Original-Received: from localhost ([::1]:33958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDqYS-0003Wi-PU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Aug 2021 11:54:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDqYM-0003WW-Nv for bug-gnu-emacs@gnu.org; Wed, 11 Aug 2021 11:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mDqYM-0008TA-GJ for bug-gnu-emacs@gnu.org; Wed, 11 Aug 2021 11:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mDqYM-0002yv-CW for bug-gnu-emacs@gnu.org; Wed, 11 Aug 2021 11:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Aug 2021 15:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50011 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.162869723911450 (code B ref -1); Wed, 11 Aug 2021 15:54:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 11 Aug 2021 15:53:59 +0000 Original-Received: from localhost ([127.0.0.1]:36349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDqYJ-0002yc-HU for submit@debbugs.gnu.org; Wed, 11 Aug 2021 11:53:59 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:49692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDqYH-0002yN-4n for submit@debbugs.gnu.org; Wed, 11 Aug 2021 11:53:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDqYG-0003WL-K3 for bug-gnu-emacs@gnu.org; Wed, 11 Aug 2021 11:53:56 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:44691) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDqYE-0008Lp-2X for bug-gnu-emacs@gnu.org; Wed, 11 Aug 2021 11:53:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1628697232; bh=FDq6njAwIsW7ojL7w8FThE55sUlNzzSxDdD9lBcaMxE=; h=X-UI-Sender-Class:From:To:Subject:Date; b=UJgFrc1GxOI7ty6URR46tg0dNc3HoJHe3gxEZBHl5+9ZYsT6WgP0T9hA+crER6PGy TDS1scdcin63MBUju8JtPO/tXNxpLMZc8qgZlxekdGqUy6FcE3GDbNebPpTN3+18JP KywgwHYiKM0KQhEUIHcppHjYEI3SGDyfsuBKRiaE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobelfs ([92.73.76.192]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MEm27-1mJZrA3UFv-00GGjO for ; Wed, 11 Aug 2021 17:53:51 +0200 X-Provags-ID: V03:K1:L8G+qDCrtehjq0fOiMfVO2GcXFLrJqDFKdhVQqCrEqlwfWIn8qP iNJjh4sbwP7RLa5FASSAkKihnFXABQ8bdArcioV/BXiBDYrK2MjDzGWwF/iQMIqTTDWCsd5 sJd3tBsVeMu9N77UtNxqkHEQCVcnfQeQhZpqZgqAlqKqko+P+mwxMsCNznuiCIUBYrw0uCi m1KldnDgqj+9Sje0QdpKQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:p7puPiTR47c=:NUCeRLO9ITRe+kswxWBUQr UNf88kBklgJbv36amMhV2v44aH3zgrBO8k92VpQ2aujajSrSeA8GQZTUuAYez7eqHZaQPeqoD E/02av2zbsds04eMKx6JrGnD6mPmNF/AMChg351ZtBnaEXsz6/RaHRhV1dkZQe0Q4qMVuNrPx mHuo9LuNlBVSwffyxzXEsfff3hhzUf9hvrlm3gW4xRoJqymMM10VEMOptbi3Z2RlWnkjCfOOM 6GQV8GMXPkuBDemgKrlZsaT8npN7gYWDxyKYGW6JG2HJruR+c517YgbP1JYDTL2/dmRIFboD7 7vC6/u8n8dbeXn0d+FB9gFtXUIFjdaK4poc0GMffsxpSikgTwSKg3rYFSHDLvVCi2c1dIM+5w z5V0uVTp86sA++VUXqjLokEP5XOUNCgZlYs/j1SylZGbgLK05W0WGBRaslFI4lkNtXbnnuSwo u+744wUwkUh6wRORjKZPIq8uj9GtBVe9+dZ2MBYZUr/ITSO9GhRENBoUXVC9Z9J/xRt+senyz hbminQ/9kwWxisBI7k93+GiuNu3zF6OIzQ3kumOff/XzVPhqdkLeC9yBwplFxA+7y2hz7UZam 2T3YRBsZelUcpElKwZU6wvrrdeXfljmlGIgga2gfvsjsdP5EGncX6Qi1CppCE20c4STX2jB/w mLYzTTTXzsWILT9i05zX+XLUWmtkTfZbPybZNxIlggxl63h9EfdmSIPVEdPJmvjZv02xP4O14 Asa6xcebAY+j5lE26lNd4v06FPbJ5NVgts4VIM7qvqvUimIjv0oWghAj/xJ+CruypVPkHVuQ Received-SPF: pass client-ip=212.227.17.21; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211609 Archived-At: 0. emacs -Q 1. Visit the file CONTRIBUTE in the top level Emacs source directory, put point on the URL https://www.gnu.org/software/emacs/manual/html_node/emacs/Contributing.= html and type `M-x ffap': =3D> Emacs prompts for a file or URL and offers the above URL as default, but after typing RET, nothing happens, instead of the URL being visited in a browser. This is due to this change: @@ -1546,7 +1543,7 @@ ffap-read-file-or-url (progn (push elem file-name-handler-alist) (if (ffap-url-p guess) - (read-file-name prompt "http://" nil nil guess) + (read-file-name prompt guess) (unless guess (setq guess default-directory)) (unless (ffap-file-remote-p guess) in this commit: commit 799a66c454f4dbb06aeab744f92321d95e5043d0 Author: Lars Ingebrigtsen Commit: Lars Ingebrigtsen CommitDate: Mon Aug 9 16:03:02 2021 +0200 Make ffap-read-file-or-url put point at the correct place for URLs * lisp/ffap.el (ffap-read-file-or-url): Put point at the end of URLs (bug#44822). The following patch fixes the bug for me: diff --git a/lisp/ffap.el b/lisp/ffap.el index 635e9814f1..84dcc04a71 100644 =2D-- a/lisp/ffap.el +++ b/lisp/ffap.el @@ -1543,7 +1543,7 @@ ffap-read-file-or-url (progn (push elem file-name-handler-alist) (if (ffap-url-p guess) - (read-file-name prompt guess) + (read-file-name prompt guess guess) (unless guess (setq guess default-directory)) (unless (ffap-file-remote-p guess) In GNU Emacs 28.0.50 (build 8, x86_64-pc-linux-gnu, GTK+ Version 3.24.29, = cairo version 1.17.4) of 2021-08-10 built on strobelfs Repository revision: 75de09b9de2c800d074e2b65a03483d0d44ce3de Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Linux From Scratch 10.2-rc1 Configured using: 'configure --with-native-compilation 'CFLAGS=3D-Og -g3' PKG_CONFIG_PATH=3D/opt/qt5/lib/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix