From: Michael Heerdegen <michael_heerdegen@web.de>
To: Yuchen Pei <hi@ypei.me>
Cc: larsi@gnus.org, 50195@debbugs.gnu.org
Subject: bug#50195: [PATCH] Adding diary-offset, a diary-sexp offsetting another diary-sexp.
Date: Thu, 26 Aug 2021 11:26:03 +0200 [thread overview]
Message-ID: <87wno8iml0.fsf@web.de> (raw)
In-Reply-To: <87k0k8bsuw.fsf@ypei.me> (Yuchen Pei's message of "Thu, 26 Aug 2021 16:52:23 +1000")
[-- Attachment #1: Type: text/plain, Size: 398 bytes --]
Yuchen Pei <hi@ypei.me> writes:
> > I just removed lexical-binding from the header and commented the
> > `with-no-warnings' call in `diary-list-entries-1'.
>
> Which command did you use to compile? I compiled with just `make` and
> there was no warning.
B from dired. But I get these warnings also with "make", just tried now
(using master).
To avoid misunderstandings, this is what I tried:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Test-warnings-in-diary-lib.patch --]
[-- Type: text/x-diff, Size: 1073 bytes --]
From b1f973c7c5ed6591bb7132b9254ee549f44162d2 Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen@web.de>
Date: Thu, 26 Aug 2021 11:21:14 +0200
Subject: [PATCH] Test warnings in diary-lib
---
lisp/calendar/diary-lib.el | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lisp/calendar/diary-lib.el b/lisp/calendar/diary-lib.el
index f57fe26058..8044768476 100644
--- a/lisp/calendar/diary-lib.el
+++ b/lisp/calendar/diary-lib.el
@@ -1,4 +1,4 @@
-;;; diary-lib.el --- diary functions -*- lexical-binding:t -*-
+;;; diary-lib.el --- diary functions
;; Copyright (C) 1989-1990, 1992-1995, 2001-2021 Free Software
;; Foundation, Inc.
@@ -726,7 +726,6 @@ diary-list-entries-1
MONTHS is an array of month names. SYMBOL marks diary entries of the type
in question. ABSFUNC is a function that converts absolute dates to dates
of the appropriate type."
- (with-no-warnings (defvar number) (defvar list-only))
(let ((gdate original-date))
(dotimes (_ number)
(diary-list-entries-2
--
2.30.2
[-- Attachment #3: Type: text/plain, Size: 11 bytes --]
Michael.
next prev parent reply other threads:[~2021-08-26 9:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 3:46 bug#50195: [PATCH] Adding diary-offset, a diary-sexp offsetting another diary-sexp Yuchen Pei
2021-08-25 11:31 ` Lars Ingebrigtsen
2021-08-25 11:52 ` Eli Zaretskii
2021-08-25 12:06 ` Lars Ingebrigtsen
2021-08-25 12:24 ` Eli Zaretskii
2021-08-25 12:38 ` Lars Ingebrigtsen
2021-08-25 15:22 ` Michael Heerdegen
2021-08-25 15:32 ` Michael Heerdegen
2021-08-25 16:07 ` Eli Zaretskii
2021-08-25 16:22 ` Michael Heerdegen
2021-08-26 6:52 ` Yuchen Pei
2021-08-26 9:26 ` Michael Heerdegen [this message]
2021-08-26 6:49 ` bug#50195: [PATCH] Adding diary-offset to diary-lib.el Yuchen Pei
2021-08-26 6:54 ` Yuchen Pei
2021-08-27 13:16 ` Yuchen Pei
2021-09-03 22:40 ` Yuchen Pei
2021-09-04 6:15 ` Eli Zaretskii
2021-09-04 6:29 ` Lars Ingebrigtsen
2021-09-04 7:21 ` Yuchen Pei
2021-08-26 10:26 ` bug#50195: [PATCH] Adding diary-offset, a diary-sexp offsetting another diary-sexp Michael Heerdegen
2021-08-27 13:11 ` Yuchen Pei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wno8iml0.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=50195@debbugs.gnu.org \
--cc=hi@ypei.me \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).