From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#50067: Context menus Date: Tue, 31 Aug 2021 20:43:36 +0300 Message-ID: <87wno1o5rn.fsf@mail.linkov.net> References: <74BC00E9-2509-47DA-9428-1523FF7F3B33@acm.org> <87v942pvcj.fsf@mail.linkov.net> <004A628A-99CC-4C62-8AE2-921C4C38D42A@acm.org> <87h7fkh8z8.fsf@mail.linkov.net> <060413B6-E0EF-491D-986F-3988C255729F@misasa.okayama-u.ac.jp> <87lf4tews5.fsf@mail.linkov.net> <00A9BE5A-D661-42AF-A65B-3B80C7428121@misasa.okayama-u.ac.jp> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23231"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Alan Third , 50067@debbugs.gnu.org To: Tak Kunihiro Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 31 20:06:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mL89G-0005np-TZ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 31 Aug 2021 20:06:14 +0200 Original-Received: from localhost ([::1]:48260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mL89E-0008T2-J3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 31 Aug 2021 14:06:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL895-0008Rx-3H for bug-gnu-emacs@gnu.org; Tue, 31 Aug 2021 14:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52042) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mL894-0008VZ-Ru for bug-gnu-emacs@gnu.org; Tue, 31 Aug 2021 14:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mL894-0001EG-NO for bug-gnu-emacs@gnu.org; Tue, 31 Aug 2021 14:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Aug 2021 18:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50067 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 50067-submit@debbugs.gnu.org id=B50067.16304331414679 (code B ref 50067); Tue, 31 Aug 2021 18:06:02 +0000 Original-Received: (at 50067) by debbugs.gnu.org; 31 Aug 2021 18:05:41 +0000 Original-Received: from localhost ([127.0.0.1]:35352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mL88i-0001DK-I1 for submit@debbugs.gnu.org; Tue, 31 Aug 2021 14:05:40 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:34379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mL88d-0001Cq-11 for 50067@debbugs.gnu.org; Tue, 31 Aug 2021 14:05:36 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id C443F60002; Tue, 31 Aug 2021 18:05:25 +0000 (UTC) In-Reply-To: <00A9BE5A-D661-42AF-A65B-3B80C7428121@misasa.okayama-u.ac.jp> (Tak Kunihiro's message of "Mon, 23 Aug 2021 12:11:27 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213117 Archived-At: >>> ** no multiple horizontal lines >>> >>> Sometimes I see double lines on the context menu. I think that there is >>> no useful case to have double lines. To allow only one horizontal line >>> would look cool. >> >> Right, double separators should be removed. > > OK. This is not easy to do. Because there are menu-items that use the filter :visible, e.g.: (defun prog-context-menu (menu) (require 'xref) (define-key-after menu [prog-separator] menu-bar-separator 'mark-whole-buffer) (define-key-after menu [xref-find-def] '(menu-item "Find Definition" xref-find-definitions-at-mouse :visible (save-excursion (mouse-set-point last-input-event) (xref-backend-identifier-at-point (xref-find-backend))) :help "Find definition of identifier") 'prog-separator) So it's not known whether the menu-item will be displayed until the menu is displayed. So there is no way to remove a stray separator in the context-menu function that creates the context menu. Maybe such items should be rewritten to avoid the filter :visible, e.g.: (defun prog-context-menu (menu) (require 'xref) (define-key-after menu [prog-separator] menu-bar-separator 'mark-whole-buffer) (when (save-excursion (mouse-set-point last-input-event) (xref-backend-identifier-at-point (xref-find-backend))) (define-key-after menu [xref-find-def] '(menu-item "Find Definition" xref-find-definitions-at-mouse :help "Find definition of identifier") 'prog-separator))