From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#50576: 28.0.50; display-buffer-in-previous-window no longer accepts window value for previous-window Date: Tue, 14 Sep 2021 09:35:48 +0300 Organization: LINKOV.NET Message-ID: <87wnnju1gr.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5818"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 50576@debbugs.gnu.org To: Adam Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 14 08:45:45 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQ2CP-0001Ew-CP for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Sep 2021 08:45:45 +0200 Original-Received: from localhost ([::1]:49088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ2CN-0002L3-MD for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Sep 2021 02:45:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ2Bj-0002KW-CP for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 02:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35813) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQ2Bi-0000BV-Vt for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 02:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQ2Bi-00076P-Tn for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 02:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Sep 2021 06:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50576 X-GNU-PR-Package: emacs Original-Received: via spool by 50576-submit@debbugs.gnu.org id=B50576.163160184427188 (code B ref 50576); Tue, 14 Sep 2021 06:45:02 +0000 Original-Received: (at 50576) by debbugs.gnu.org; 14 Sep 2021 06:44:04 +0000 Original-Received: from localhost ([127.0.0.1]:47353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ2Am-00074R-3W for submit@debbugs.gnu.org; Tue, 14 Sep 2021 02:44:04 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:39721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ2Ak-00073g-58 for 50576@debbugs.gnu.org; Tue, 14 Sep 2021 02:44:02 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 819FD1C0007; Tue, 14 Sep 2021 06:43:53 +0000 (UTC) In-Reply-To: (Adam Porter's message of "Mon, 13 Sep 2021 19:43:34 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214279 Archived-At: > It seems the patch in this message: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45688#116 > > which was installed causes the function > display-buffer-in-previous-window to fail when called with an alist > having the previous-window key set to a window value, because it calls > boundp on the value unconditionally rather than checking the type of > the value. Sorry, this was a wrong assumption. Does this patch correctly fix it? diff --git a/lisp/window.el b/lisp/window.el index 2960384e15..1c795cf684 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -8363,7 +8363,7 @@ display-buffer-in-previous-window (throw 'best t))))) ;; When ALIST has a `previous-window' entry, that entry may override ;; anything we found so far. - (when (and previous-window (boundp previous-window)) + (when (and previous-window (symbolp previous-window) (boundp previous-window)) (setq previous-window (symbol-value previous-window))) (when (and (setq window previous-window) (window-live-p window)